Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6914

Tests use assertTrue(....equals(...)) instead of assertEquals()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.8.1, 3.0.0-alpha4
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: test
    • Labels:
      None

      Activity

      Hide
      hadoopqa Hadoop QA added a comment -
      +1 overall



      Vote Subsystem Runtime Comment
      0 reexec 0m 21s Docker mode activated.
      +1 @author 0m 0s The patch does not contain any @author tags.
      +1 test4tests 0m 0s The patch appears to include 5 new or modified test files.
      0 mvndep 0m 49s Maven dependency ordering for branch
      +1 mvninstall 13m 36s trunk passed
      +1 compile 1m 43s trunk passed
      +1 checkstyle 0m 29s trunk passed
      +1 mvnsite 1m 20s trunk passed
      +1 mvneclipse 0m 54s trunk passed
      +1 findbugs 1m 48s trunk passed
      +1 javadoc 0m 50s trunk passed
      0 mvndep 0m 8s Maven dependency ordering for patch
      +1 mvninstall 1m 8s the patch passed
      +1 compile 1m 39s the patch passed
      +1 javac 1m 39s the patch passed
      +1 checkstyle 0m 27s the patch passed
      +1 mvnsite 1m 12s the patch passed
      +1 mvneclipse 0m 45s the patch passed
      +1 whitespace 0m 0s The patch has no whitespace issues.
      +1 findbugs 2m 2s the patch passed
      +1 javadoc 0m 44s the patch passed
      +1 unit 2m 39s hadoop-mapreduce-client-core in the patch passed.
      +1 unit 8m 46s hadoop-mapreduce-client-app in the patch passed.
      +1 unit 106m 46s hadoop-mapreduce-client-jobclient in the patch passed.
      +1 asflicense 0m 26s The patch does not generate ASF License warnings.
      149m 28s



      Subsystem Report/Notes
      Docker Image:yetus/hadoop:14b5c93
      JIRA Issue MAPREDUCE-6914
      JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877646/MAPREDUCE-6914.001.patch
      Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
      uname Linux d3c96e78e4d4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
      Build tool maven
      Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
      git revision trunk / b0e78ae
      Default Java 1.8.0_131
      findbugs v3.1.0-RC1
      Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7028/testReport/
      modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
      Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7028/console
      Powered by Apache Yetus 0.4.0 http://yetus.apache.org

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 5 new or modified test files. 0 mvndep 0m 49s Maven dependency ordering for branch +1 mvninstall 13m 36s trunk passed +1 compile 1m 43s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 20s trunk passed +1 mvneclipse 0m 54s trunk passed +1 findbugs 1m 48s trunk passed +1 javadoc 0m 50s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 1m 8s the patch passed +1 compile 1m 39s the patch passed +1 javac 1m 39s the patch passed +1 checkstyle 0m 27s the patch passed +1 mvnsite 1m 12s the patch passed +1 mvneclipse 0m 45s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 2s the patch passed +1 javadoc 0m 44s the patch passed +1 unit 2m 39s hadoop-mapreduce-client-core in the patch passed. +1 unit 8m 46s hadoop-mapreduce-client-app in the patch passed. +1 unit 106m 46s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 149m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6914 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877646/MAPREDUCE-6914.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d3c96e78e4d4 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b0e78ae Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7028/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7028/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
      Hide
      maya Maya Wexler added a comment -

      +1 (non-binding)

      I verified that all of the test clauses are still valid. Code looks cleaner with assertEquals().

      Show
      maya Maya Wexler added a comment - +1 (non-binding) I verified that all of the test clauses are still valid. Code looks cleaner with assertEquals().
      Hide
      yufeigu Yufei Gu added a comment -

      +1

      Show
      yufeigu Yufei Gu added a comment - +1
      Hide
      yufeigu Yufei Gu added a comment -

      Committed to trunk and branch-2. Thanks for the patch, Daniel Templeton. Thanks for the review, Maya Wexler.

      Show
      yufeigu Yufei Gu added a comment - Committed to trunk and branch-2. Thanks for the patch, Daniel Templeton . Thanks for the review, Maya Wexler .
      Hide
      hudson Hudson added a comment -

      SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12112 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12112/)
      MAPREDUCE-6914. Tests use assertTrue(....equals(...)) instead of (yufei: rev b8e8241854904e3a92b636ffaa6f4c651e47cea2)

      • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
      • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestMultipleInputs.java
      • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java
      • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestJobEndNotifier.java
      • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/rm/TestRMContainerAllocator.java
      Show
      hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12112 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12112/ ) MAPREDUCE-6914 . Tests use assertTrue(....equals(...)) instead of (yufei: rev b8e8241854904e3a92b636ffaa6f4c651e47cea2) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestMultipleInputs.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestQueue.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestJobEndNotifier.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/rm/TestRMContainerAllocator.java

        People

        • Assignee:
          templedf Daniel Templeton
          Reporter:
          templedf Daniel Templeton
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development