Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6905

Fix meaningless operations in TestDFSIO in some situation.

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Flags:
      Patch

      Description

      When run TestDFSIO in write mode with 2 million nrFiles, it will takes hours to create control files and get IOException as last because of directory item limit is exceeded. And, it will leave over 1 million useless files which will be deleted when run TestDFSIO again with acceptable nrFiles.

      17/06/21 09:12:16 INFO fs.TestDFSIO: creating control file: 1024 bytes, 2000000 files
      java.io.IOException: The directory item limit of /benchmarks/TestDFSIO/io_control is exceeded: limit=1048576 items=1048576
      at org.apache.hadoop.hdfs.server.namenode.FSDirectory.verifyMaxDirItems(FSDirectory.java:2033)
      at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addChild(FSDirectory.java:2084)
      at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addLastINode(FSDirectory.java:2053)
      at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addINode(FSDirectory.java:1873)
      at org.apache.hadoop.hdfs.server.namenode.FSDirectory.addFile(FSDirectory.java:327)
      at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInternal(FSNamesystem.java:2750)
      at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFileInt(FSNamesystem.java:2632)
      at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.startFile(FSNamesystem.java:2520)
      at org.apache.hadoop.hdfs.server.namenode.NameNodeRpcServer.create(NameNodeRpcServer.java:579)
      at org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB.create(ClientNamenodeProtocolServerSideTranslatorPB.java:394)
      at org.apache.hadoop.hdfs.protocol.proto.ClientNamenodeProtocolProtos$ClientNamenodeProtocol$2.callBlockingMethod(ClientNamenodeProtocolProtos.java)
      at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:619)
      at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:962)
      at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2040)
      at org.apache.hadoop.ipc.Server$Handler$1.run(Server.java:2036)
      at java.security.AccessController.doPrivileged(Native Method)
      at javax.security.auth.Subject.doAs(Subject.java:415)
      at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1656)
      at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2034)
      at org.apache.hadoop.fs.TestDFSIO.createControlFile(TestDFSIO.java:302)
      at org.apache.hadoop.fs.TestDFSIO.run(TestDFSIO.java:751)
      at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
      at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
      at org.apache.hadoop.fs.TestDFSIO.main(TestDFSIO.java:650)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:606)
      at org.apache.hadoop.util.ProgramDriver$ProgramDescription.invoke(ProgramDriver.java:71)
      at org.apache.hadoop.util.ProgramDriver.run(ProgramDriver.java:144)
      at org.apache.hadoop.test.MapredTestDriver.run(MapredTestDriver.java:118)
      at org.apache.hadoop.test.MapredTestDriver.main(MapredTestDriver.java:126)

      In brief, we'd better check the parameter of nrFiles before it waste our time and hurt our feelings.

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 34s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 15m 0s trunk passed
        +1 compile 0m 28s trunk passed
        +1 checkstyle 0m 19s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 19s trunk passed
        +1 findbugs 0m 27s trunk passed
        +1 javadoc 0m 14s trunk passed
        +1 mvninstall 0m 24s the patch passed
        +1 compile 0m 24s the patch passed
        +1 javac 0m 24s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 27s the patch passed
        +1 mvneclipse 0m 17s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 34s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 111m 0s hadoop-mapreduce-client-jobclient in the patch passed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        132m 25s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874447/MAPREDUCE-6905.001.patch
        JIRA Issue MAPREDUCE-6905
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 9437749873fc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 379f19a
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7000/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7000/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 34s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 15m 0s trunk passed +1 compile 0m 28s trunk passed +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 24s the patch passed +1 javac 0m 24s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 111m 0s hadoop-mapreduce-client-jobclient in the patch passed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 132m 25s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874447/MAPREDUCE-6905.001.patch JIRA Issue MAPREDUCE-6905 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9437749873fc 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 379f19a Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7000/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7000/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the patch LiXin Ge, Sorry for my earlier comment. I think its good enough to merge it .

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the patch LiXin Ge , Sorry for my earlier comment. I think its good enough to merge it .
        Hide
        GeLiXin LiXin Ge added a comment -

        Thanks for your review, Naganarasimha G R. I'm glad to see my patch get through to work

        Show
        GeLiXin LiXin Ge added a comment - Thanks for your review, Naganarasimha G R . I'm glad to see my patch get through to work
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11961 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11961/)
        MAPREDUCE-6905. HADOOP_JOB_HISTORY_OPTS should be (naganarasimha_gr: rev bf1f59937dd5d860c9ed7fefce203d6a9f645182)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11961 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11961/ ) MAPREDUCE-6905 . HADOOP_JOB_HISTORY_OPTS should be (naganarasimha_gr: rev bf1f59937dd5d860c9ed7fefce203d6a9f645182) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/fs/TestDFSIO.java
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Thanks for the contribution LiXin Ge, i have committed to following branches trunk, branch-2 & branch-2.8.

        Show
        Naganarasimha Naganarasimha G R added a comment - Thanks for the contribution LiXin Ge , i have committed to following branches trunk, branch-2 & branch-2.8.
        Hide
        GeLiXin LiXin Ge added a comment -

        That's my pleasure, Naganarasimha G R. Thanks for your review.

        Show
        GeLiXin LiXin Ge added a comment - That's my pleasure, Naganarasimha G R . Thanks for your review.

          People

          • Assignee:
            GeLiXin LiXin Ge
            Reporter:
            GeLiXin LiXin Ge
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development