Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6868

License check for jdiff output files should be ignored

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.2
    • Component/s: build
    • Labels:
      None

      Description

      The following commits added jdiff output for Hadoop 2.8.0 but ASF license header is missing.

      hadoop-mapreduce-project module does not have a setting to ignore the jdiff output files, so the license check fails.

        Activity

        Hide
        vinodkv Vinod Kumar Vavilapalli added a comment -

        2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

        Show
        vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.
        Hide
        djp Junping Du added a comment -

        I have commit the patch to trunk, branch-2 and branch-2.8. Thanks Akira Ajisaka!

        Show
        djp Junping Du added a comment - I have commit the patch to trunk, branch-2 and branch-2.8. Thanks Akira Ajisaka !
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11468 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11468/)
        MAPREDUCE-6868. License check for jdiff output files should be ignored. (junping_du: rev 945b006fe85473c1bb87830dbbfc1df9051c7bb9)

        • (edit) hadoop-mapreduce-project/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #11468 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11468/ ) MAPREDUCE-6868 . License check for jdiff output files should be ignored. (junping_du: rev 945b006fe85473c1bb87830dbbfc1df9051c7bb9) (edit) hadoop-mapreduce-project/pom.xml
        Hide
        djp Junping Du added a comment -

        Thanks Akira Ajisaka for reporting the issue and fixing here. +1 on the patch. Committing it.

        Show
        djp Junping Du added a comment - Thanks Akira Ajisaka for reporting the issue and fixing here. +1 on the patch. Committing it.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Hi Junping Du, would you review this patch?

        Show
        ajisakaa Akira Ajisaka added a comment - Hi Junping Du , would you review this patch?
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 14m 17s trunk passed
        +1 compile 2m 4s trunk passed
        +1 mvnsite 1m 42s trunk passed
        +1 mvneclipse 0m 29s trunk passed
        +1 javadoc 1m 16s trunk passed
        +1 mvninstall 1m 51s the patch passed
        +1 compile 2m 17s the patch passed
        +1 javac 2m 17s the patch passed
        +1 mvnsite 2m 10s the patch passed
        +1 mvneclipse 0m 29s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 3s The patch has no ill-formed XML file.
        +1 javadoc 1m 22s the patch passed
        +1 unit 136m 55s hadoop-mapreduce-project in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        166m 35s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860584/MAPREDUCE-6868.01.patch
        JIRA Issue MAPREDUCE-6868
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml
        uname Linux 60bde44a01d2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e7b7c96
        Default Java 1.8.0_121
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6923/testReport/
        modules C: hadoop-mapreduce-project U: hadoop-mapreduce-project
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6923/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 14m 17s trunk passed +1 compile 2m 4s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 29s trunk passed +1 javadoc 1m 16s trunk passed +1 mvninstall 1m 51s the patch passed +1 compile 2m 17s the patch passed +1 javac 2m 17s the patch passed +1 mvnsite 2m 10s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 3s The patch has no ill-formed XML file. +1 javadoc 1m 22s the patch passed +1 unit 136m 55s hadoop-mapreduce-project in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 166m 35s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12860584/MAPREDUCE-6868.01.patch JIRA Issue MAPREDUCE-6868 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml uname Linux 60bde44a01d2 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e7b7c96 Default Java 1.8.0_121 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6923/testReport/ modules C: hadoop-mapreduce-project U: hadoop-mapreduce-project Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6923/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Attaching a simple patch.

        Show
        ajisakaa Akira Ajisaka added a comment - Attaching a simple patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        License check warning occurs in hadoop-mapreduce-project module.
        https://builds.apache.org/job/PreCommit-YARN-Build/15389/artifact/patchprocess/patch-asflicense-problems.txt

        The jdiff files are ignored in hadoop-common, hadoop-hdfs, and hadoop-yarn. This check should be ignored in hadoop-mapreduce as well.

        Show
        ajisakaa Akira Ajisaka added a comment - License check warning occurs in hadoop-mapreduce-project module. https://builds.apache.org/job/PreCommit-YARN-Build/15389/artifact/patchprocess/patch-asflicense-problems.txt The jdiff files are ignored in hadoop-common, hadoop-hdfs, and hadoop-yarn. This check should be ignored in hadoop-mapreduce as well.

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development