Details

      Description

      The original description of the getNumMapTasks() method in JobConf was invalid, because it referenced to the number of reducer tasks instead of the map tasks.

      from: Get configured the number of reduce tasks for this job.
      to: Get the configured number of map tasks for this job.

      It was maybe the result of a tricky copy-paste

      Github PR: https://github.com/apache/hadoop/pull/205

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -

          LGTM, +1 pending Jenkins.
          patch: https://github.com/apache/hadoop/pull/205.patch

          Show
          ajisakaa Akira Ajisaka added a comment - LGTM, +1 pending Jenkins. patch: https://github.com/apache/hadoop/pull/205.patch
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Moved to MapReduce project.

          Show
          ajisakaa Akira Ajisaka added a comment - Moved to MapReduce project.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 6m 29s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 18m 31s trunk passed
          +1 compile 0m 40s trunk passed
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 43s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 9s trunk passed
          +1 javadoc 0m 33s trunk passed
          +1 mvninstall 0m 32s the patch passed
          +1 compile 0m 29s the patch passed
          +1 javac 0m 29s the patch passed
          +1 checkstyle 0m 20s the patch passed
          +1 mvnsite 0m 33s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 findbugs 1m 15s the patch passed
          +1 javadoc 0m 25s the patch passed
          +1 unit 3m 23s hadoop-mapreduce-client-core in the patch passed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          37m 20s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue MAPREDUCE-6866
          GITHUB PR https://github.com/apache/hadoop/pull/205
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c1b3be29f651 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ab759e9
          Default Java 1.8.0_121
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/artifact/patchprocess/whitespace-eol.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 6m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 18m 31s trunk passed +1 compile 0m 40s trunk passed +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 43s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 9s trunk passed +1 javadoc 0m 33s trunk passed +1 mvninstall 0m 32s the patch passed +1 compile 0m 29s the patch passed +1 javac 0m 29s the patch passed +1 checkstyle 0m 20s the patch passed +1 mvnsite 0m 33s the patch passed +1 mvneclipse 0m 14s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 25s the patch passed +1 unit 3m 23s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 37m 20s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue MAPREDUCE-6866 GITHUB PR https://github.com/apache/hadoop/pull/205 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c1b3be29f651 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ab759e9 Default Java 1.8.0_121 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/artifact/patchprocess/whitespace-eol.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6920/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Show
          joemeszaros Joe Mészáros added a comment - The extra whitespace was removed https://github.com/apache/hadoop/pull/205/commits/978efd212766189c58ea01e9cd9f1b4e399cf742
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thank you for fixing the whitespace issue. +1, checking this in.

          Show
          ajisakaa Akira Ajisaka added a comment - Thank you for fixing the whitespace issue. +1, checking this in.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/hadoop/pull/205

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/hadoop/pull/205
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.8. Thanks Joe Mészáros for your first contribution!

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Joe Mészáros for your first contribution!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11467 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11467/)
          MAPREDUCE-6866. Fix getNumMapTasks() documentation in JobConf. (aajisaka: rev e0a2eb71e3eb3efa865068089b649624132d33a1)

          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11467 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11467/ ) MAPREDUCE-6866 . Fix getNumMapTasks() documentation in JobConf. (aajisaka: rev e0a2eb71e3eb3efa865068089b649624132d33a1) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - 2.8.1 became a security release. Moving fix-version to 2.8.2 after the fact.

            People

            • Assignee:
              joemeszaros Joe Mészáros
              Reporter:
              joemeszaros Joe Mészáros
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 1h
                1h
                Remaining:
                Remaining Estimate - 1h
                1h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development