Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6824

TaskAttemptImpl#createCommonContainerLaunchContext is longer than 150 lines

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 2.9.0, 3.0.0-alpha4
    • None
    • Reviewed

    Description

      ./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TaskAttemptImpl.java:752: private static ContainerLaunchContext createCommonContainerLaunchContext(:3: Method length is 172 lines (max allowed is 150).

      TaskAttemptImpl#createCommonContainerLaunchContext is longer than 150 lines and needs to be refactored.

      Attachments

        1. MAPREDUCE-6824-trunk.003.patch
          15 kB
          Chris Trezzo
        2. MAPREDUCE-6824-trunk.002.patch
          12 kB
          Chris Trezzo
        3. MAPREDUCE-6824-trunk.001.patch
          12 kB
          Chris Trezzo
        4. MAPREDUCE-6824-branch-2.001.patch
          15 kB
          Chris Trezzo

        Issue Links

          Activity

            People

              ctrezzo Chris Trezzo
              ctrezzo Chris Trezzo
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: