Hadoop QA added a comment - 02/Dec/16 21:45 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 22s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 30s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 19s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 34s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 3m 15s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 15m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12841563/MAPREDUCE-6817.01.patch JIRA Issue MAPREDUCE-6817 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6e373d3760b0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / c7ff34f Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6826/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6826/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Karthik Kambatla added a comment - 06/Dec/16 20:36 Patch looks good. Couple of minor comments: In JobInfo, the changes to getStartTimeStr() and the following whitespace fixes seem unrelated. Can we skip them? In TestJobInfo, how does the check for "N/A" match "NA" that we initialize the return string to in the corresponding methods?

Haibo Chen added a comment - 06/Dec/16 22:55 In TestJobInfo, how does the check for "N/A" match "NA" that we initialize the return string to in the corresponding methods? NA is a static field in JobInfo, which is essentially 'N/A'. To avoid confusion, I have updated the patch to directly reference JobInfo.NA in the test.

Hadoop QA added a comment - 06/Dec/16 23:13 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 16s the patch passed +1 javac 0m 16s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 3m 14s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 15m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12842046/MAPREDUCE-6817.02.patch JIRA Issue MAPREDUCE-6817 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 94d5530c155a 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a7288da Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6834/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6834/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Karthik Kambatla added a comment - 07/Dec/16 21:36 +1

Karthik Kambatla added a comment - 07/Dec/16 21:39 Thanks for the fix, Haibo Chen . Just committed this to trunk and branch-2.

Hudson added a comment - 07/Dec/16 22:00 SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10962 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10962/ ) MAPREDUCE-6817 . The format of job start time in JHS is different from (kasha: rev a793cec2c9a7ad80aaf67be9dec2245e8ecce63c) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/webapp/dao/TestJobInfo.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsJobsBlock.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/dao/JobInfo.java