Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6810

hadoop-mapreduce-client-nativetask compilation broken on GCC-6.2.1

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      Description

      I recently upgraded from Fedora 22 to Fedora 25 (I'm assuming this means the latest and greatest compilers, cmake etc.) My trunk build failed with this error:

      [WARNING] /home/raviprak/Code/hadoop/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Log.h:35:67: error: unable to find string literal operatoroperator""_fmt_’ with ‘const char [37]’, ‘long unsigned int’ arguments
      [WARNING]      fprintf(LOG_DEVICE, "%02d/%02d/%02d %02d:%02d:%02d INFO "_fmt_"\n", \
      

      https://access.redhat.com/documentation/en-US/Red_Hat_Developer_Toolset/3/html/User_Guide/sect-Changes_in_Version_3.0-GCC.html

      This applies to any string literal followed without white space by some macro. To fix this, add some white space between the string literal and the macro name.

        Activity

        Hide
        raviprak Ravi Prakash added a comment -

        Simple 1 line fix with whitespaces only

        Show
        raviprak Ravi Prakash added a comment - Simple 1 line fix with whitespaces only
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 34s Docker mode activated.
        +1 @author 0m 1s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 8m 12s trunk passed
        +1 compile 0m 47s trunk passed
        +1 mvnsite 0m 23s trunk passed
        +1 mvneclipse 0m 16s trunk passed
        +1 mvninstall 0m 18s the patch passed
        +1 compile 0m 42s the patch passed
        +1 cc 0m 42s the patch passed
        +1 javac 0m 42s the patch passed
        +1 mvnsite 0m 18s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 unit 1m 6s hadoop-mapreduce-client-nativetask in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        13m 28s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839061/MAPREDUCE-6810.01.patch
        JIRA Issue MAPREDUCE-6810
        Optional Tests asflicense compile cc mvnsite javac unit
        uname Linux 5b0dd0c27bfc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f121d0b
        Default Java 1.8.0_101
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 34s Docker mode activated. +1 @author 0m 1s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 12s trunk passed +1 compile 0m 47s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 16s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 0m 42s the patch passed +1 cc 0m 42s the patch passed +1 javac 0m 42s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 unit 1m 6s hadoop-mapreduce-client-nativetask in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 13m 28s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12839061/MAPREDUCE-6810.01.patch JIRA Issue MAPREDUCE-6810 Optional Tests asflicense compile cc mvnsite javac unit uname Linux 5b0dd0c27bfc 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f121d0b Default Java 1.8.0_101 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-nativetask.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6812/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        raviprak Ravi Prakash added a comment - - edited

        There are no unit test failures that I could see in the jenkins output. Maybe a yetus bug?

        https://gcc.gnu.org/onlinedocs/cpp/Stringification.html suggests I could stringify it, but then that'd change the format of _fmt_ . I think I'll just add the whitespace.

        Could someone please review and commit?

        Show
        raviprak Ravi Prakash added a comment - - edited There are no unit test failures that I could see in the jenkins output. Maybe a yetus bug? https://gcc.gnu.org/onlinedocs/cpp/Stringification.html suggests I could stringify it, but then that'd change the format of _fmt_ . I think I'll just add the whitespace. Could someone please review and commit?
        Hide
        vvasudev Varun Vasudev added a comment - - edited

        The patch looks good to me. I'll try to setup a VM and see if the tests pass for me as well.

        Show
        vvasudev Varun Vasudev added a comment - - edited The patch looks good to me. I'll try to setup a VM and see if the tests pass for me as well.
        Hide
        raviprak Ravi Prakash added a comment -

        Thanks Varun! This seems like a Yetus issue. No tests actually failed for me on my Linux box.

        Committing shortly.

        Show
        raviprak Ravi Prakash added a comment - Thanks Varun! This seems like a Yetus issue. No tests actually failed for me on my Linux box. Committing shortly.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10916/)
        MAPREDUCE-6810. Fix hadoop-mapreduce-client-nativetask compilation with (raviprak: rev 7c848719de778929258f1f9e2778e56f267c90ed)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Log.h
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10916 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10916/ ) MAPREDUCE-6810 . Fix hadoop-mapreduce-client-nativetask compilation with (raviprak: rev 7c848719de778929258f1f9e2778e56f267c90ed) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/Log.h

          People

          • Assignee:
            raviprak Ravi Prakash
            Reporter:
            raviprak Ravi Prakash
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development