Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6808

Log map attempts as part of shuffle handler audit log

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.9.0, 3.0.0-alpha4, 2.8.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      With the introduction tez, multiple unrelated reducers in the same job will have the same id. The audit log won't be able to distinguish which map attempt the reduce was fetching. This jira is to discuss the possibility to add map attempts logging to distinguish between the two.

      1. MAPREDUCE-6808_v1.patch
        1 kB
        Gergő Pásztor
      2. MAPREDUCE-6808_v2.patch
        1 kB
        Gergő Pásztor

        Issue Links

          Activity

          Hide
          kshukla Kuhu Shukla added a comment -

          Linking related JIRA for Custom ShuffleHandler in Tez. Gergő Pásztor, Would you be providing a patch for this JIRA sometime soon? Thanks!

          Show
          kshukla Kuhu Shukla added a comment - Linking related JIRA for Custom ShuffleHandler in Tez. Gergő Pásztor , Would you be providing a patch for this JIRA sometime soon? Thanks!
          Hide
          jeagles Jonathan Eagles added a comment -

          Agree with Kuhu Shukla. Having this JIRA fixed would help me to better support tez. Any chance of a patch coming soon, Haibo Chen, Gergő Pásztor?

          Show
          jeagles Jonathan Eagles added a comment - Agree with Kuhu Shukla . Having this JIRA fixed would help me to better support tez. Any chance of a patch coming soon, Haibo Chen , Gergő Pásztor ?
          Hide
          pairg Gergő Pásztor added a comment -

          I will look at it tomorrow. However I can't say that this will be solved before the holiday season (what will start in this weekend and will end in January).

          Show
          pairg Gergő Pásztor added a comment - I will look at it tomorrow. However I can't say that this will be solved before the holiday season (what will start in this weekend and will end in January).
          Hide
          kshukla Kuhu Shukla added a comment -

          Gergő Pásztor, Just FYKI posted the Tez equivalent patch https://issues.apache.org/jira/secure/attachment/12843944/TEZ-3532.002.patch which prints the attempts list that the reducer is trying to fetch. Hope this helps!

          Show
          kshukla Kuhu Shukla added a comment - Gergő Pásztor , Just FYKI posted the Tez equivalent patch https://issues.apache.org/jira/secure/attachment/12843944/TEZ-3532.002.patch which prints the attempts list that the reducer is trying to fetch. Hope this helps!
          Hide
          pairg Gergő Pásztor added a comment -

          Sorry for the late reply, I attached a patch.

          Show
          pairg Gergő Pásztor added a comment - Sorry for the late reply, I attached a patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 44s trunk passed
          +1 compile 0m 16s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 25s trunk passed
          +1 javadoc 0m 13s trunk passed
          +1 mvninstall 0m 14s the patch passed
          +1 compile 0m 14s the patch passed
          +1 javac 0m 14s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 15s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 29s the patch passed
          +1 javadoc 0m 11s the patch passed
          +1 unit 0m 18s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 19s The patch does not generate ASF License warnings.
          18m 41s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846023/MAPREDUCE-6808_v1.patch
          JIRA Issue MAPREDUCE-6808
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux a0a149a8ef36 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4a659ff
          Default Java 1.8.0_111
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6862/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6862/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 44s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 25s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 14s the patch passed +1 compile 0m 14s the patch passed +1 javac 0m 14s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 29s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 18s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 18m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12846023/MAPREDUCE-6808_v1.patch JIRA Issue MAPREDUCE-6808 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a0a149a8ef36 3.13.0-105-generic #152-Ubuntu SMP Fri Dec 2 15:37:11 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4a659ff Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6862/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6862/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          pairg Gergő Pásztor added a comment -

          I don't think that a test needed for this, but let me know if I'm wrong!

          Show
          pairg Gergő Pásztor added a comment - I don't think that a test needed for this, but let me know if I'm wrong!
          Hide
          kshukla Kuhu Shukla added a comment -

          +1 lgtm non-binding. I don't think we need a test.

          Show
          kshukla Kuhu Shukla added a comment - +1 lgtm non-binding. I don't think we need a test.
          Hide
          templedf Daniel Templeton added a comment -

          Tiny nit, but can we make "mapper" be "mappers"?

          Show
          templedf Daniel Templeton added a comment - Tiny nit, but can we make "mapper" be "mappers"?
          Hide
          pairg Gergő Pásztor added a comment -

          Daniel Templeton mapper -> mappers

          Show
          pairg Gergő Pásztor added a comment - Daniel Templeton mapper -> mappers
          Hide
          kshukla Kuhu Shukla added a comment -

          +1 (non-binding).

          Show
          kshukla Kuhu Shukla added a comment - +1 (non-binding).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 13m 33s trunk passed
          +1 compile 0m 16s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 15s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 0m 13s the patch passed
          +1 javac 0m 13s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 15s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 0m 28s the patch passed
          +1 javadoc 0m 11s the patch passed
          +1 unit 0m 18s hadoop-mapreduce-client-shuffle in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          18m 29s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849346/MAPREDUCE-6808_v2.patch
          JIRA Issue MAPREDUCE-6808
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 52b8f16c7ca1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 18e1d68
          Default Java 1.8.0_121
          findbugs v3.0.0
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6879/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6879/console
          Powered by Apache Yetus 0.3.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 13m 33s trunk passed +1 compile 0m 16s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 15s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 0m 13s the patch passed +1 javac 0m 13s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 15s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 28s the patch passed +1 javadoc 0m 11s the patch passed +1 unit 0m 18s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 18m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12849346/MAPREDUCE-6808_v2.patch JIRA Issue MAPREDUCE-6808 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52b8f16c7ca1 3.13.0-106-generic #153-Ubuntu SMP Tue Dec 6 15:44:32 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 18e1d68 Default Java 1.8.0_121 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6879/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6879/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Sweet. +1

          Show
          templedf Daniel Templeton added a comment - Sweet. +1
          Hide
          templedf Daniel Templeton added a comment -

          Committed to trunk. Thanks for the patch, Gergő Pásztor, and the reviews, Kuhu Shukla!

          Show
          templedf Daniel Templeton added a comment - Committed to trunk. Thanks for the patch, Gergő Pásztor , and the reviews, Kuhu Shukla !
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11175 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11175/)
          MAPREDUCE-6808. Log map attempts as part of shuffle handler audit log (templedf: rev a7463b6c88f698950a2f326030261001aa51b35e)

          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11175 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11175/ ) MAPREDUCE-6808 . Log map attempts as part of shuffle handler audit log (templedf: rev a7463b6c88f698950a2f326030261001aa51b35e) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Gergő Pásztor! I committed this to branch-2 and branch-2.8 as well.

          Show
          jlowe Jason Lowe added a comment - Thanks, Gergő Pásztor ! I committed this to branch-2 and branch-2.8 as well.

            People

            • Assignee:
              pairg Gergő Pásztor
              Reporter:
              jeagles Jonathan Eagles
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development