Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6792

Allow user's full principal name as owner of MapReduce staging directory in JobSubmissionFiles#JobStagingDir()

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: client
    • Labels:
      None

      Description

      Background -
      Currently, JobSubmissionFiles#JobStagingDir() assumes that file owner returned as part of FileSystem#getFileStatus() is always user's short principal name, which is true for HDFS. But, some file systems which are HDFS compatible like Azure Data Lake Store (ADLS) and work in multi tenant environment can have users with same names belonging to different domains. For example, user1@company1.com and user1@company2.com. It will be ambiguous, if FileSystem#getFileStatus() returns only the user's short principal name (without domain name) as the owner of the file/directory.

      The following code block allows only short user principal name as owner. It simply fails saying that ownership on the staging directory is not as expected, if owner returned by the FileStatus#getOwner() is not equal to short principal name of the current user.

          String realUser;
          String currentUser;
          UserGroupInformation ugi = UserGroupInformation.getLoginUser();
          realUser = ugi.getShortUserName();
          currentUser = UserGroupInformation.getCurrentUser().getShortUserName();
          if (fs.exists(stagingArea)) {
            FileStatus fsStatus = fs.getFileStatus(stagingArea);
            String owner = fsStatus.getOwner();
            if (!(owner.equals(currentUser) || owner.equals(realUser))) {
               throw new IOException("The ownership on the staging directory " +
                            stagingArea + " is not as expected. " +
                            "It is owned by " + owner + ". The directory must " +
                            "be owned by the submitter " + currentUser + " or " +
                            "by " + realUser);
            }
      	  

      The proposal is to remove the strict restriction on short principal name by allowing the user's full principal name as owner of staging area directory in JobSubmissionFiles#JobStagingDir().

      1. MAPREDUCE-6792.1.patch
        3 kB
        Santhosh G Nayak
      2. MAPREDUCE-6792.2.patch
        10 kB
        Santhosh G Nayak
      3. MAPREDUCE-6792.3.patch
        11 kB
        Santhosh G Nayak

        Activity

        Hide
        snayak Santhosh G Nayak added a comment -

        Attaching a patch containing the proposed changes.

        Show
        snayak Santhosh G Nayak added a comment - Attaching a patch containing the proposed changes.
        Hide
        djp Junping Du added a comment -

        Hi Santhosh G Nayak, thanks for reporting the issue and your patch contribution! I think this issue reported here is valid so assign the JIRA to you. Will review you patch and put up my comments soon.

        Show
        djp Junping Du added a comment - Hi Santhosh G Nayak , thanks for reporting the issue and your patch contribution! I think this issue reported here is valid so assign the JIRA to you. Will review you patch and put up my comments soon.
        Hide
        djp Junping Du added a comment -

        Submit the patch for kick off Jenkins' test.
        The patch looks good in overall. Several comments:
        1. fileOwner.equalsIgnoreCase(currentUser.getUserName()) - I think our current assumption in hadoop is user name should be case sensitive, so user and USER are treated as different user. In AzureFS or other similar cloud based FS, do we change the assumption here especially for domain name? If not, we should keep case sensitive check here.
        2. The exception message include all possible usernames, it could be duplicated in case login user = real user (in case no proxy user get used). So we should do a quick check and only log both when login user != real user. Isn't it?
        3. It would be great if we can figure out some way to add unit test for use case that we are adding here.

        Show
        djp Junping Du added a comment - Submit the patch for kick off Jenkins' test. The patch looks good in overall. Several comments: 1. fileOwner.equalsIgnoreCase(currentUser.getUserName()) - I think our current assumption in hadoop is user name should be case sensitive, so user and USER are treated as different user. In AzureFS or other similar cloud based FS, do we change the assumption here especially for domain name? If not, we should keep case sensitive check here. 2. The exception message include all possible usernames, it could be duplicated in case login user = real user (in case no proxy user get used). So we should do a quick check and only log both when login user != real user. Isn't it? 3. It would be great if we can figure out some way to add unit test for use case that we are adding here.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 18s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 30s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 49s trunk passed
        +1 javadoc 0m 22s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 21s the patch passed
        +1 javac 0m 21s the patch passed
        +1 checkstyle 0m 14s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5)
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 57s the patch passed
        +1 javadoc 0m 19s the patch passed
        +1 unit 2m 30s hadoop-mapreduce-client-core in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        16m 47s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833057/MAPREDUCE-6792.1.patch
        JIRA Issue MAPREDUCE-6792
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dd6e11e806bd 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 901eca0
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6758/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6758/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 41s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 49s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 14s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 4 unchanged - 1 fixed = 4 total (was 5) +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 57s the patch passed +1 javadoc 0m 19s the patch passed +1 unit 2m 30s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 16m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12833057/MAPREDUCE-6792.1.patch JIRA Issue MAPREDUCE-6792 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dd6e11e806bd 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 901eca0 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6758/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6758/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        snayak Santhosh G Nayak added a comment -

        Junping Du,Thanks for reviewing the patch.

        1. fileOwner.equalsIgnoreCase(currentUser.getUserName()) - I think our current assumption in hadoop is user name should be case sensitive, so user and USER are treated as different user. In AzureFS or other similar cloud based FS, do we change the assumption here especially for domain name? If not, we should keep case sensitive check here

        I would suggest the user's full principal name comparison to be case insensitive for below 2 reasons,

        • rfc4343, talks about the case insensitivity of domain names as a standard and in most cases, Kerberos realm is domain name, in upper-case letters. Quoting the relevant line from What-is-a-Kerberos-Principal,

          In most cases, your Kerberos realm is your domain name, in upper-case letters. For example, the machine daffodil.example.com would be in the realm EXAMPLE.COM.

          So, to be able to match the file owner user@example.com coming from external cloud storage as part of FileSystem.getFileStatus() to user@EXAMPLE.COM from UserGroupInformation.getUserName(), it is necessary that we use case insensitive comparison.

        • In Active Directory(AD) and Azure, the principal names user@example.com and USER@example.com are same.

        2. The exception message include all possible usernames, it could be duplicated in case login user = real user (in case no proxy user get used). So we should do a quick check and only log both when login user != real user. Isn't it?

        Yes, I agree with you. Addressed it in patch #2.

        3. It would be great if we can figure out some way to add unit test for use case that we are adding here.

        Added few unit tests in patch #2 for the use case we are adding.

        Show
        snayak Santhosh G Nayak added a comment - Junping Du ,Thanks for reviewing the patch. 1. fileOwner.equalsIgnoreCase(currentUser.getUserName()) - I think our current assumption in hadoop is user name should be case sensitive, so user and USER are treated as different user. In AzureFS or other similar cloud based FS, do we change the assumption here especially for domain name? If not, we should keep case sensitive check here I would suggest the user's full principal name comparison to be case insensitive for below 2 reasons, rfc4343 , talks about the case insensitivity of domain names as a standard and in most cases, Kerberos realm is domain name, in upper-case letters. Quoting the relevant line from What-is-a-Kerberos-Principal , In most cases, your Kerberos realm is your domain name, in upper-case letters. For example, the machine daffodil.example.com would be in the realm EXAMPLE.COM. So, to be able to match the file owner user@example.com coming from external cloud storage as part of FileSystem.getFileStatus() to user@EXAMPLE.COM from UserGroupInformation.getUserName() , it is necessary that we use case insensitive comparison. In Active Directory(AD) and Azure, the principal names user@example.com and USER@example.com are same. 2. The exception message include all possible usernames, it could be duplicated in case login user = real user (in case no proxy user get used). So we should do a quick check and only log both when login user != real user. Isn't it? Yes, I agree with you. Addressed it in patch #2. 3. It would be great if we can figure out some way to add unit test for use case that we are adding here. Added few unit tests in patch #2 for the use case we are adding.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 50s trunk passed
        +1 compile 0m 22s trunk passed
        +1 checkstyle 0m 16s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 0m 47s trunk passed
        +1 javadoc 0m 20s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 20s the patch passed
        +1 javac 0m 20s the patch passed
        -1 checkstyle 0m 14s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 7 new + 1 unchanged - 4 fixed = 8 total (was 5)
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 51s the patch passed
        -1 javadoc 0m 18s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core generated 6 new + 2496 unchanged - 0 fixed = 2502 total (was 2496)
        +1 unit 2m 27s hadoop-mapreduce-client-core in the patch passed.
        -1 asflicense 0m 15s The patch generated 1 ASF License warnings.
        15m 31s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834345/MAPREDUCE-6792.2.patch
        JIRA Issue MAPREDUCE-6792
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 243b627bab74 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 73504b1
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
        javadoc https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 50s trunk passed +1 compile 0m 22s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 47s trunk passed +1 javadoc 0m 20s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed -1 checkstyle 0m 14s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 7 new + 1 unchanged - 4 fixed = 8 total (was 5) +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 51s the patch passed -1 javadoc 0m 18s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core generated 6 new + 2496 unchanged - 0 fixed = 2502 total (was 2496) +1 unit 2m 27s hadoop-mapreduce-client-core in the patch passed. -1 asflicense 0m 15s The patch generated 1 ASF License warnings. 15m 31s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834345/MAPREDUCE-6792.2.patch JIRA Issue MAPREDUCE-6792 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 243b627bab74 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73504b1 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt javadoc https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/diff-javadoc-javadoc-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6767/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 37s trunk passed
        +1 compile 0m 23s trunk passed
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 47s trunk passed
        +1 javadoc 0m 21s trunk passed
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 21s the patch passed
        +1 javac 0m 21s the patch passed
        +1 checkstyle 0m 13s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5)
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 50s the patch passed
        +1 javadoc 0m 18s the patch passed
        +1 unit 2m 27s hadoop-mapreduce-client-core in the patch passed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        15m 16s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834368/MAPREDUCE-6792.3.patch
        JIRA Issue MAPREDUCE-6792
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d8696a8572f0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 73504b1
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6768/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6768/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 37s trunk passed +1 compile 0m 23s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 47s trunk passed +1 javadoc 0m 21s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 13s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 1 unchanged - 4 fixed = 1 total (was 5) +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 50s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 2m 27s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 15m 16s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834368/MAPREDUCE-6792.3.patch JIRA Issue MAPREDUCE-6792 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d8696a8572f0 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 73504b1 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6768/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6768/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks Santhosh G Nayak for addressing my comments above. The reason for comparing full principal name in case insensitive way make sense to me. After adding unit test and get rid of duplicated warn messages, the latest patch (03) LGTM.
        +1. Will commit it shortly.

        Show
        djp Junping Du added a comment - Thanks Santhosh G Nayak for addressing my comments above. The reason for comparing full principal name in case insensitive way make sense to me. After adding unit test and get rid of duplicated warn messages, the latest patch (03) LGTM. +1. Will commit it shortly.
        Hide
        djp Junping Du added a comment -

        I have commit the latest patch to trunk and branch-2. Thanks Santhosh G Nayak for contributing the patch!

        Show
        djp Junping Du added a comment - I have commit the latest patch to trunk and branch-2. Thanks Santhosh G Nayak for contributing the patch!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10675 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10675/)
        MAPREDUCE-6792. Allow user's full principal name as owner of MapReduce (junping_du: rev 9b7ce948a52f4ef433dc958ec891b669a669d7c2)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java
        • (add) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJobSubmissionFiles.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10675 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10675/ ) MAPREDUCE-6792 . Allow user's full principal name as owner of MapReduce (junping_du: rev 9b7ce948a52f4ef433dc958ec891b669a669d7c2) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/JobSubmissionFiles.java (add) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/TestJobSubmissionFiles.java

          People

          • Assignee:
            snayak Santhosh G Nayak
            Reporter:
            snayak Santhosh G Nayak
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development