Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6782

JHS task page search based on each individual column not working

    Details

    • Hadoop Flags:
      Reviewed

      Description

      Submit mapreduce pi job with 10 maps
      In Jobs history server selection completed job
      Select maps to Task Page for job
      Search in individual column fields

      Expected
      Search should be working fine in task page for individual columns

      Actual
      Search not working for individual column in task page
      In Attempts page the same search is working fine

      jquery.dataTables.min.js:109
       Uncaught TypeError: Cannot read property 'oFeatures' of null
      fnFilter @ jquery.dataTables.min.js:109(anonymous function) @ m:49dispatch
       @ jquery-1.8.2.min.js:2h @ jquery-1.8.2.min.js:2
      
      1. MAPREDUCE-6782.01.patch
        1 kB
        Ajith S
      2. MAPREDUCE-6782.02.patch
        1 kB
        Ajith S

        Activity

        Hide
        gu chi gu-chi added a comment -

        Bibin A Chundatt As I checked the cause, this issue comes because the table element id does not match what the script want.

        In HsTasksPage.java set the table id as 'tasks', but in HsTasksBlock.java which render the table, the table id is set to

            if(type != null)
              thead =
                  html.table("#" + app.getJob().getID()
                + type).$class("dt-tasks").thead();
            else
              thead = html.table("#tasks").thead();

        So, the table id could be 'jobid...MAP'. For this point, I not see what is the concern of this design, in AppMaster task page, AM just use table id of 'tasks'

        Show
        gu chi gu-chi added a comment - Bibin A Chundatt As I checked the cause, this issue comes because the table element id does not match what the script want. In HsTasksPage.java set the table id as 'tasks' , but in HsTasksBlock.java which render the table, the table id is set to if(type != null) thead = html.table("#" + app.getJob().getID() + type).$class("dt-tasks").thead(); else thead = html.table("#tasks").thead(); So, the table id could be 'jobid...MAP'. For this point, I not see what is the concern of this design, in AppMaster task page, AM just use table id of 'tasks'
        Hide
        gu chi gu-chi added a comment -

        Please assign to me

        Show
        gu chi gu-chi added a comment - Please assign to me
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        As per internal discussion with you( that you will be working on root cause), assigned to you.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited As per internal discussion with you( that you will be working on root cause), assigned to you.
        Hide
        Naganarasimha Naganarasimha G R added a comment -

        Hi gu-chi,
        hope you could attach a patch to understand the fix better .

        Show
        Naganarasimha Naganarasimha G R added a comment - Hi gu-chi , hope you could attach a patch to understand the fix better .
        Hide
        bibinchundatt Bibin A Chundatt added a comment -

        gu-chi
        IIUC the change you mentioned was done as part of YARN-237.

        Show
        bibinchundatt Bibin A Chundatt added a comment - gu-chi IIUC the change you mentioned was done as part of YARN-237 .
        Hide
        ajithshetty Ajith S added a comment -

        I have solution for this, please assign this issue to me (already discussed with gu-chi)

        Show
        ajithshetty Ajith S added a comment - I have solution for this, please assign this issue to me (already discussed with gu-chi )
        Hide
        brahmareddy Brahma Reddy Battula added a comment - - edited

        Ajith S thanks for interest.

        I have solution for this, please assign this issue to me (already discussed with gu-chi)

        Done, Added you in contributor list and assigned to to you.

        Show
        brahmareddy Brahma Reddy Battula added a comment - - edited Ajith S thanks for interest. I have solution for this, please assign this issue to me (already discussed with gu-chi) Done, Added you in contributor list and assigned to to you.
        Hide
        ajithshetty Ajith S added a comment -

        Please review

        Show
        ajithshetty Ajith S added a comment - Please review
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 57s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 15s trunk passed
        +1 findbugs 0m 31s trunk passed
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        -1 checkstyle 0m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: The patch generated 1 new + 17 unchanged - 1 fixed = 18 total (was 18)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 10s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 33s the patch passed
        +1 javadoc 0m 10s the patch passed
        +1 unit 3m 4s hadoop-mapreduce-client-hs in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        15m 0s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837509/MAPREDUCE-6782.01.patch
        JIRA Issue MAPREDUCE-6782
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6176ca19a264 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d8bab3d
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 57s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed -1 checkstyle 0m 10s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: The patch generated 1 new + 17 unchanged - 1 fixed = 18 total (was 18) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 10s the patch passed +1 unit 3m 4s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 15m 0s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837509/MAPREDUCE-6782.01.patch JIRA Issue MAPREDUCE-6782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6176ca19a264 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d8bab3d Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6798/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Ajith S for the patch.
        Changes LGTM. I tested the UI and am able to search each column in tasks page.

        Checkstyle issue can be fixed though.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Ajith S for the patch. Changes LGTM. I tested the UI and am able to search each column in tasks page. Checkstyle issue can be fixed though.
        Hide
        ajithshetty Ajith S added a comment -

        i have attached new patch with checkstyle fixed, please review

        Show
        ajithshetty Ajith S added a comment - i have attached new patch with checkstyle fixed, please review
        Hide
        varun_saxena Varun Saxena added a comment -

        Thanks Ajith S for the patch.
        Changes LGTM. Tests are not required as this is a UI related issue.

        Will commit it by tomorrow unless there are further comments.

        Show
        varun_saxena Varun Saxena added a comment - Thanks Ajith S for the patch. Changes LGTM. Tests are not required as this is a UI related issue. Will commit it by tomorrow unless there are further comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 6m 45s trunk passed
        +1 compile 0m 19s trunk passed
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 22s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 28s trunk passed
        +1 javadoc 0m 13s trunk passed
        +1 mvninstall 0m 17s the patch passed
        +1 compile 0m 15s the patch passed
        +1 javac 0m 15s the patch passed
        +1 checkstyle 0m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: The patch generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18)
        +1 mvnsite 0m 19s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 13s the patch passed
        +1 unit 3m 38s hadoop-mapreduce-client-hs in the patch passed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        15m 26s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e809691
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837696/MAPREDUCE-6782.02.patch
        JIRA Issue MAPREDUCE-6782
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 25e9800e9165 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ca33bdd
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6800/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6800/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 45s trunk passed +1 compile 0m 19s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 17s the patch passed +1 compile 0m 15s the patch passed +1 javac 0m 15s the patch passed +1 checkstyle 0m 11s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs: The patch generated 0 new + 17 unchanged - 1 fixed = 17 total (was 18) +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 3m 38s hadoop-mapreduce-client-hs in the patch passed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 15m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:e809691 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12837696/MAPREDUCE-6782.02.patch JIRA Issue MAPREDUCE-6782 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 25e9800e9165 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ca33bdd Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6800/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6800/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        varun_saxena Varun Saxena added a comment -

        Committing it shortly.

        Show
        varun_saxena Varun Saxena added a comment - Committing it shortly.
        Hide
        varun_saxena Varun Saxena added a comment -

        Committed it to trunk, branch-2.
        Thanks Ajith S for your contribution and thanks Bibin A Chundatt for raising the issue.

        Show
        varun_saxena Varun Saxena added a comment - Committed it to trunk, branch-2. Thanks Ajith S for your contribution and thanks Bibin A Chundatt for raising the issue.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10788 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10788/)
        MAPREDUCE-6782. JHS task page search based on each individual column not (varunsaxena: rev 026b39ad9d9336b1efdd8e2ffb9a508cb0db6259)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTasksPage.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10788 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10788/ ) MAPREDUCE-6782 . JHS task page search based on each individual column not (varunsaxena: rev 026b39ad9d9336b1efdd8e2ffb9a508cb0db6259) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsTasksPage.java

          People

          • Assignee:
            ajithshetty Ajith S
            Reporter:
            bibinchundatt Bibin A Chundatt
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development