Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6728

Give fetchers hint when ShuffleHandler rejects a shuffling connection

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha2
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      If # of open shuffle connection to a node goes over the max, ShuffleHandler closes the connection immediately without giving fetchers any hint of the reason, which causes fetchers to fail due to exceptions

      java.net.SocketException: Unexpected end of file from server
      at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:772)
      at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
      at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:769)
      at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
      at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323)
      at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.verifyConnection(Fetcher.java:430)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.setupConnectionsWithRetry(Fetcher.java:395)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.openShuffleUrl(Fetcher.java:266)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.copyFromHost(Fetcher.java:323)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.run(Fetcher.java:193)

      OR

      java.net.SocketException: Connection reset
      at java.net.SocketInputStream.read(SocketInputStream.java:196)
      at java.net.SocketInputStream.read(SocketInputStream.java:122)
      at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
      at java.io.BufferedInputStream.read1(BufferedInputStream.java:275)
      at java.io.BufferedInputStream.read(BufferedInputStream.java:334)
      at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:687)
      at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
      at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:769)
      at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
      at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1323)
      at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.verifyConnection(Fetcher.java:430)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.setupConnectionsWithRetry(Fetcher.java:395)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.openShuffleUrl(Fetcher.java:266)
      at org.apache.hadoop.mapreduce.task.reduce.Fetcher.copyFromHost(Fetcher.java

      Such failures are counted as fetcher failures

      1. MAPREDUCE-6728-branch-2.8.06.patch
        16 kB
        Haibo Chen
      2. mapreduce6728.branch-2.8.patch
        16 kB
        Haibo Chen
      3. mapreduce6728.006.patch
        16 kB
        Haibo Chen
      4. mapreduce6728.005.patch
        16 kB
        Haibo Chen
      5. mapreduce6728.004.patch
        15 kB
        Haibo Chen
      6. mapreduce6728.003.patch
        15 kB
        Haibo Chen
      7. mapreduce6728.002.patch
        15 kB
        Haibo Chen
      8. mapreduce6728.001.patch
        10 kB
        Haibo Chen
      9. mapreduce6728.prelim.patch
        10 kB
        Haibo Chen

        Activity

        Hide
        haibochen Haibo Chen added a comment -

        The unnecessary fetcher failures can be avoided if SHuffleHandler sends a special http response code (429) before it rejects connection so that fetchers can back off upon receiving the code.

        Show
        haibochen Haibo Chen added a comment - The unnecessary fetcher failures can be avoided if SHuffleHandler sends a special http response code (429) before it rejects connection so that fetchers can back off upon receiving the code.
        Hide
        haibochen Haibo Chen added a comment -

        Uploading a preliminary patch to implement the idea above.
        1) ShuffleHandler sends a 429 (Too-many-requests) response code before it closes the connection when max fetcher connection is reached.
        2) Fetchers checks the response code before it verified the connection. If 429 is seen, the host is penalized for a fixed period (ShuffleSchedulerImpl.INITIAL_PENALTY). The host is put back into the queue but not reported as failed.
        3) Error code 429 is declared twice in both Fetcher and ShuffleHandler. This is due to the fact that 429 is not declared in HttpURLConnection and to avoid circular dependency between the two modules.

        Show
        haibochen Haibo Chen added a comment - Uploading a preliminary patch to implement the idea above. 1) ShuffleHandler sends a 429 (Too-many-requests) response code before it closes the connection when max fetcher connection is reached. 2) Fetchers checks the response code before it verified the connection. If 429 is seen, the host is penalized for a fixed period (ShuffleSchedulerImpl.INITIAL_PENALTY). The host is put back into the queue but not reported as failed. 3) Error code 429 is declared twice in both Fetcher and ShuffleHandler. This is due to the fact that 429 is not declared in HttpURLConnection and to avoid circular dependency between the two modules.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 57s Maven dependency ordering for branch
        +1 mvninstall 6m 59s trunk passed
        +1 compile 1m 39s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 20s trunk passed
        +1 javadoc 0m 35s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 0m 38s the patch passed
        +1 compile 1m 36s the patch passed
        +1 javac 1m 36s the patch passed
        -1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 281 unchanged - 1 fixed = 282 total (was 282)
        +1 mvnsite 0m 42s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 25s the patch passed
        +1 javadoc 0m 32s the patch passed
        +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 17s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        22m 41s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816937/mapreduce6728.prelim.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 088f20ab8353 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 932aed6
        Default Java 1.8.0_91
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 57s Maven dependency ordering for branch +1 mvninstall 6m 59s trunk passed +1 compile 1m 39s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 20s trunk passed +1 javadoc 0m 35s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 0m 38s the patch passed +1 compile 1m 36s the patch passed +1 javac 1m 36s the patch passed -1 checkstyle 0m 25s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 281 unchanged - 1 fixed = 282 total (was 282) +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 25s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 17s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 22m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12816937/mapreduce6728.prelim.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 088f20ab8353 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 932aed6 Default Java 1.8.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6605/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        New patch uploaded to accommodate the checkstyle warning

        Show
        haibochen Haibo Chen added a comment - New patch uploaded to accommodate the checkstyle warning
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 33s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 8m 15s trunk passed
        +1 compile 1m 40s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 27s trunk passed
        +1 findbugs 1m 14s trunk passed
        +1 javadoc 0m 35s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 36s the patch passed
        +1 compile 1m 34s the patch passed
        +1 javac 1m 34s the patch passed
        +1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 280 unchanged - 1 fixed = 280 total (was 281)
        +1 mvnsite 0m 42s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 21s the patch passed
        +1 javadoc 0m 30s the patch passed
        +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        23m 29s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817537/mapreduce6728.001.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 1032caec4efb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bf6f4a3
        Default Java 1.8.0_91
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6609/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6609/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 33s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 8m 15s trunk passed +1 compile 1m 40s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 14s trunk passed +1 javadoc 0m 35s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 36s the patch passed +1 compile 1m 34s the patch passed +1 javac 1m 34s the patch passed +1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 0 new + 280 unchanged - 1 fixed = 280 total (was 281) +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 21s the patch passed +1 javadoc 0m 30s the patch passed +1 unit 2m 16s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 23m 29s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12817537/mapreduce6728.001.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1032caec4efb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bf6f4a3 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6609/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6609/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks for the patch, Haibo Chen.

        Comments:

        • Instead of reusing the INITIAL_DELAY, you should define a retry delay instead. You might also want to consider some kind of backoff. The most correct approach would be to define the delay in the ShuffleHandler and pass it back in the Retry-after header.
        • I don't love defining an inner exception, but it appears to be the best option. Can we call it something like TryAgainLaterException so that it's really clear what it means? Should it be static? It should probably be private.
        • In this line the whitespace is wrong:
          for(TaskAttemptID left: remaining) {
        • Is there a clever way to not duplicate the code to put back the remaining attempts? It appears in both catch clauses.
        • Please include javadoc for your ShuffleSchedulerImpl.penalize() method.
        • In the ShuffleHandler.Shuffle.channelOpen() method, instead of writing the error code there, you should probably call sendError().
        • In the TestFetcher test, watching the calls to hostFailed and copyFailed seems brittle. Maybe instead watch the ioErrs counter?
        • Please include a message in your new assert in TestShuffleHandler.
        Show
        templedf Daniel Templeton added a comment - Thanks for the patch, Haibo Chen . Comments: Instead of reusing the INITIAL_DELAY , you should define a retry delay instead. You might also want to consider some kind of backoff. The most correct approach would be to define the delay in the ShuffleHandler and pass it back in the Retry-after header. I don't love defining an inner exception, but it appears to be the best option. Can we call it something like TryAgainLaterException so that it's really clear what it means? Should it be static ? It should probably be private . In this line the whitespace is wrong: for (TaskAttemptID left: remaining) { Is there a clever way to not duplicate the code to put back the remaining attempts? It appears in both catch clauses. Please include javadoc for your ShuffleSchedulerImpl.penalize() method. In the ShuffleHandler.Shuffle.channelOpen() method, instead of writing the error code there, you should probably call sendError() . In the TestFetcher test, watching the calls to hostFailed and copyFailed seems brittle. Maybe instead watch the ioErrs counter? Please include a message in your new assert in TestShuffleHandler .
        Hide
        haibochen Haibo Chen added a comment -

        Thanks for you reviews,Daniel Templeton! I have updated the patch to incorporate most of your suggestions.

        Instead of reusing the INITIAL_DELAY, you should define a retry delay instead. You might also want to consider some kind of backoff. The most correct approach would be to define the delay in the ShuffleHandler and pass it back in the Retry-after header.

        Agreed. This is added into the new path.

        I don't love defining an inner exception, but it appears to be the best option. Can we call it something like TryAgainLaterException so that it's really clear what it means? Should it be static? It should probably be private.

        Renamed the exception and added private as you suggested, but still kept the static modifier as I don't see the association of this Exception class with an instance of Fetcher.

        Is there a clever way to not duplicate the code to put back the remaining attempts? It appears in both catch clauses.

        I don't see a clean way to get rid of the duplicate.

        In the TestFetcher test, watching the calls to hostFailed and copyFailed seems brittle. Maybe instead watch the ioErrs counter?

        Good point. The new patch now verifies failure counts.

        Show
        haibochen Haibo Chen added a comment - Thanks for you reviews, Daniel Templeton ! I have updated the patch to incorporate most of your suggestions. Instead of reusing the INITIAL_DELAY, you should define a retry delay instead. You might also want to consider some kind of backoff. The most correct approach would be to define the delay in the ShuffleHandler and pass it back in the Retry-after header. Agreed. This is added into the new path. I don't love defining an inner exception, but it appears to be the best option. Can we call it something like TryAgainLaterException so that it's really clear what it means? Should it be static? It should probably be private. Renamed the exception and added private as you suggested, but still kept the static modifier as I don't see the association of this Exception class with an instance of Fetcher. Is there a clever way to not duplicate the code to put back the remaining attempts? It appears in both catch clauses. I don't see a clean way to get rid of the duplicate. In the TestFetcher test, watching the calls to hostFailed and copyFailed seems brittle. Maybe instead watch the ioErrs counter? Good point. The new patch now verifies failure counts.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 8s Maven dependency ordering for branch
        +1 mvninstall 6m 40s trunk passed
        +1 compile 1m 35s trunk passed
        +1 checkstyle 0m 30s trunk passed
        +1 mvnsite 0m 46s trunk passed
        +1 mvneclipse 0m 26s trunk passed
        +1 findbugs 1m 10s trunk passed
        +1 javadoc 0m 34s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 47s the patch passed
        +1 compile 1m 39s the patch passed
        -1 javac 1m 39s hadoop-mapreduce-project_hadoop-mapreduce-client generated 1 new + 364 unchanged - 0 fixed = 365 total (was 364)
        -1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 277 unchanged - 3 fixed = 279 total (was 280)
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        -1 findbugs 0m 30s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
        +1 javadoc 0m 37s the patch passed
        +1 unit 2m 26s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 21s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        22m 2s



        Reason Tests
        FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
          Class org.apache.hadoop.mapred.ShuffleHandler$Shuffle$4 defines non-transient non-serializable instance field this$1 In ShuffleHandler.java:instance field this$1 In ShuffleHandler.java



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829700/mapreduce6728.002.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4817f521e28a 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 964e546
        Default Java 1.8.0_101
        findbugs v3.0.0
        javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.html
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 8s Maven dependency ordering for branch +1 mvninstall 6m 40s trunk passed +1 compile 1m 35s trunk passed +1 checkstyle 0m 30s trunk passed +1 mvnsite 0m 46s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 1m 10s trunk passed +1 javadoc 0m 34s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 47s the patch passed +1 compile 1m 39s the patch passed -1 javac 1m 39s hadoop-mapreduce-project_hadoop-mapreduce-client generated 1 new + 364 unchanged - 0 fixed = 365 total (was 364) -1 checkstyle 0m 27s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 277 unchanged - 3 fixed = 279 total (was 280) +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 30s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 0m 37s the patch passed +1 unit 2m 26s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 21s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 22m 2s Reason Tests FindBugs module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle   Class org.apache.hadoop.mapred.ShuffleHandler$Shuffle$4 defines non-transient non-serializable instance field this$1 In ShuffleHandler.java:instance field this$1 In ShuffleHandler.java Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12829700/mapreduce6728.002.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4817f521e28a 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 964e546 Default Java 1.8.0_101 findbugs v3.0.0 javac https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/diff-compile-javac-hadoop-mapreduce-project_hadoop-mapreduce-client.txt checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/artifact/patchprocess/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-shuffle.html Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6731/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Uploading a new patch to address the warnings.

        Show
        haibochen Haibo Chen added a comment - Uploading a new patch to address the warnings.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks, Haibo Chen! The patch looks great. Two tiny nits:

        1. The colon in ShuffleHandler needs a space before it:
                for (Map.Entry<String, String> header: headers.entrySet()) {
        2. It would be nice to add a comment where you send the error code to say what the header means and why you're sending it.
        Show
        templedf Daniel Templeton added a comment - Thanks, Haibo Chen ! The patch looks great. Two tiny nits: The colon in ShuffleHandler needs a space before it: for (Map.Entry< String , String > header: headers.entrySet()) { It would be nice to add a comment where you send the error code to say what the header means and why you're sending it.
        Hide
        kasha Karthik Kambatla added a comment -

        Canceling patch to address review comments.

        Show
        kasha Karthik Kambatla added a comment - Canceling patch to address review comments.
        Hide
        haibochen Haibo Chen added a comment -

        Thanks for your reviews, Daniel Templeton/ Uploading another patch to address your latest comments.

        Show
        haibochen Haibo Chen added a comment - Thanks for your reviews, Daniel Templeton / Uploading another patch to address your latest comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 48s Maven dependency ordering for branch
        +1 mvninstall 6m 58s trunk passed
        +1 compile 1m 44s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 47s trunk passed
        +1 mvneclipse 0m 32s trunk passed
        +1 findbugs 1m 13s trunk passed
        +1 javadoc 0m 34s trunk passed
        0 mvndep 0m 9s Maven dependency ordering for patch
        +1 mvninstall 0m 45s the patch passed
        +1 compile 1m 39s the patch passed
        +1 javac 1m 39s the patch passed
        -1 checkstyle 0m 28s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 278 unchanged - 3 fixed = 279 total (was 281)
        +1 mvnsite 0m 43s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 24s the patch passed
        +1 javadoc 0m 38s the patch passed
        +1 unit 2m 33s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 22s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 18s The patch does not generate ASF License warnings.
        23m 32s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831659/mapreduce6728.004.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2874102f79f0 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 31f8da2
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 48s Maven dependency ordering for branch +1 mvninstall 6m 58s trunk passed +1 compile 1m 44s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 47s trunk passed +1 mvneclipse 0m 32s trunk passed +1 findbugs 1m 13s trunk passed +1 javadoc 0m 34s trunk passed 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 1m 39s the patch passed +1 javac 1m 39s the patch passed -1 checkstyle 0m 28s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 278 unchanged - 3 fixed = 279 total (was 281) +1 mvnsite 0m 43s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 24s the patch passed +1 javadoc 0m 38s the patch passed +1 unit 2m 33s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 22s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 23m 32s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831659/mapreduce6728.004.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2874102f79f0 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 31f8da2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6749/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Sorry to string this out. I just caught two more items that should be addressed:

        1. This comment:
            /**
             * This should be kept in sync with ShuffleHandler.FETCH_RETRY_DELAY.
             */
            private static final long FETCH_RETRY_DELAY_DEFAULT = 1000L;

          either should not be a javadoc comment or should start with a sentence that is an appropriate javadoc comment.

        2. The TestShuffleHandler should test that the Retry-after header is set to a non-negative integer.
        Show
        templedf Daniel Templeton added a comment - Sorry to string this out. I just caught two more items that should be addressed: This comment: /** * This should be kept in sync with ShuffleHandler.FETCH_RETRY_DELAY. */ private static final long FETCH_RETRY_DELAY_DEFAULT = 1000L; either should not be a javadoc comment or should start with a sentence that is an appropriate javadoc comment. The TestShuffleHandler should test that the Retry-after header is set to a non-negative integer.
        Hide
        haibochen Haibo Chen added a comment -

        Adding another patch to address Daniel's latest comments.

        Show
        haibochen Haibo Chen added a comment - Adding another patch to address Daniel's latest comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 49s Maven dependency ordering for branch
        +1 mvninstall 8m 0s trunk passed
        +1 compile 1m 49s trunk passed
        +1 checkstyle 0m 31s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 1m 22s trunk passed
        +1 javadoc 0m 36s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 39s the patch passed
        +1 compile 1m 49s the patch passed
        +1 javac 1m 49s the patch passed
        -1 checkstyle 0m 29s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 278 unchanged - 3 fixed = 279 total (was 281)
        +1 mvnsite 0m 49s the patch passed
        +1 mvneclipse 0m 22s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 34s the patch passed
        +1 javadoc 0m 32s the patch passed
        +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 19s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        24m 53s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832045/mapreduce6728.005.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 77600b4adbb5 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 48b9d5f
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 49s Maven dependency ordering for branch +1 mvninstall 8m 0s trunk passed +1 compile 1m 49s trunk passed +1 checkstyle 0m 31s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 1m 22s trunk passed +1 javadoc 0m 36s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 39s the patch passed +1 compile 1m 49s the patch passed +1 javac 1m 49s the patch passed -1 checkstyle 0m 29s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 1 new + 278 unchanged - 3 fixed = 279 total (was 281) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 22s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 34s the patch passed +1 javadoc 0m 32s the patch passed +1 unit 2m 20s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 19s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 24m 53s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832045/mapreduce6728.005.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 77600b4adbb5 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 48b9d5f Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6756/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        templedf Daniel Templeton added a comment -

        Thanks, Haibo Chen. Latest patch looks good to me. +1 (non-binding)

        Show
        templedf Daniel Templeton added a comment - Thanks, Haibo Chen . Latest patch looks good to me. +1 (non-binding)
        Hide
        rkanter Robert Kanter added a comment -

        Thanks for the patch Haibo Chen and the reviews Daniel Templeton. A few minor things:

        • for (TaskAttemptID left: remaining) 

          still has wrong spacing.

        • I think it might be helpful to put the hostname in the TryAgainLaterException message.
        • Fetcher.FETCH_RETRY_DELAY_DEFAULT has a comment to point you to ShuffleHandler.FETCH_RETRY_DELAY. I think we should add a comment pointing back in case someone goes and changes ShuffleHandler.FETCH_RETRY_DELAY, they'll know to go and change Fetcher.FETCH_RETRY_DELAY_DEFAULT
        Show
        rkanter Robert Kanter added a comment - Thanks for the patch Haibo Chen and the reviews Daniel Templeton . A few minor things: for (TaskAttemptID left: remaining) still has wrong spacing. I think it might be helpful to put the hostname in the TryAgainLaterException message. Fetcher.FETCH_RETRY_DELAY_DEFAULT has a comment to point you to ShuffleHandler.FETCH_RETRY_DELAY . I think we should add a comment pointing back in case someone goes and changes ShuffleHandler.FETCH_RETRY_DELAY , they'll know to go and change Fetcher.FETCH_RETRY_DELAY_DEFAULT
        Hide
        haibochen Haibo Chen added a comment -

        Thanks for your reivews, Robert Kanter. Uploading a new patch to address the issues you have raised.

        Show
        haibochen Haibo Chen added a comment - Thanks for your reivews, Robert Kanter . Uploading a new patch to address the issues you have raised.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 12s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 10s Maven dependency ordering for branch
        +1 mvninstall 7m 53s trunk passed
        +1 compile 1m 53s trunk passed
        +1 checkstyle 0m 32s trunk passed
        +1 mvnsite 0m 52s trunk passed
        +1 mvneclipse 0m 28s trunk passed
        +1 findbugs 1m 23s trunk passed
        +1 javadoc 0m 36s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 44s the patch passed
        +1 compile 1m 54s the patch passed
        +1 javac 1m 54s the patch passed
        -1 checkstyle 0m 28s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 277 unchanged - 3 fixed = 279 total (was 280)
        +1 mvnsite 0m 42s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 23s the patch passed
        +1 javadoc 0m 30s the patch passed
        +1 unit 2m 28s hadoop-mapreduce-client-core in the patch passed.
        +1 unit 0m 17s hadoop-mapreduce-client-shuffle in the patch passed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        23m 58s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834778/mapreduce6728.006.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 6e090c3051f6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2543852
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 10s Maven dependency ordering for branch +1 mvninstall 7m 53s trunk passed +1 compile 1m 53s trunk passed +1 checkstyle 0m 32s trunk passed +1 mvnsite 0m 52s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 1m 23s trunk passed +1 javadoc 0m 36s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 1m 54s the patch passed +1 javac 1m 54s the patch passed -1 checkstyle 0m 28s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 277 unchanged - 3 fixed = 279 total (was 280) +1 mvnsite 0m 42s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 23s the patch passed +1 javadoc 0m 30s the patch passed +1 unit 2m 28s hadoop-mapreduce-client-core in the patch passed. +1 unit 0m 17s hadoop-mapreduce-client-shuffle in the patch passed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 23m 58s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834778/mapreduce6728.006.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 6e090c3051f6 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2543852 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6770/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        +1

        Show
        rkanter Robert Kanter added a comment - +1
        Hide
        rkanter Robert Kanter added a comment -

        Looks like it doesn't compile against branch-2. Can you take a look and upload a modified patch?

        [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-mapreduce-client-shuffle: Compilation failure
        [ERROR] /Users/rkanter/dev/hadoop-git/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java:[1268,17] cannot find symbol
        [ERROR] symbol:   method headers()
        [ERROR] location: variable response of type org.jboss.netty.handler.codec.http.HttpResponse
        [ERROR] -> [Help 1]
        
        Show
        rkanter Robert Kanter added a comment - Looks like it doesn't compile against branch-2. Can you take a look and upload a modified patch? [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project hadoop-mapreduce-client-shuffle: Compilation failure [ERROR] /Users/rkanter/dev/hadoop-git/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java:[1268,17] cannot find symbol [ERROR] symbol: method headers() [ERROR] location: variable response of type org.jboss.netty.handler.codec.http.HttpResponse [ERROR] -> [Help 1]
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10662 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10662/)
        MAPREDUCE-6728. Give fetchers hint when ShuffleHandler rejects a (rkanter: rev d4725bfcb2d300219d65395a78f957afbf37b201)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/Fetcher.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/task/reduce/TestFetcher.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MapHost.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/ShuffleSchedulerImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10662 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10662/ ) MAPREDUCE-6728 . Give fetchers hint when ShuffleHandler rejects a (rkanter: rev d4725bfcb2d300219d65395a78f957afbf37b201) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/main/java/org/apache/hadoop/mapred/ShuffleHandler.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/Fetcher.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/task/reduce/TestFetcher.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/MapHost.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/ShuffleSchedulerImpl.java
        Hide
        haibochen Haibo Chen added a comment -

        Uploading a patch for branch-2.8

        Show
        haibochen Haibo Chen added a comment - Uploading a patch for branch-2.8
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 40s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 31s Maven dependency ordering for branch
        +1 mvninstall 7m 5s branch-2.8 passed
        +1 compile 1m 3s branch-2.8 passed with JDK v1.8.0_101
        +1 compile 1m 17s branch-2.8 passed with JDK v1.7.0_111
        +1 checkstyle 0m 25s branch-2.8 passed
        +1 mvnsite 0m 54s branch-2.8 passed
        +1 mvneclipse 0m 31s branch-2.8 passed
        +1 findbugs 1m 37s branch-2.8 passed
        +1 javadoc 0m 35s branch-2.8 passed with JDK v1.8.0_101
        +1 javadoc 0m 39s branch-2.8 passed with JDK v1.7.0_111
        0 mvndep 0m 11s Maven dependency ordering for patch
        +1 mvninstall 0m 39s the patch passed
        +1 compile 0m 58s the patch passed with JDK v1.8.0_101
        +1 javac 0m 58s the patch passed
        +1 compile 1m 13s the patch passed with JDK v1.7.0_111
        +1 javac 1m 13s the patch passed
        -1 checkstyle 0m 23s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 147 unchanged - 2 fixed = 149 total (was 149)
        +1 mvnsite 0m 50s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 54s the patch passed
        +1 javadoc 0m 28s the patch passed with JDK v1.8.0_101
        +1 javadoc 0m 34s the patch passed with JDK v1.7.0_111
        +1 unit 2m 6s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_101.
        +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.8.0_101.
        +1 unit 2m 22s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_111.
        +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.7.0_111.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        29m 36s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835042/mapreduce6728.branch-2.8.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux a8a541e5857e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / c829102
        Default Java 1.7.0_111
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 40s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 31s Maven dependency ordering for branch +1 mvninstall 7m 5s branch-2.8 passed +1 compile 1m 3s branch-2.8 passed with JDK v1.8.0_101 +1 compile 1m 17s branch-2.8 passed with JDK v1.7.0_111 +1 checkstyle 0m 25s branch-2.8 passed +1 mvnsite 0m 54s branch-2.8 passed +1 mvneclipse 0m 31s branch-2.8 passed +1 findbugs 1m 37s branch-2.8 passed +1 javadoc 0m 35s branch-2.8 passed with JDK v1.8.0_101 +1 javadoc 0m 39s branch-2.8 passed with JDK v1.7.0_111 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 39s the patch passed +1 compile 0m 58s the patch passed with JDK v1.8.0_101 +1 javac 0m 58s the patch passed +1 compile 1m 13s the patch passed with JDK v1.7.0_111 +1 javac 1m 13s the patch passed -1 checkstyle 0m 23s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 147 unchanged - 2 fixed = 149 total (was 149) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_101 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_111 +1 unit 2m 6s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_101. +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.8.0_101. +1 unit 2m 22s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_111. +1 unit 0m 20s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 29m 36s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12835042/mapreduce6728.branch-2.8.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux a8a541e5857e 3.13.0-96-generic #143-Ubuntu SMP Mon Aug 29 20:15:20 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / c829102 Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6773/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        +1 on the 2.8 patch

        Show
        rkanter Robert Kanter added a comment - +1 on the 2.8 patch
        Hide
        rkanter Robert Kanter added a comment -

        It applies to branch-2, but not to branch-2.8; so let's just leave this as 2.9 for now then. Haibo Chen, unless you think we need this in 2.8?

        Show
        rkanter Robert Kanter added a comment - It applies to branch-2, but not to branch-2.8; so let's just leave this as 2.9 for now then. Haibo Chen , unless you think we need this in 2.8?
        Hide
        rkanter Robert Kanter added a comment -

        Committed to branch-2!

        Show
        rkanter Robert Kanter added a comment - Committed to branch-2!
        Hide
        djp Junping Du added a comment -

        Hi Robert Kanter and Haibo Chen, do we consider to backport this improvement to 2.8?

        Show
        djp Junping Du added a comment - Hi Robert Kanter and Haibo Chen , do we consider to backport this improvement to 2.8?
        Hide
        haibochen Haibo Chen added a comment -

        I'll upload a patch for branch-2.8

        Show
        haibochen Haibo Chen added a comment - I'll upload a patch for branch-2.8
        Hide
        djp Junping Du added a comment -

        Great. Thanks Haibo Chen!

        Show
        djp Junping Du added a comment - Great. Thanks Haibo Chen !
        Hide
        rkanter Robert Kanter added a comment -

        I'm reopening so that Jenkins can pick up the 2.8 patch

        Show
        rkanter Robert Kanter added a comment - I'm reopening so that Jenkins can pick up the 2.8 patch
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 21s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 7m 38s branch-2.8 passed
        +1 compile 1m 6s branch-2.8 passed with JDK v1.8.0_111
        +1 compile 1m 15s branch-2.8 passed with JDK v1.7.0_121
        +1 checkstyle 0m 23s branch-2.8 passed
        +1 mvnsite 0m 48s branch-2.8 passed
        +1 mvneclipse 0m 27s branch-2.8 passed
        +1 findbugs 1m 29s branch-2.8 passed
        +1 javadoc 0m 33s branch-2.8 passed with JDK v1.8.0_111
        +1 javadoc 0m 36s branch-2.8 passed with JDK v1.7.0_121
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 43s the patch passed
        +1 compile 1m 3s the patch passed with JDK v1.8.0_111
        +1 javac 1m 3s the patch passed
        +1 compile 1m 15s the patch passed with JDK v1.7.0_121
        +1 javac 1m 15s the patch passed
        -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148)
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 24s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 53s the patch passed
        +1 javadoc 0m 31s the patch passed with JDK v1.8.0_111
        +1 javadoc 0m 36s the patch passed with JDK v1.7.0_121
        +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_111.
        +1 unit 0m 19s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.8.0_111.
        +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_121.
        +1 unit 0m 21s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.7.0_121.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        29m 22s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5af2af1
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843498/MAPREDUCE-6728-branch-2.8.06.patch
        JIRA Issue MAPREDUCE-6728
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 11c8142d8681 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.8 / 07a221e
        Default Java 1.7.0_121
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 21s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 7m 38s branch-2.8 passed +1 compile 1m 6s branch-2.8 passed with JDK v1.8.0_111 +1 compile 1m 15s branch-2.8 passed with JDK v1.7.0_121 +1 checkstyle 0m 23s branch-2.8 passed +1 mvnsite 0m 48s branch-2.8 passed +1 mvneclipse 0m 27s branch-2.8 passed +1 findbugs 1m 29s branch-2.8 passed +1 javadoc 0m 33s branch-2.8 passed with JDK v1.8.0_111 +1 javadoc 0m 36s branch-2.8 passed with JDK v1.7.0_121 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 43s the patch passed +1 compile 1m 3s the patch passed with JDK v1.8.0_111 +1 javac 1m 3s the patch passed +1 compile 1m 15s the patch passed with JDK v1.7.0_121 +1 javac 1m 15s the patch passed -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 2 new + 146 unchanged - 2 fixed = 148 total (was 148) +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 24s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 31s the patch passed with JDK v1.8.0_111 +1 javadoc 0m 36s the patch passed with JDK v1.7.0_121 +1 unit 2m 4s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_111. +1 unit 0m 19s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.8.0_111. +1 unit 2m 21s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_121. +1 unit 0m 21s hadoop-mapreduce-client-shuffle in the patch passed with JDK v1.7.0_121. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 29m 22s Subsystem Report/Notes Docker Image:yetus/hadoop:5af2af1 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12843498/MAPREDUCE-6728-branch-2.8.06.patch JIRA Issue MAPREDUCE-6728 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 11c8142d8681 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.8 / 07a221e Default Java 1.7.0_121 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_111 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_121 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6849/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        Resolving this so it gets picked up in the 3.0.0-alpha2 release notes. Please reopen if/when you need a branch-2 precommit run.

        Show
        andrew.wang Andrew Wang added a comment - Resolving this so it gets picked up in the 3.0.0-alpha2 release notes. Please reopen if/when you need a branch-2 precommit run.

          People

          • Assignee:
            haibochen Haibo Chen
            Reporter:
            haibochen Haibo Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            14 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development