Shen Yinjie added a comment - 23/Jun/16 10:23 simple fix for review

Hadoop QA added a comment - 23/Jun/16 10:52 -1 overall Vote Subsystem Runtime Comment 0 reexec 9m 52s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 12s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 47s trunk passed +1 javadoc 0m 22s trunk passed +1 mvninstall 0m 22s the patch passed +1 compile 0m 20s the patch passed +1 javac 0m 20s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 10s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 52s the patch passed +1 javadoc 0m 18s the patch passed +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 24m 8s Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812789/MAPREDUCE-6725.patch JIRA Issue MAPREDUCE-6725 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2b2365c7bbe2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e6cb075 Default Java 1.8.0_91 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6580/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6580/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Daniel Templeton added a comment - 23/Jun/16 13:51 Thanks, Shen Yinjie ! Would you mind also adding the two missing parameters?

Shen Yinjie added a comment - 24/Jun/16 01:01 add two missing parameters

Hadoop QA added a comment - 24/Jun/16 01:25 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 29s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 48s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 17s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 5s trunk passed +1 javadoc 0m 27s trunk passed +1 mvninstall 0m 31s the patch passed +1 compile 0m 28s the patch passed +1 javac 0m 28s the patch passed +1 checkstyle 0m 18s the patch passed +1 mvnsite 0m 34s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 18s the patch passed +1 javadoc 0m 24s the patch passed -1 unit 2m 11s hadoop-mapreduce-client-core in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 17m 10s Reason Tests Failed junit tests hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:85209cc JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812969/MAPREDUCE-6725_1.patch JIRA Issue MAPREDUCE-6725 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c658fcdc0908 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b9edf6 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6583/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6583/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6583/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6583/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.

Daniel Templeton added a comment - 24/Jun/16 03:04 Works for me. +1 (non-binding)

Shen Yinjie added a comment - 24/Jun/16 09:07 Thx anyway!

Daniel Templeton added a comment - 24/Jun/16 13:50 Akira Ajisaka , got time for a quickie?

Akira Ajisaka added a comment - 24/Jun/16 15:23 LGTM, +1.

Akira Ajisaka added a comment - 24/Jun/16 15:29 Committed this to trunk, branch-2, and branch-2.8. Thanks Shen Yinjie for the contribution and thanks Daniel Templeton for the review.

Hudson added a comment - 24/Jun/16 15:35 SUCCESS: Integrated in Hadoop-trunk-Commit #10015 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10015/ ) MAPREDUCE-6725 . Javadoc for CLI#listEvents() contains no-existent param. (aajisaka: rev 0f23cd497b0baa0899c7565cd94e2f27dbc7c0ff) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/tools/CLI.java