Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.7.0, 2.8.0, 2.7.1, 2.7.2, 2.7.3
-
Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
-
Component/s: test
-
Labels:None
-
Environment:
OS: Windows Server 2012
JDK: 1.7.0_79
-
Hadoop Flags:Reviewed
-
Release Note:Backport the fix to 2.7 and 2.8
Description
TestJobListCache#testEviction often needs more than 1000 ms to finish in Windows environment. Increasing the timeout solves the issue.
Issue Links
- is part of
-
YARN-4932
[Umbrella] YARN/MR test failures on Windows
-
- Open
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Thanks Gergely Novák for the patch.
Agree that 1000 ms may not enough, given the sleep time in the worst case could reach to 900 ms.
for (int i = 0; i < 9; i++) {
values = cache.values();
if (values.size() > maxSize) {
Thread.sleep(100);
} else {
assertFalse("fileInfo1 should have been evicted",
values.contains(fileInfo1));
return;
}
}
However, 10 secs may not be necessary. Can we set to 5000 ms instead?
Sure, 5000 ms should be enough.
I ran the test 10 times on a Windows VM with these results:
1. 1199 ms
2. 2289 ms
3. 1246 ms
4. 884 ms
5. 1122 ms
6. 1061 ms
7. 1173 ms
8. 1035 ms
9. 1046 ms
10. 1201 ms
Thanks Gergely Novák for updating the patch. +1 on 002 patch, will commit it after Jenkins report.
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 13s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 6m 41s | trunk passed |
| +1 | compile | 0m 15s | trunk passed with JDK v1.8.0_77 |
| +1 | compile | 0m 18s | trunk passed with JDK v1.7.0_95 |
| +1 | checkstyle | 0m 14s | trunk passed |
| +1 | mvnsite | 0m 24s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | findbugs | 0m 32s | trunk passed |
| +1 | javadoc | 0m 13s | trunk passed with JDK v1.8.0_77 |
| +1 | javadoc | 0m 16s | trunk passed with JDK v1.7.0_95 |
| +1 | mvninstall | 0m 18s | the patch passed |
| +1 | compile | 0m 13s | the patch passed with JDK v1.8.0_77 |
| +1 | javac | 0m 13s | the patch passed |
| +1 | compile | 0m 16s | the patch passed with JDK v1.7.0_95 |
| +1 | javac | 0m 16s | the patch passed |
| +1 | checkstyle | 0m 12s | the patch passed |
| +1 | mvnsite | 0m 21s | the patch passed |
| +1 | mvneclipse | 0m 11s | the patch passed |
| +1 | whitespace | 0m 0s | Patch has no whitespace issues. |
| +1 | findbugs | 0m 43s | the patch passed |
| +1 | javadoc | 0m 10s | the patch passed with JDK v1.8.0_77 |
| +1 | javadoc | 0m 14s | the patch passed with JDK v1.7.0_95 |
| +1 | unit | 5m 32s | hadoop-mapreduce-client-hs in the patch passed with JDK v1.8.0_77. |
| +1 | unit | 6m 3s | hadoop-mapreduce-client-hs in the patch passed with JDK v1.7.0_95. |
| +1 | asflicense | 0m 21s | Patch does not generate ASF License warnings. |
| 24m 50s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:fbe3e86 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12797106/MAPREDUCE-6670.002.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux c3bf8b2551d4 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 0005816 |
| Default Java | 1.7.0_95 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_77 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 |
| findbugs | v3.0.0 |
| JDK v1.7.0_95 Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6417/testReport/ |
| modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6417/console |
| Powered by | Apache Yetus 0.2.0 http://yetus.apache.org |
This message was automatically generated.
+1. Will commit it shortly.
I have commit the patch to trunk and branch-2. Thanks Gergely Novák for delivering the patch and congratulation for the first patch contribution to Apache Hadoop!
FAILURE: Integrated in Hadoop-trunk-Commit #9567 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9567/)
MAPREDUCE-6670. TestJobListCache#testEviction sometimes fails on Windows (junping_du: rev de96d7c88a42cd54bd88ce2de63122998e967efa)
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/test/java/org/apache/hadoop/mapreduce/v2/hs/TestJobListCache.java
Junping Du, can this be put on older releases too - 2.8.x, 2.7.x etc?
Sure. I will backport it to 2.7 and 2.8.
Closing the JIRA as part of 2.7.3 release.
MAPREDUCE-6670This message was automatically generated.