Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6663

[NNBench] Refactor nnbench as a Tool implementation.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None

      Description

      Refactor NNBench as a tool to accept generic command line option, and add a regression test.

      1. HDFS-7651-001.patch
        13 kB
        Brahma Reddy Battula
      2. HDFS-7651-002.patch
        16 kB
        Brahma Reddy Battula
      3. HDFS-7651-003.patch
        23 kB
        Brahma Reddy Battula
      4. HDFS-7651-004.patch
        23 kB
        Brahma Reddy Battula
      5. MAPREDUCE-6663-005.patch
        23 kB
        Brahma Reddy Battula

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 33s trunk passed
        +1 compile 0m 19s trunk passed with JDK v1.8.0_72
        +1 compile 0m 22s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_72
        +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.8.0_72
        +1 javac 0m 17s the patch passed
        +1 compile 0m 20s the patch passed with JDK v1.7.0_95
        +1 javac 0m 20s the patch passed
        +1 checkstyle 0m 10s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 11s the patch passed
        -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 35s the patch passed
        +1 javadoc 0m 9s the patch passed with JDK v1.8.0_72
        +1 javadoc 0m 11s the patch passed with JDK v1.7.0_95
        -1 unit 105m 48s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72.
        -1 unit 104m 23s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 24s Patch generated 19 ASF License warnings.
        223m 23s



        Reason Tests
        JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapred.TestNetworkedJob
        JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:0ca8df7
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790903/HDFS-7651-001.patch
        JIRA Issue HDFS-7651
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux c8a17a2630de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 27e0681
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14685/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14685/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 33s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_72 +1 compile 0m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_72 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 23s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_72 +1 javac 0m 17s the patch passed +1 compile 0m 20s the patch passed with JDK v1.7.0_95 +1 javac 0m 20s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 11s the patch passed -1 whitespace 0m 0s The patch has 3 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_72 +1 javadoc 0m 11s the patch passed with JDK v1.7.0_95 -1 unit 105m 48s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_72. -1 unit 104m 23s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 24s Patch generated 19 ASF License warnings. 223m 23s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapred.TestNetworkedJob JDK v1.7.0_95 Failed junit tests hadoop.mapred.TestNetworkedJob Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790903/HDFS-7651-001.patch JIRA Issue HDFS-7651 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c8a17a2630de 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27e0681 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14685/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14685/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14685/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Testcase failures are unrelated.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Testcase failures are unrelated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 41s trunk passed
        +1 compile 0m 28s trunk passed with JDK v1.8.0_74
        +1 compile 0m 25s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 15s trunk passed
        +1 mvnsite 0m 29s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 29s trunk passed
        +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 26s the patch passed
        +1 compile 0m 24s the patch passed with JDK v1.8.0_74
        +1 javac 0m 24s the patch passed
        +1 compile 0m 22s the patch passed with JDK v1.7.0_95
        +1 javac 0m 22s the patch passed
        +1 checkstyle 0m 12s the patch passed
        +1 mvnsite 0m 29s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 39s the patch passed
        +1 javadoc 0m 13s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95
        -1 unit 110m 19s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74.
        -1 unit 130m 52s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 33s Patch generated 17 ASF License warnings.
        256m 43s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestUberAM
          hadoop.mapreduce.v2.TestMRJobs
          hadoop.fs.TestFileSystem
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestUberAM
          hadoop.mapreduce.v2.TestMRJobs
          hadoop.fs.TestFileSystem
        JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795396/HDFS-7651-002.patch
        JIRA Issue HDFS-7651
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 44c360f99673 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 2c268cc
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14939/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14939/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 41s trunk passed +1 compile 0m 28s trunk passed with JDK v1.8.0_74 +1 compile 0m 25s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 29s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 26s the patch passed +1 compile 0m 24s the patch passed with JDK v1.8.0_74 +1 javac 0m 24s the patch passed +1 compile 0m 22s the patch passed with JDK v1.7.0_95 +1 javac 0m 22s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 39s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 -1 unit 110m 19s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74. -1 unit 130m 52s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 33s Patch generated 17 ASF License warnings. 256m 43s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestUberAM   hadoop.mapreduce.v2.TestMRJobs   hadoop.fs.TestFileSystem JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestUberAM   hadoop.mapreduce.v2.TestMRJobs   hadoop.fs.TestFileSystem JDK v1.7.0_95 Timed out junit tests org.apache.hadoop.mapreduce.lib.jobcontrol.TestMapReduceJobControl Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795396/HDFS-7651-002.patch JIRA Issue HDFS-7651 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 44c360f99673 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2c268cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14939/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14939/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14939/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Refactor looks good. +1
        Thanks Brahma Reddy Battula.
        Akira Ajisaka, Do you want to take a look?

        Show
        vinayrpet Vinayakumar B added a comment - Refactor looks good. +1 Thanks Brahma Reddy Battula . Akira Ajisaka , Do you want to take a look?
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Brahma for the refactoring, and thanks Vinayakumar for pinging me. I'm thinking we can refactor NNBench.java more.

                writer = SequenceFile.createWriter(tempFS, getConf(), filePath, Text.class,
                        LongWritable.class, CompressionType.NONE);
        

        1. createWriter(FileSystem, Configuration, Path, Class, Class, CompressionType) is deperecated. Would you use createWriter(Configuration, Writer.Option...) instead?

            PrintStream res = new PrintStream(
                new FileOutputStream(new File(DEFAULT_RES_FILE_NAME), true));
            try {
        

        2. Would you use try-with-resources statement?

              for (int i = 0; i < resultLines.length; i++) {
                LOG.info(resultLines[i]);
                res.println(resultLines[i]);
              }
        

        3. foreach statement can be used.

              throw new HadoopIllegalArgumentException(
                  "\"Error: Unknown operation: \" + operation");
        

        4. I'm thinking we don't need to escape ".
        5. Would you add a regression test for NNBench.java? I don't want to cause a bug such as MAPREDUCE-6656. I'd like to test the following 2 cases.

        • create_write -> open_read -> delete
        • create_write -> rename
        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Brahma for the refactoring, and thanks Vinayakumar for pinging me. I'm thinking we can refactor NNBench.java more. writer = SequenceFile.createWriter(tempFS, getConf(), filePath, Text.class, LongWritable.class, CompressionType.NONE); 1. createWriter(FileSystem, Configuration, Path, Class, Class, CompressionType) is deperecated. Would you use createWriter(Configuration, Writer.Option...) instead? PrintStream res = new PrintStream( new FileOutputStream( new File(DEFAULT_RES_FILE_NAME), true )); try { 2. Would you use try-with-resources statement? for ( int i = 0; i < resultLines.length; i++) { LOG.info(resultLines[i]); res.println(resultLines[i]); } 3. foreach statement can be used. throw new HadoopIllegalArgumentException( "\" Error: Unknown operation: \ " + operation" ); 4. I'm thinking we don't need to escape " . 5. Would you add a regression test for NNBench.java? I don't want to cause a bug such as MAPREDUCE-6656 . I'd like to test the following 2 cases. create_write -> open_read -> delete create_write -> rename
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Updated the patch as per comments.

        Fixed some issues as well, which were preventing from using NNBench in Tests.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Updated the patch as per comments. Fixed some issues as well, which were preventing from using NNBench in Tests.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 43s trunk passed
        +1 compile 0m 23s trunk passed with JDK v1.8.0_74
        +1 compile 0m 23s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 28s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 24s the patch passed
        +1 compile 0m 20s the patch passed with JDK v1.8.0_74
        +1 javac 1m 51s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 20s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74.
        +1 compile 0m 21s the patch passed with JDK v1.7.0_95
        +1 javac 2m 12s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 21s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95.
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 26s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
        -1 unit 98m 26s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74.
        -1 unit 103m 11s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 25s Patch generated 17 ASF License warnings.
        215m 29s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795621/HDFS-7651-003.patch
        JIRA Issue HDFS-7651
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 863a9c764854 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 90fcb16
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14958/testReport/
        asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14958/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 43s trunk passed +1 compile 0m 23s trunk passed with JDK v1.8.0_74 +1 compile 0m 23s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 24s the patch passed +1 compile 0m 20s the patch passed with JDK v1.8.0_74 +1 javac 1m 51s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 20s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74. +1 compile 0m 21s the patch passed with JDK v1.7.0_95 +1 javac 2m 12s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 21s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95. +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 26s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 -1 unit 98m 26s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74. -1 unit 103m 11s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 25s Patch generated 17 ASF License warnings. 215m 29s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795621/HDFS-7651-003.patch JIRA Issue HDFS-7651 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 863a9c764854 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 90fcb16 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14958/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/14958/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14958/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Patch generated 17 ASF License warnings.

        Only one is related to this jira, same I fixed and uploaded the patch..Rest all covered in MAPREDUCE-6662.

        Test failures are unrelated..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Patch generated 17 ASF License warnings. Only one is related to this jira, same I fixed and uploaded the patch..Rest all covered in MAPREDUCE-6662 . Test failures are unrelated..
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 52s trunk passed
        +1 compile 0m 19s trunk passed with JDK v1.8.0_74
        +1 compile 0m 23s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 13s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 0m 26s trunk passed
        +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 23s the patch passed
        +1 compile 0m 18s the patch passed with JDK v1.8.0_74
        +1 javac 1m 48s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 18s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74.
        +1 compile 0m 20s the patch passed with JDK v1.7.0_95
        +1 javac 2m 8s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 20s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95.
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 25s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 38s the patch passed
        +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
        -1 unit 96m 40s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74.
        -1 unit 102m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 29s Patch generated 1 ASF License warnings.
        213m 3s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM
          hadoop.mapred.TestMRCJCFileOutputCommitter
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM
          hadoop.mapred.TestMRCJCFileOutputCommitter



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795753/HDFS-7651-004.patch
        JIRA Issue MAPREDUCE-6663
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux e1637905ba89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 1f004b3
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 52s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_74 +1 compile 0m 23s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 26s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 23s the patch passed +1 compile 0m 18s the patch passed with JDK v1.8.0_74 +1 javac 1m 48s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 18s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74. +1 compile 0m 20s the patch passed with JDK v1.7.0_95 +1 javac 2m 8s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 20s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95. +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 38s the patch passed +1 javadoc 0m 10s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 -1 unit 96m 40s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74. -1 unit 102m 29s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 29s Patch generated 1 ASF License warnings. 213m 3s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM   hadoop.mapred.TestMRCJCFileOutputCommitter JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM   hadoop.mapred.TestMRCJCFileOutputCommitter Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795753/HDFS-7651-004.patch JIRA Issue MAPREDUCE-6663 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e1637905ba89 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1f004b3 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6408/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Patch generated 1 ASF License warnings

        unrelated .. and it is tracked in HDFS-10221.

        Test failures are unrelated.. Kindly Review.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Patch generated 1 ASF License warnings unrelated .. and it is tracked in HDFS-10221 . Test failures are unrelated.. Kindly Review.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Thanks Brahma for updating the patch!

        +      throw new HadoopIllegalArgumentException(
        +          "Error: Block Size in bytes must be a multiple of \" +\n"
        +              + "              \"bytes per checksum:");
        

        1. Would you remove unnecessarily whitespaces and \n in the error message?
        2. Would you remove trailing whitespace?

        Show
        ajisakaa Akira Ajisaka added a comment - Thanks Brahma for updating the patch! + throw new HadoopIllegalArgumentException( + "Error: Block Size in bytes must be a multiple of \" +\n" + + " \" bytes per checksum:"); 1. Would you remove unnecessarily whitespaces and \n in the error message? 2. Would you remove trailing whitespace?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploaded the patch to address above comments.. thanks

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploaded the patch to address above comments.. thanks
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
        +1 mvninstall 6m 43s trunk passed
        +1 compile 0m 19s trunk passed with JDK v1.8.0_74
        +1 compile 0m 22s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 14s trunk passed
        +1 mvnsite 0m 28s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 28s trunk passed
        +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74
        +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 22s the patch passed
        +1 compile 0m 17s the patch passed with JDK v1.8.0_74
        +1 javac 1m 46s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 17s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74.
        +1 compile 0m 19s the patch passed with JDK v1.7.0_95
        +1 javac 2m 6s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189)
        +1 javac 0m 19s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95.
        +1 checkstyle 0m 11s the patch passed
        +1 mvnsite 0m 24s the patch passed
        +1 mvneclipse 0m 12s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 findbugs 0m 35s the patch passed
        +1 javadoc 0m 9s the patch passed with JDK v1.8.0_74
        +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95
        -1 unit 104m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74.
        -1 unit 106m 3s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95.
        -1 asflicense 0m 27s Patch generated 1 ASF License warnings.
        223m 48s



        Reason Tests
        JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM
          hadoop.mapred.TestMRCJCFileOutputCommitter
        JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapreduce.v2.TestUberAM
          hadoop.mapred.TestMRCJCFileOutputCommitter



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:fbe3e86
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795814/MAPREDUCE-6663-005.patch
        JIRA Issue MAPREDUCE-6663
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 549d5fbd61fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 0050fa5
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 6m 43s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_74 +1 compile 0m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 28s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 22s the patch passed +1 compile 0m 17s the patch passed with JDK v1.8.0_74 +1 javac 1m 46s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74 with JDK v1.8.0_74 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 17s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.8.0_74. +1 compile 0m 19s the patch passed with JDK v1.7.0_95 +1 javac 2m 6s hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 188 unchanged - 1 fixed = 188 total (was 189) +1 javac 0m 19s hadoop-mapreduce-client-jobclient in the patch passed with JDK v1.7.0_95. +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 24s the patch passed +1 mvneclipse 0m 12s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 findbugs 0m 35s the patch passed +1 javadoc 0m 9s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 -1 unit 104m 9s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.8.0_74. -1 unit 106m 3s hadoop-mapreduce-client-jobclient in the patch failed with JDK v1.7.0_95. -1 asflicense 0m 27s Patch generated 1 ASF License warnings. 223m 48s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM   hadoop.mapred.TestMRCJCFileOutputCommitter JDK v1.7.0_95 Failed junit tests hadoop.mapreduce.v2.TestMRJobs   hadoop.mapreduce.v2.TestUberAM   hadoop.mapred.TestMRCJCFileOutputCommitter Subsystem Report/Notes Docker Image:yetus/hadoop:fbe3e86 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12795814/MAPREDUCE-6663-005.patch JIRA Issue MAPREDUCE-6663 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 549d5fbd61fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0050fa5 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6411/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, committing this.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula for the contribution and thanks Vinayakumar B for the review!

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.8. Thanks Brahma Reddy Battula for the contribution and thanks Vinayakumar B for the review!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #9525 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9525/)
        MAPREDUCE-6663. [NNBench] Refactor nnbench as a Tool implementation. (aajisaka: rev 690d8a368d3e967495eafea27659b6124989c89e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/hdfs/TestNNBench.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/hdfs/NNBench.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9525 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9525/ ) MAPREDUCE-6663 . [NNBench] Refactor nnbench as a Tool implementation. (aajisaka: rev 690d8a368d3e967495eafea27659b6124989c89e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/hdfs/TestNNBench.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/hdfs/NNBench.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks for review and commit.and thanks Vinayakumar B for additional review..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks for review and commit.and thanks Vinayakumar B for additional review..

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development