Akira Ajisaka added a comment - 02/Mar/16 07:03 The test creates directories which does not start with target/test-dir. private final static String MEAN_OUTPUT = "build/data/mean_output" ; private final static String MEDIAN_OUTPUT = "build/data/median_output" ; private final static String STDDEV_OUTPUT = "build/data/stddev_output" ; The code should be replaced by private final static String BASEDIR = System .getProperty( "test.build.data" , "target/test-dir" )); private final static String MEAN_OUTPUT = BASEDIR + "/mean_output" ; (snip) In addition, we should delete these directories by @AfterClass .

Hadoop QA added a comment - 10/Mar/16 21:57 -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 47s trunk passed +1 compile 0m 15s trunk passed with JDK v1.8.0_74 +1 compile 0m 15s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 20s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 14s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 17s the patch passed +1 compile 0m 11s the patch passed with JDK v1.8.0_74 +1 javac 0m 11s the patch passed +1 compile 0m 14s the patch passed with JDK v1.7.0_95 +1 javac 0m 14s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 45s the patch passed +1 javadoc 0m 12s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 13s the patch passed with JDK v1.7.0_95 -1 unit 0m 24s hadoop-mapreduce-examples in the patch failed with JDK v1.8.0_74. -1 unit 0m 28s hadoop-mapreduce-examples in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 16s Patch does not generate ASF License warnings. 13m 51s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.examples.TestWordStats JDK v1.7.0_95 Failed junit tests hadoop.examples.TestWordStats Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792146/MAPREDUCE-6645.1.patch JIRA Issue MAPREDUCE-6645 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f22c279f8f6f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bd49354 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-examples-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6375/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

Hadoop QA added a comment - 11/Mar/16 03:23 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 51s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_74 +1 compile 0m 16s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 35s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 17s the patch passed +1 compile 0m 12s the patch passed with JDK v1.8.0_74 +1 javac 0m 12s the patch passed +1 compile 0m 13s the patch passed with JDK v1.7.0_95 +1 javac 0m 13s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 44s the patch passed +1 javadoc 0m 11s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 12s the patch passed with JDK v1.7.0_95 +1 unit 0m 28s hadoop-mapreduce-examples in the patch passed with JDK v1.8.0_74. +1 unit 0m 32s hadoop-mapreduce-examples in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 17s Patch does not generate ASF License warnings. 14m 5s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792609/MAPREDUCE-6645.2.patch JIRA Issue MAPREDUCE-6645 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux e26e5741af2a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e01c6ea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6377/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6377/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

Akira Ajisaka added a comment - 16/Mar/16 18:14 Hi Gabor Liptak , thank you for creating patches. v2 patch mostly looks good to me. Minor nit: Would you render the following line within 80 characters? private final static String BASEDIR = System .getProperty( "test.build.data" , "target/test-dir" ); I'm +1 if that is addressed.

Hadoop QA added a comment - 17/Mar/16 02:54 +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 19s trunk passed +1 compile 0m 20s trunk passed with JDK v1.8.0_74 +1 compile 0m 18s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 26s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 40s trunk passed +1 javadoc 0m 23s trunk passed with JDK v1.8.0_74 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 20s the patch passed +1 compile 0m 22s the patch passed with JDK v1.8.0_74 +1 javac 0m 22s the patch passed +1 compile 0m 17s the patch passed with JDK v1.7.0_95 +1 javac 0m 17s the patch passed +1 checkstyle 0m 14s the patch passed +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 55s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_74 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_95 +1 unit 0m 37s hadoop-mapreduce-examples in the patch passed with JDK v1.8.0_74. +1 unit 0m 39s hadoop-mapreduce-examples in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 17m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12793857/MAPREDUCE-6645.3.patch JIRA Issue MAPREDUCE-6645 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c9be0c30df59 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 02a250d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6381/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-examples U: hadoop-mapreduce-project/hadoop-mapreduce-examples Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6381/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.

Akira Ajisaka added a comment - 17/Mar/16 09:08 +1, LGTM.

Akira Ajisaka added a comment - 17/Mar/16 09:14 Committed this to branch-2.7 and above. Thanks Gabor Liptak for the contribution!

Hudson added a comment - 17/Mar/16 11:26 FAILURE: Integrated in Hadoop-trunk-Commit #9471 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9471/ ) MAPREDUCE-6645 . TestWordStats outputs logs under directories other than (aajisaka: rev 80fa70c4e15f16b411cb3691df546499c6a19d4c) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/test/java/org/apache/hadoop/examples/TestWordStats.java

Vinod Kumar Vavilapalli added a comment - 25/Aug/16 22:55 Closing the JIRA as part of 2.7.3 release.