Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-alpha1, 2.8.2
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Running org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt
      Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 24.917 sec <<< FAILURE! - in org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt
      testMRAppHistoryForTAFailedInAssigned(org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt)  Time elapsed: 12.732 sec  <<< FAILURE!
      java.lang.AssertionError: No Ta Started JH Event
              at org.junit.Assert.fail(Assert.java:88)
              at org.junit.Assert.assertTrue(Assert.java:41)
              at org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt.testTaskAttemptAssignedKilledHistory(TestTaskAttempt.java:388)
              at org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt.testMRAppHistoryForTAFailedInAssigned(TestTaskAttempt.java:177)
      
      1. org.apache.hadoop.mapreduce.v2.app.job.impl.TestTaskAttempt-output.txt
        13.48 MB
        Tsuyoshi Ozawa
      2. mapreduce6641.001.patch
        2 kB
        Haibo Chen
      3. mapreduce6641.002.patch
        1 kB
        Haibo Chen
      4. MAPREDUCE-6641-branch-2.002.patch
        2 kB
        Jason Lowe

        Activity

        Hide
        jlowe Jason Lowe added a comment -

        Thanks Daryn for the review! And thanks to Haibo for the original contribution. I committed this to branch-2, branch-2.8, and branch-2.8.2.

        Show
        jlowe Jason Lowe added a comment - Thanks Daryn for the review! And thanks to Haibo for the original contribution. I committed this to branch-2, branch-2.8, and branch-2.8.2.
        Hide
        daryn Daryn Sharp added a comment -

        +1 Thanks for fixing test failures.

        Show
        daryn Daryn Sharp added a comment - +1 Thanks for fixing test failures.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 19m 38s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              branch-2 Compile Tests
        +1 mvninstall 13m 33s branch-2 passed
        +1 compile 0m 44s branch-2 passed with JDK v1.8.0_144
        +1 compile 0m 36s branch-2 passed with JDK v1.7.0_151
        +1 checkstyle 0m 28s branch-2 passed
        +1 mvnsite 0m 44s branch-2 passed
        +1 findbugs 1m 11s branch-2 passed
        +1 javadoc 0m 32s branch-2 passed with JDK v1.8.0_144
        +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_151
              Patch Compile Tests
        +1 mvninstall 0m 30s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.8.0_144
        +1 javac 0m 28s the patch passed
        +1 compile 0m 28s the patch passed with JDK v1.7.0_151
        +1 javac 0m 28s the patch passed
        -1 checkstyle 0m 18s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 2 new + 64 unchanged - 2 fixed = 66 total (was 66)
        +1 mvnsite 0m 32s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 12s the patch passed
        +1 javadoc 0m 19s the patch passed with JDK v1.8.0_144
        +1 javadoc 0m 18s the patch passed with JDK v1.7.0_151
              Other Tests
        -1 unit 40m 4s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_151.
        +1 asflicense 0m 35s The patch does not generate ASF License warnings.
        94m 28s



        Reason Tests
        JDK v1.8.0_144 Failed junit tests hadoop.mapreduce.v2.app.TestRuntimeEstimators
        JDK v1.7.0_151 Timed out junit tests org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup
          org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:5e40efe
        JIRA Issue MAPREDUCE-6641
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884262/MAPREDUCE-6641-branch-2.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 53b0a4d8763a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2 / c930aa3
        Default Java 1.7.0_151
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_151.txt
        JDK v1.7.0_151 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/console
        Powered by Apache Yetus 0.5.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 19m 38s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       branch-2 Compile Tests +1 mvninstall 13m 33s branch-2 passed +1 compile 0m 44s branch-2 passed with JDK v1.8.0_144 +1 compile 0m 36s branch-2 passed with JDK v1.7.0_151 +1 checkstyle 0m 28s branch-2 passed +1 mvnsite 0m 44s branch-2 passed +1 findbugs 1m 11s branch-2 passed +1 javadoc 0m 32s branch-2 passed with JDK v1.8.0_144 +1 javadoc 0m 26s branch-2 passed with JDK v1.7.0_151       Patch Compile Tests +1 mvninstall 0m 30s the patch passed +1 compile 0m 28s the patch passed with JDK v1.8.0_144 +1 javac 0m 28s the patch passed +1 compile 0m 28s the patch passed with JDK v1.7.0_151 +1 javac 0m 28s the patch passed -1 checkstyle 0m 18s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app: The patch generated 2 new + 64 unchanged - 2 fixed = 66 total (was 66) +1 mvnsite 0m 32s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 12s the patch passed +1 javadoc 0m 19s the patch passed with JDK v1.8.0_144 +1 javadoc 0m 18s the patch passed with JDK v1.7.0_151       Other Tests -1 unit 40m 4s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_151. +1 asflicense 0m 35s The patch does not generate ASF License warnings. 94m 28s Reason Tests JDK v1.8.0_144 Failed junit tests hadoop.mapreduce.v2.app.TestRuntimeEstimators JDK v1.7.0_151 Timed out junit tests org.apache.hadoop.mapreduce.v2.app.TestStagingCleanup   org.apache.hadoop.mapreduce.v2.app.TestJobEndNotifier Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue MAPREDUCE-6641 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12884262/MAPREDUCE-6641-branch-2.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 53b0a4d8763a 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / c930aa3 Default Java 1.7.0_151 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_144 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_151 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_151.txt JDK v1.7.0_151 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7104/console Powered by Apache Yetus 0.5.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jlowe Jason Lowe added a comment -

        Seeing this fail the same way in 2.8 builds as well. Unfortunately since the fix uses lambdas I can't just cherry-pick the fix down to other branches. Reopening so Jenkins can comment on a branch-2 version of the patch.

        Show
        jlowe Jason Lowe added a comment - Seeing this fail the same way in 2.8 builds as well. Unfortunately since the fix uses lambdas I can't just cherry-pick the fix down to other branches. Reopening so Jenkins can comment on a branch-2 version of the patch.
        Hide
        haibochen Haibo Chen added a comment -

        Akira Ajisaka, Thanks very much for reviewing and committing it!

        Show
        haibochen Haibo Chen added a comment - Akira Ajisaka , Thanks very much for reviewing and committing it!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10003 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10003/)
        MAPREDUCE-6641. TestTaskAttempt fails in trunk. Contributed by Haibo (aajisaka: rev 69c21d2db099b3a4bb612fe2876fb448471829b3)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10003 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10003/ ) MAPREDUCE-6641 . TestTaskAttempt fails in trunk. Contributed by Haibo (aajisaka: rev 69c21d2db099b3a4bb612fe2876fb448471829b3) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/job/impl/TestTaskAttempt.java
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk. Thanks Haibo Chen for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Haibo Chen for the contribution.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1, committing this. The test failures are unrelated to the patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1, committing this. The test failures are unrelated to the patch.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Copied from https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/jiracommentfile

        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 26s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 40s trunk passed
        +1 compile 0m 24s trunk passed
        +1 checkstyle 0m 18s trunk passed
        +1 mvnsite 0m 32s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 0m 42s trunk passed
        +1 javadoc 0m 16s trunk passed
        +1 mvninstall 0m 24s the patch passed
        +1 compile 0m 21s the patch passed
        +1 javac 0m 21s the patch passed
        +1 checkstyle 0m 15s the patch passed
        +1 mvnsite 0m 27s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 0m 48s the patch passed
        +1 javadoc 0m 12s the patch passed
        -1 unit 9m 16s hadoop-mapreduce-client-app in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        23m 25s



        Reason Tests
        Failed junit tests hadoop.mapreduce.v2.app.TestKill
        Timed out junit tests org.apache.hadoop.mapreduce.v2.app.TestFail



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:e2f6409
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812544/mapreduce6641.002.patch
        JIRA Issue MAPREDUCE-6641
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3278c33a6a1f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 4ee3543
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        ajisakaa Akira Ajisaka added a comment - Copied from https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/jiracommentfile -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 26s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 0m 24s trunk passed +1 checkstyle 0m 18s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 0m 42s trunk passed +1 javadoc 0m 16s trunk passed +1 mvninstall 0m 24s the patch passed +1 compile 0m 21s the patch passed +1 javac 0m 21s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvnsite 0m 27s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 0m 48s the patch passed +1 javadoc 0m 12s the patch passed -1 unit 9m 16s hadoop-mapreduce-client-app in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 23m 25s Reason Tests Failed junit tests hadoop.mapreduce.v2.app.TestKill Timed out junit tests org.apache.hadoop.mapreduce.v2.app.TestFail Subsystem Report/Notes Docker Image:yetus/hadoop:e2f6409 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12812544/mapreduce6641.002.patch JIRA Issue MAPREDUCE-6641 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3278c33a6a1f 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4ee3543 Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6573/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        haibochen Haibo Chen added a comment -

        Haha, Thanks very much for your review Akira Ajisaka. Will update the patch shortly

        Show
        haibochen Haibo Chen added a comment - Haha, Thanks very much for your review Akira Ajisaka . Will update the patch shortly
        Hide
        ajisakaa Akira Ajisaka added a comment -

        The analysis makes sense to me.

            final int checkIntervalMillis = 100;
            final int waitForMillis = 800;
            waitFor(() -> app.getTaStartJHEvent(), checkIntervalMillis, waitForMillis);
            waitFor(() -> app.getTaKilledJHEvent(), checkIntervalMillis, waitForMillis);
        

        The following would be better for me.

            waitFor(app::getTaStartJHEvent, 100, 800);
            waitFor(app::getTaKilledJHEvent, 100, 800);
        

        AFAIK, this is the first lambda patch in Apache Hadoop! Thanks Haibo Chen.

        Show
        ajisakaa Akira Ajisaka added a comment - The analysis makes sense to me. final int checkIntervalMillis = 100; final int waitForMillis = 800; waitFor(() -> app.getTaStartJHEvent(), checkIntervalMillis, waitForMillis); waitFor(() -> app.getTaKilledJHEvent(), checkIntervalMillis, waitForMillis); The following would be better for me. waitFor(app::getTaStartJHEvent, 100, 800); waitFor(app::getTaKilledJHEvent, 100, 800); AFAIK, this is the first lambda patch in Apache Hadoop! Thanks Haibo Chen .
        Hide
        haibochen Haibo Chen added a comment -

        The patch adds a wait loop for the expected JH events

        Show
        haibochen Haibo Chen added a comment - The patch adds a wait loop for the expected JH events
        Hide
        haibochen Haibo Chen added a comment -

        Looks like a timing issue. A TaskAttempt, before it goes into Killed State, puts a TA Started and a TA Killed JH event onto the event queue. The dispatcher processes the event asynchronously, so the fact that TaskAttempt is in kill state does not guarantee "TA Started JH Event" is processed.

        Show
        haibochen Haibo Chen added a comment - Looks like a timing issue. A TaskAttempt, before it goes into Killed State, puts a TA Started and a TA Killed JH event onto the event queue. The dispatcher processes the event asynchronously, so the fact that TaskAttempt is in kill state does not guarantee "TA Started JH Event" is processed.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Attaching a log.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Attaching a log.

          People

          • Assignee:
            haibochen Haibo Chen
            Reporter:
            ozawa Tsuyoshi Ozawa
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development