Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 2.9.0, 3.0.0-alpha2
-
Component/s: applicationmaster
-
Labels:None
-
Hadoop Flags:Reviewed
Description
The new YarnClientUtil.getRmPrincipal() method can replace most of the Master.getMasterAddress() method and should to reduce redundancy and improve servicability.
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
 +1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 18s | Docker mode activated. |
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. |
| +1 | mvninstall | 7m 2s | trunk passed |
| +1 | compile | 0m 24s | trunk passed |
| +1 | checkstyle | 0m 16s | trunk passed |
| +1 | mvnsite | 0m 29s | trunk passed |
| +1 | mvneclipse | 0m 13s | trunk passed |
| +1 | findbugs | 0m 49s | trunk passed |
| +1 | javadoc | 0m 22s | trunk passed |
| +1 | mvninstall | 0m 26s | the patch passed |
| +1 | compile | 0m 26s | the patch passed |
| +1 | javac | 0m 26s | the patch passed |
| +1 | checkstyle | 0m 16s | hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core: The patch generated 0 new + 5 unchanged - 6 fixed = 5 total (was 11) |
| +1 | mvnsite | 0m 31s | the patch passed |
| +1 | mvneclipse | 0m 12s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | xml | 0m 1s | The patch has no ill-formed XML file. |
| +1 | findbugs | 1m 5s | the patch passed |
| +1 | javadoc | 0m 23s | the patch passed |
| +1 | unit | 2m 22s | hadoop-mapreduce-client-core in the patch passed. |
| +1 | asflicense | 0m 17s | The patch does not generate ASF License warnings. |
| 16m 33s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:9560f25 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12825919/MAPREDUCE-6632.001.patch |
| JIRA Issue | |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle |
| uname | Linux 34ef534dc6b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / c258171 |
| Default Java | 1.8.0_101 |
| findbugs | v3.0.0 |
| Test Results | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6701/testReport/ |
| modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core |
| Console output | https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6701/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
+1
Thanks Daniel Templeton. Committed to trunk and branch-2!
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10475 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10475/)
MAPREDUCE-6632. Master.getMasterAddress() should be updated to use (rkanter: rev 4fc632ae19a1d6b0ec09cc7ead789a3cab1c2f1c)
- (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestMaster.java
- (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
- (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Master.java
This patch adds a dependency from hadoop-mapreduce-client-core on hadoop-yarn-client, but it removes a decent chunk of duplicated code.