Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6557

Some tests in mapreduce-client-app are writing outside of target

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is a staging directory appearing. It should not.

      1. MAPREDUCE-6557.04.patch
        3 kB
        Akira Ajisaka
      2. MAPREDUCE-6557.004.patch
        3 kB
        Junping Du
      3. MAPREDUCE-6557.00.patch
        2 kB
        Akira Ajisaka
      4. MAPREDUCE-6555.03.patch
        3 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Was doing an audit of 2.8 commits. Found that the commit message missed including the JIRA number. Here's the commit for posterity, it is already in trunk, branch-2 and branch-2.8..

          commit 15d577bfbb3f18fc95251d22378b53aa4210115f
          Author: Junping Du <junping_du@apache.org>
          Date:   Wed Nov 25 09:15:26 2015 -0800
          
              Tests in mapreduce-client-app are writing outside of target. Contributed by Akira AJISAKA.
          
          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Was doing an audit of 2.8 commits. Found that the commit message missed including the JIRA number. Here's the commit for posterity, it is already in trunk, branch-2 and branch-2.8.. commit 15d577bfbb3f18fc95251d22378b53aa4210115f Author: Junping Du <junping_du@apache.org> Date: Wed Nov 25 09:15:26 2015 -0800 Tests in mapreduce-client-app are writing outside of target. Contributed by Akira AJISAKA.
          Hide
          djp Junping Du added a comment -

          Sure. Thanks for reminding here, Allen Wittenauer!

          Show
          djp Junping Du added a comment - Sure. Thanks for reminding here, Allen Wittenauer !
          Hide
          aw Allen Wittenauer added a comment -

          I have commit 04 patch to trunk and branch-2.

          I've removed the 3.0.0 fix version. Please don't add 3.0.0 when you commit to an earlier branch. It messes up the autogenerated reports and it goes against the committer guidelines. Thanks.

          Show
          aw Allen Wittenauer added a comment - I have commit 04 patch to trunk and branch-2. I've removed the 3.0.0 fix version. Please don't add 3.0.0 when you commit to an earlier branch. It messes up the autogenerated reports and it goes against the committer guidelines. Thanks.
          Hide
          djp Junping Du added a comment -

          I have commit 04 patch to trunk and branch-2. Thanks Akira Ajisaka for the contribution!

          Show
          djp Junping Du added a comment - I have commit 04 patch to trunk and branch-2. Thanks Akira Ajisaka for the contribution!
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 25s trunk passed
          +1 compile 0m 19s trunk passed with JDK v1.8.0_66
          +1 compile 0m 22s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 27s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 43s trunk passed
          +1 javadoc 0m 14s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 25s the patch passed
          +1 compile 0m 19s the patch passed with JDK v1.8.0_66
          +1 javac 0m 19s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.7.0_85
          +1 javac 0m 23s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 28s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 51s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 17s the patch passed with JDK v1.7.0_85
          +1 unit 9m 6s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66.
          +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 22s Patch does not generate ASF License warnings.
          33m 46s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774375/MAPREDUCE-6557.04.patch
          JIRA Issue MAPREDUCE-6557
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 22d49ce0e7ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bab03f3
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6197/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6197/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 25s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 22s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 43s trunk passed +1 javadoc 0m 14s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 18s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 25s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_66 +1 javac 0m 19s the patch passed +1 compile 0m 23s the patch passed with JDK v1.7.0_85 +1 javac 0m 23s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 28s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 51s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_85 +1 unit 9m 6s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_66. +1 unit 9m 40s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 22s Patch does not generate ASF License warnings. 33m 46s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774375/MAPREDUCE-6557.04.patch JIRA Issue MAPREDUCE-6557 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 22d49ce0e7ae 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bab03f3 findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6197/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6197/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Sounds like we are updating patch at the same time.
          Anyway, 04 patch is exactly the same as 004 patch. I will commit it after Jenkins report positive.

          Show
          djp Junping Du added a comment - Sounds like we are updating patch at the same time. Anyway, 04 patch is exactly the same as 004 patch. I will commit it after Jenkins report positive.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Can you check if it sounds good? If so, I will commit it shortly.

          +1 for 004 patch. Thanks Junping Du.

          Show
          ajisakaa Akira Ajisaka added a comment - Can you check if it sounds good? If so, I will commit it shortly. +1 for 004 patch. Thanks Junping Du .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Junping Du for the comment. Updated the patch.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Junping Du for the comment. Updated the patch.
          Hide
          djp Junping Du added a comment -

          Hi Akira Ajisaka, I mark cleanup method as static in 004 patch, so tests get run successfully locally. Can you check if it sounds good? If so, I will commit it shortly.

          Show
          djp Junping Du added a comment - Hi Akira Ajisaka , I mark cleanup method as static in 004 patch, so tests get run successfully locally. Can you check if it sounds good? If so, I will commit it shortly.
          Hide
          djp Junping Du added a comment -

          Oh. Forget to mention, test will run failed because code below:

          +  @AfterClass
          +  public void cleanup() throws IOException {
          +    localFS.delete(testDir, true);
          +  }
          

          cleanup() should be marked as static due to requirement for AfterClass tag.

          Show
          djp Junping Du added a comment - Oh. Forget to mention, test will run failed because code below: + @AfterClass + public void cleanup() throws IOException { + localFS.delete(testDir, true ); + } cleanup() should be marked as static due to requirement for AfterClass tag.
          Hide
          djp Junping Du added a comment -

          The failed tests are unrelated and are tracked in MAPREDUCE-6555. +1. committing it in.

          Show
          djp Junping Du added a comment - The failed tests are unrelated and are tracked in MAPREDUCE-6555 . +1. committing it in.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 31s trunk passed
          +1 compile 0m 19s trunk passed with JDK v1.8.0_66
          +1 compile 0m 23s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 11s trunk passed
          +1 mvnsite 0m 27s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 43s trunk passed
          +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 17s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 19s the patch passed with JDK v1.8.0_66
          +1 javac 0m 19s the patch passed
          +1 compile 0m 22s the patch passed with JDK v1.7.0_85
          +1 javac 0m 22s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 29s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 51s the patch passed
          +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 17s the patch passed with JDK v1.7.0_85
          -1 unit 8m 46s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          -1 unit 9m 22s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          33m 15s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster
          JDK v1.7.0_85 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774342/MAPREDUCE-6555.03.patch
          JIRA Issue MAPREDUCE-6557
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f93ab122ef64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 177975e
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 31s trunk passed +1 compile 0m 19s trunk passed with JDK v1.8.0_66 +1 compile 0m 23s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 11s trunk passed +1 mvnsite 0m 27s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 43s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 17s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 26s the patch passed +1 compile 0m 19s the patch passed with JDK v1.8.0_66 +1 javac 0m 19s the patch passed +1 compile 0m 22s the patch passed with JDK v1.7.0_85 +1 javac 0m 22s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 29s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 51s the patch passed +1 javadoc 0m 14s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 17s the patch passed with JDK v1.7.0_85 -1 unit 8m 46s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. -1 unit 9m 22s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 33m 15s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster JDK v1.7.0_85 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774342/MAPREDUCE-6555.03.patch JIRA Issue MAPREDUCE-6557 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f93ab122ef64 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 177975e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6195/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          03 patch LGTM. +1 pending on Jenkins report.

          Show
          djp Junping Du added a comment - 03 patch LGTM. +1 pending on Jenkins report.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Junping Du for the comment. Updated the patch to cleanup the test directory after the tests.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Junping Du for the comment. Updated the patch to cleanup the test directory after the tests.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          03

          • Removed unused import.
          Show
          ajisakaa Akira Ajisaka added a comment - 03 Removed unused import.
          Hide
          djp Junping Du added a comment -

          Thanks for the patch, Akira Ajisaka! As I just mentioned in MAPREDUCE-6555, may be we also want to fix the issue that the directory is not cleanup after test finish?

          Show
          djp Junping Du added a comment - Thanks for the patch, Akira Ajisaka ! As I just mentioned in MAPREDUCE-6555 , may be we also want to fix the issue that the directory is not cleanup after test finish?
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 49s trunk passed
          +1 compile 0m 22s trunk passed with JDK v1.8.0_66
          +1 compile 0m 26s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 32s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 51s trunk passed
          +1 javadoc 0m 18s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 20s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 28s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 25s the patch passed with JDK v1.7.0_85
          +1 javac 0m 25s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 0m 31s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 59s the patch passed
          +1 javadoc 0m 17s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 21s the patch passed with JDK v1.7.0_85
          -1 unit 9m 55s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66.
          -1 unit 10m 13s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          37m 39s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster
          JDK v1.7.0_85 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774280/MAPREDUCE-6557.00.patch
          JIRA Issue MAPREDUCE-6557
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c18c86fd6af5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b4c6b51
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 49s trunk passed +1 compile 0m 22s trunk passed with JDK v1.8.0_66 +1 compile 0m 26s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 32s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 51s trunk passed +1 javadoc 0m 18s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 20s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 28s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 25s the patch passed with JDK v1.7.0_85 +1 javac 0m 25s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 31s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 59s the patch passed +1 javadoc 0m 17s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 21s the patch passed with JDK v1.7.0_85 -1 unit 9m 55s hadoop-mapreduce-client-app in the patch failed with JDK v1.8.0_66. -1 unit 10m 13s hadoop-mapreduce-client-app in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 37m 39s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster JDK v1.7.0_85 Failed junit tests hadoop.mapreduce.v2.app.TestMRAppMaster Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774280/MAPREDUCE-6557.00.patch JIRA Issue MAPREDUCE-6557 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c18c86fd6af5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4c6b51 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6192/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          00 patch fixes the issue and includes minor refactoring.

          • Fix: Move staging directory from staging to testDir/staging.
          • Refactor: Change testDir from File to Path to remove redundant code.
          • Refactor: Move localFs to local variable.
          Show
          ajisakaa Akira Ajisaka added a comment - 00 patch fixes the issue and includes minor refactoring. Fix: Move staging directory from staging to testDir/staging . Refactor: Change testDir from File to Path to remove redundant code. Refactor: Move localFs to local variable.
          Hide
          aw Allen Wittenauer added a comment -

          From a recent patch run:

          Lines that start with ????? in the ASF License  report indicate files that do not have an Apache license header:
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004-1448284959695-TestAppMasterUser-%3Cmissing+job+name%3E-1448284959873-0-0-FAILED-default-1448284959695.jhist
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004_conf.xml
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004.summary
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/job_1317529182569_0004_2_conf.xml
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/COMMIT_STARTED
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/job_1317529182569_0004_2.jhist
           !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/COMMIT_FAIL
          
          Show
          aw Allen Wittenauer added a comment - From a recent patch run: Lines that start with ????? in the ASF License report indicate files that do not have an Apache license header: !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004-1448284959695-TestAppMasterUser-%3Cmissing+job+name%3E-1448284959873-0-0-FAILED- default -1448284959695.jhist !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004_conf.xml !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/history/done_intermediate/TestAppMasterUser/job_1317529182569_0004.summary !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/job_1317529182569_0004_2_conf.xml !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/COMMIT_STARTED !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/job_1317529182569_0004_2.jhist !????? /testptch/hadoop/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/staging/TestAppMasterUser/.staging/job_1317529182569_0004/COMMIT_FAIL

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development