Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6550

archive-logs tool changes log ownership to the Yarn user when using DefaultContainerExecutor

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The archive-logs tool added in MAPREDUCE-6415 leverages the Distributed Shell app. When using the DefaultContainerExecutor, this means that the job will actually run as the Yarn user, so the resulting har files are owned by the Yarn user instead of the original owner. The permissions are also now world-readable.

      In the below example, the archived logs are owned by 'yarn' instead of 'paul' and are now world-readable:

      [root@gs28-centos66-5 ~]# sudo -u hdfs hdfs dfs -ls -R /tmp/logs
      ...
      drwxrwx---   - paul  hadoop          0 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005
      drwxr-xr-x   - yarn  hadoop          0 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005/application_1443805425363_0005.har
      -rw-r--r--   3 yarn  hadoop          0 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005/application_1443805425363_0005.har/_SUCCESS
      -rw-r--r--   3 yarn  hadoop       1256 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005/application_1443805425363_0005.har/_index
      -rw-r--r--   3 yarn  hadoop         24 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005/application_1443805425363_0005.har/_masterindex
      -rw-r--r--   3 yarn  hadoop    8451177 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0005/application_1443805425363_0005.har/part-0
      drwxrwx---   - paul  hadoop          0 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0006
      -rw-r-----   3 paul  hadoop       1155 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0006/gs-centos66-2.vpc.cloudera.com_8041
      -rw-r-----   3 paul  hadoop       4880 2015-10-02 13:24 /tmp/logs/paul/logs/application_1443805425363_0006/gs28-centos66-3.vpc.cloudera.com_8041
      ...
      
      1. MAPREDUCE-6550.001.patch
        10 kB
        Robert Kanter
      2. MAPREDUCE-6550.002.patch
        17 kB
        Robert Kanter
      3. MAPREDUCE-6550.003.patch
        18 kB
        Robert Kanter
      4. MAPREDUCE-6550.004.patch
        18 kB
        Robert Kanter
      5. MAPREDUCE-6550.005.patch
        18 kB
        Robert Kanter

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2582/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2582/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #737 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/737/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #737 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/737/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2668 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2668/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2668 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2668/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/726/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #726 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/726/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #645 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/645/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #645 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/645/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1457 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1457/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1457 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1457/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8894 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8894/)
          MAPREDUCE-6550. archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java
          • hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java
          • hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8894 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8894/ ) MAPREDUCE-6550 . archive-logs tool changes log ownership to the Yarn user (rkanter: rev 6d84cc16b3e0685fef01d0e3526b0f7556ceff51) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-archive-logs/src/site/markdown/HadoopArchiveLogs.md hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogs.java hadoop-tools/hadoop-archive-logs/src/main/java/org/apache/hadoop/tools/HadoopArchiveLogsRunner.java hadoop-tools/hadoop-archive-logs/src/test/java/org/apache/hadoop/tools/TestHadoopArchiveLogsRunner.java
          Hide
          rkanter Robert Kanter added a comment -

          Committed to trunk and branch-2!

          Show
          rkanter Robert Kanter added a comment - Committed to trunk and branch-2!
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for the reviews Jason. I'll commit this later today if nobody has any other comments.

          Show
          rkanter Robert Kanter added a comment - Thanks for the reviews Jason. I'll commit this later today if nobody has any other comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 9m 55s trunk passed
          +1 compile 0m 17s trunk passed with JDK v1.8.0_66
          +1 compile 0m 18s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 0m 33s trunk passed
          +1 javadoc 0m 16s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 17s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 22s the patch passed
          +1 compile 0m 18s the patch passed with JDK v1.8.0_66
          +1 javac 0m 18s the patch passed
          +1 compile 0m 19s the patch passed with JDK v1.7.0_85
          +1 javac 0m 19s the patch passed
          +1 checkstyle 0m 10s the patch passed
          +1 mvnsite 0m 25s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 42s the patch passed
          +1 javadoc 0m 16s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 16s the patch passed with JDK v1.7.0_85
          +1 unit 0m 43s hadoop-archive-logs in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 40s hadoop-archive-logs in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 28s Patch does not generate ASF License warnings.
          18m 39s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774256/MAPREDUCE-6550.005.patch
          JIRA Issue MAPREDUCE-6550
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 741d4d7deac7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / b4c6b51
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6191/testReport/
          modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6191/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 55s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 18s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 33s trunk passed +1 javadoc 0m 16s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 17s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 22s the patch passed +1 compile 0m 18s the patch passed with JDK v1.8.0_66 +1 javac 0m 18s the patch passed +1 compile 0m 19s the patch passed with JDK v1.7.0_85 +1 javac 0m 19s the patch passed +1 checkstyle 0m 10s the patch passed +1 mvnsite 0m 25s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 42s the patch passed +1 javadoc 0m 16s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 16s the patch passed with JDK v1.7.0_85 +1 unit 0m 43s hadoop-archive-logs in the patch passed with JDK v1.8.0_66. +1 unit 0m 40s hadoop-archive-logs in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 28s Patch does not generate ASF License warnings. 18m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774256/MAPREDUCE-6550.005.patch JIRA Issue MAPREDUCE-6550 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 741d4d7deac7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / b4c6b51 findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6191/testReport/ modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6191/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          The 005 patch increases some of the test timeouts, including the one that failed (due to a timeout).

          Show
          rkanter Robert Kanter added a comment - The 005 patch increases some of the test timeouts, including the one that failed (due to a timeout).
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 12m 43s trunk passed
          +1 compile 0m 25s trunk passed with JDK v1.8.0_66
          +1 compile 0m 23s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 30s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 0m 39s trunk passed
          +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 19s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 26s the patch passed
          +1 compile 0m 23s the patch passed with JDK v1.8.0_66
          +1 javac 0m 23s the patch passed
          +1 compile 0m 22s the patch passed with JDK v1.7.0_85
          +1 javac 0m 22s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 30s the patch passed
          +1 mvneclipse 0m 20s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 49s the patch passed
          +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 20s the patch passed with JDK v1.7.0_85
          -1 unit 1m 3s hadoop-archive-logs in the patch failed with JDK v1.8.0_66.
          +1 unit 0m 54s hadoop-archive-logs in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 33s Patch does not generate ASF License warnings.
          23m 56s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.tools.TestHadoopArchiveLogs



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774202/MAPREDUCE-6550.004.patch
          JIRA Issue MAPREDUCE-6550
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9cf5e8b88ec1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 23c625e
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archive-logs-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archive-logs-jdk1.8.0_66.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/testReport/
          modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 12m 43s trunk passed +1 compile 0m 25s trunk passed with JDK v1.8.0_66 +1 compile 0m 23s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 30s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 0m 39s trunk passed +1 javadoc 0m 22s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 19s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 26s the patch passed +1 compile 0m 23s the patch passed with JDK v1.8.0_66 +1 javac 0m 23s the patch passed +1 compile 0m 22s the patch passed with JDK v1.7.0_85 +1 javac 0m 22s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 30s the patch passed +1 mvneclipse 0m 20s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 49s the patch passed +1 javadoc 0m 23s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 20s the patch passed with JDK v1.7.0_85 -1 unit 1m 3s hadoop-archive-logs in the patch failed with JDK v1.8.0_66. +1 unit 0m 54s hadoop-archive-logs in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 33s Patch does not generate ASF License warnings. 23m 56s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.tools.TestHadoopArchiveLogs Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12774202/MAPREDUCE-6550.004.patch JIRA Issue MAPREDUCE-6550 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9cf5e8b88ec1 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 23c625e findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archive-logs-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/artifact/patchprocess/patch-unit-hadoop-tools_hadoop-archive-logs-jdk1.8.0_66.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/testReport/ modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6189/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          +1 latest patch lgtm, pending Jenkins.

          Show
          jlowe Jason Lowe added a comment - +1 latest patch lgtm, pending Jenkins.
          Hide
          rkanter Robert Kanter added a comment -

          The 004 patch fixes the conf checkstyle thing.

          Show
          rkanter Robert Kanter added a comment - The 004 patch fixes the conf checkstyle thing.
          Hide
          jlowe Jason Lowe added a comment -

          Agree with the checkstyle nit: the new conf local is eclipsing a field. We should either just use the conf field directly or rename the local for clarity.

          Otherwise patch looks good.

          Show
          jlowe Jason Lowe added a comment - Agree with the checkstyle nit: the new conf local is eclipsing a field. We should either just use the conf field directly or rename the local for clarity. Otherwise patch looks good.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 1s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 46s trunk passed
          +1 compile 0m 16s trunk passed with JDK v1.8.0_66
          +1 compile 0m 15s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 9s trunk passed
          +1 mvnsite 0m 23s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 14s the patch passed with JDK v1.8.0_66
          +1 javac 0m 14s the patch passed
          +1 compile 0m 16s the patch passed with JDK v1.7.0_85
          +1 javac 0m 16s the patch passed
          -1 checkstyle 0m 9s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-archive-logs (total was 7, now 7).
          +1 mvnsite 0m 22s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85
          +1 unit 0m 36s hadoop-archive-logs in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 37s hadoop-archive-logs in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          16m 27s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773612/MAPREDUCE-6550.003.patch
          JIRA Issue MAPREDUCE-6550
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux c7ad63137c3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 060cdcb
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/testReport/
          modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 46s trunk passed +1 compile 0m 16s trunk passed with JDK v1.8.0_66 +1 compile 0m 15s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 12s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 19s the patch passed +1 compile 0m 14s the patch passed with JDK v1.8.0_66 +1 javac 0m 14s the patch passed +1 compile 0m 16s the patch passed with JDK v1.7.0_85 +1 javac 0m 16s the patch passed -1 checkstyle 0m 9s Patch generated 1 new checkstyle issues in hadoop-tools/hadoop-archive-logs (total was 7, now 7). +1 mvnsite 0m 22s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85 +1 unit 0m 36s hadoop-archive-logs in the patch passed with JDK v1.8.0_66. +1 unit 0m 37s hadoop-archive-logs in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 16m 27s Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773612/MAPREDUCE-6550.003.patch JIRA Issue MAPREDUCE-6550 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux c7ad63137c3b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 060cdcb findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/testReport/ modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6178/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          That's also a good idea, and should be more efficient too.

          The 003 patch sets the umask for the 'hadoop archive' MR job to 027 so we get 640 files and 750 dirs.

          Show
          rkanter Robert Kanter added a comment - That's also a good idea, and should be more efficient too. The 003 patch sets the umask for the 'hadoop archive' MR job to 027 so we get 640 files and 750 dirs.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch! Looks good except for one minor thing: usually permission updates after the fact are a sign of potential security problems unless the permissions are being widened instead of restricted. Something could come along and get access to the file after it's written but before the permissions are fixed. Would it make more sense to update the filesystem umask before running the archive so the files are automatically created with the proper permissions?

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch! Looks good except for one minor thing: usually permission updates after the fact are a sign of potential security problems unless the permissions are being widened instead of restricted. Something could come along and get access to the file after it's written but before the permissions are fixed. Would it make more sense to update the filesystem umask before running the archive so the files are automatically created with the proper permissions?
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 9m 26s trunk passed
          +1 compile 0m 17s trunk passed with JDK v1.8.0_66
          +1 compile 0m 17s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 10s trunk passed
          +1 mvnsite 0m 24s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 0m 31s trunk passed
          +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 21s the patch passed
          +1 compile 0m 16s the patch passed with JDK v1.8.0_66
          +1 javac 0m 16s the patch passed
          +1 compile 0m 17s the patch passed with JDK v1.7.0_85
          +1 javac 0m 17s the patch passed
          +1 checkstyle 0m 9s the patch passed
          +1 mvnsite 0m 23s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 41s the patch passed
          +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85
          +1 unit 0m 42s hadoop-archive-logs in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 38s hadoop-archive-logs in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 27s Patch does not generate ASF License warnings.
          17m 55s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-20
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773418/MAPREDUCE-6550.002.patch
          JIRA Issue MAPREDUCE-6550
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0f07d0014558 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 4539131
          findbugs v3.0.0
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6176/testReport/
          modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs
          Max memory used 78MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6176/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 9m 26s trunk passed +1 compile 0m 17s trunk passed with JDK v1.8.0_66 +1 compile 0m 17s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 10s trunk passed +1 mvnsite 0m 24s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 31s trunk passed +1 javadoc 0m 15s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 21s the patch passed +1 compile 0m 16s the patch passed with JDK v1.8.0_66 +1 javac 0m 16s the patch passed +1 compile 0m 17s the patch passed with JDK v1.7.0_85 +1 javac 0m 17s the patch passed +1 checkstyle 0m 9s the patch passed +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 41s the patch passed +1 javadoc 0m 15s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85 +1 unit 0m 42s hadoop-archive-logs in the patch passed with JDK v1.8.0_66. +1 unit 0m 38s hadoop-archive-logs in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 27s Patch does not generate ASF License warnings. 17m 55s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-20 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12773418/MAPREDUCE-6550.002.patch JIRA Issue MAPREDUCE-6550 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0f07d0014558 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 4539131 findbugs v3.0.0 JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6176/testReport/ modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs Max memory used 78MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6176/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          Thanks for taking a look Jason. Those sound like good ideas.

          The 002 patch fixes checkstyle warnings, sets the sticky bit on the working dir, and adds a -noProxy option.

          Show
          rkanter Robert Kanter added a comment - Thanks for taking a look Jason. Those sound like good ideas. The 002 patch fixes checkstyle warnings, sets the sticky bit on the working dir, and adds a -noProxy option.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the patch, Robert!

          I'm a bit worried about having the working directory have wide-open permissions. Literally anyone on the cluster can go in and start rearranging the contents of that directory, as they have write permissions to it. I think we need to at least set the sticky bit on it so it's like /tmp. Users can create their own stuff but they can't fiddle with other users' stuff.

          Do we really want to only support the proxy user setup? Wondering if there's a scenario where admins want to aggregate the logs to save on the namespace but don't want to allow the proxy behaviors. As long as they're OK with fetching the logs via the log server and not via direct HDFS access by the user, it would still work despite the logs being owned by the HDFS user.

          Show
          jlowe Jason Lowe added a comment - Thanks for the patch, Robert! I'm a bit worried about having the working directory have wide-open permissions. Literally anyone on the cluster can go in and start rearranging the contents of that directory, as they have write permissions to it. I think we need to at least set the sticky bit on it so it's like /tmp. Users can create their own stuff but they can't fiddle with other users' stuff. Do we really want to only support the proxy user setup? Wondering if there's a scenario where admins want to aggregate the logs to save on the namespace but don't want to allow the proxy behaviors. As long as they're OK with fetching the logs via the log server and not via direct HDFS access by the user, it would still work despite the logs being owned by the HDFS user.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          +1 mvninstall 8m 47s trunk passed
          +1 compile 0m 14s trunk passed with JDK v1.8.0_66
          +1 compile 0m 16s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 9s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66
          +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85
          +1 mvninstall 0m 19s the patch passed
          +1 compile 0m 15s the patch passed with JDK v1.8.0_66
          +1 javac 0m 15s the patch passed
          +1 compile 0m 17s the patch passed with JDK v1.7.0_85
          +1 javac 0m 17s the patch passed
          -1 checkstyle 0m 9s Patch generated 39 new checkstyle issues in hadoop-tools/hadoop-archive-logs (total was 7, now 46).
          +1 mvnsite 0m 23s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 0m 37s the patch passed
          +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66
          +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85
          +1 unit 0m 35s hadoop-archive-logs in the patch passed with JDK v1.8.0_66.
          +1 unit 0m 37s hadoop-archive-logs in the patch passed with JDK v1.7.0_85.
          +1 asflicense 0m 26s Patch does not generate ASF License warnings.
          16m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:date2015-11-18
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772895/MAPREDUCE-6550.001.patch
          JIRA Issue MAPREDUCE-6550
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8df6190c82a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh
          git revision trunk / 7fab5c8
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/testReport/
          modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs
          Max memory used 76MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. +1 mvninstall 8m 47s trunk passed +1 compile 0m 14s trunk passed with JDK v1.8.0_66 +1 compile 0m 16s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 9s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 13s trunk passed with JDK v1.8.0_66 +1 javadoc 0m 15s trunk passed with JDK v1.7.0_85 +1 mvninstall 0m 19s the patch passed +1 compile 0m 15s the patch passed with JDK v1.8.0_66 +1 javac 0m 15s the patch passed +1 compile 0m 17s the patch passed with JDK v1.7.0_85 +1 javac 0m 17s the patch passed -1 checkstyle 0m 9s Patch generated 39 new checkstyle issues in hadoop-tools/hadoop-archive-logs (total was 7, now 46). +1 mvnsite 0m 23s the patch passed +1 mvneclipse 0m 15s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 0m 37s the patch passed +1 javadoc 0m 13s the patch passed with JDK v1.8.0_66 +1 javadoc 0m 15s the patch passed with JDK v1.7.0_85 +1 unit 0m 35s hadoop-archive-logs in the patch passed with JDK v1.8.0_66. +1 unit 0m 37s hadoop-archive-logs in the patch passed with JDK v1.7.0_85. +1 asflicense 0m 26s Patch does not generate ASF License warnings. 16m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:date2015-11-18 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12772895/MAPREDUCE-6550.001.patch JIRA Issue MAPREDUCE-6550 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8df6190c82a3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-3f4279a/precommit/personality/hadoop.sh git revision trunk / 7fab5c8 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/artifact/patchprocess/diff-checkstyle-hadoop-tools_hadoop-archive-logs.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/testReport/ modules C: hadoop-tools/hadoop-archive-logs U: hadoop-tools/hadoop-archive-logs Max memory used 76MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6169/console This message was automatically generated.
          Hide
          rkanter Robert Kanter added a comment -

          The patch fixes the user problem by using UGI to proxy as the correct user. It fixes the permissions problem by setting the correct permissions on the files. Other than those changes, the bulk of the changes in the patch are due to moving some things around and indenting.

          I've updated the unit tests to check for the permissions and also verified in a cluster that it behaves correctly.

          Show
          rkanter Robert Kanter added a comment - The patch fixes the user problem by using UGI to proxy as the correct user. It fixes the permissions problem by setting the correct permissions on the files. Other than those changes, the bulk of the changes in the patch are due to moving some things around and indenting. I've updated the unit tests to check for the permissions and also verified in a cluster that it behaves correctly.

            People

            • Assignee:
              rkanter Robert Kanter
              Reporter:
              rkanter Robert Kanter
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development