Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6526

Remove usage of metrics v1 from hadoop-mapreduce

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      LocalJobRunnerMetrics and ShuffleClientMetrics were updated to use Hadoop Metrics V2 framework.

      Description

      LocalJobRunnerMetrics and ShuffleClientMetrics are still using metrics v1. We should remove these metrics or rewrite them to use metrics v2.

      1. MAPREDUCE-6526.03.patch
        11 kB
        Akira Ajisaka
      2. MAPREDUCE-6526.02.patch
        11 kB
        Akira Ajisaka
      3. MAPREDUCE-6526.01.patch
        11 kB
        Akira Ajisaka
      4. MAPREDUCE-6526.00.patch
        11 kB
        Akira Ajisaka

        Issue Links

          Activity

          Hide
          ajisakaa Akira Ajisaka added a comment -
          Show
          ajisakaa Akira Ajisaka added a comment - Filed MAPREDUCE-6861 .
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Zhiyuan Yang for the comment. Metrics tags were removed unintentionally. I'd like to add them back.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Zhiyuan Yang for the comment. Metrics tags were removed unintentionally. I'd like to add them back.
          Hide
          aplusplus Zhiyuan Yang added a comment -

          Why metrics tags were removed? @Akira Ajisaka

          Show
          aplusplus Zhiyuan Yang added a comment - Why metrics tags were removed? @ Akira Ajisaka
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9703 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9703/)
          MAPREDUCE-6526. Remove usage of metrics v1 from hadoop-mapreduce. (aajisaka: rev 4ee4e5ca2b8488459d2231dd1de8ed44dd656d5c)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalJobRunnerMetrics.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/Shuffle.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/ShuffleClientMetrics.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalJobRunner.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9703 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9703/ ) MAPREDUCE-6526 . Remove usage of metrics v1 from hadoop-mapreduce. (aajisaka: rev 4ee4e5ca2b8488459d2231dd1de8ed44dd656d5c) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalJobRunnerMetrics.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/Shuffle.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/task/reduce/ShuffleClientMetrics.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapred/LocalJobRunner.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk. Thanks Andrew for reviewing.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk. Thanks Andrew for reviewing.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 9s Maven dependency ordering for branch
          +1 mvninstall 6m 54s trunk passed
          +1 compile 1m 24s trunk passed with JDK v1.8.0_91
          +1 compile 1m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 26s trunk passed
          +1 findbugs 1m 50s trunk passed
          +1 javadoc 0m 41s trunk passed with JDK v1.8.0_91
          +1 javadoc 0m 52s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 9s Maven dependency ordering for patch
          +1 mvninstall 0m 45s the patch passed
          +1 compile 1m 27s the patch passed with JDK v1.8.0_91
          +1 javac 2m 21s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 346 unchanged - 16 fixed = 346 total (was 362)
          +1 javac 1m 27s hadoop-mapreduce-client in the patch passed with JDK v1.8.0_91.
          +1 compile 1m 40s the patch passed with JDK v1.7.0_95
          +1 javac 4m 1s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 350 unchanged - 17 fixed = 350 total (was 367)
          +1 javac 1m 40s hadoop-mapreduce-client in the patch passed with JDK v1.7.0_95.
          -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75)
          +1 mvnsite 0m 52s the patch passed
          +1 mvneclipse 0m 23s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 13s the patch passed
          +1 javadoc 0m 37s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 48s the patch passed with JDK v1.7.0_95
          +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91.
          +1 unit 0m 38s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 19s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 47s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          32m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801852/MAPREDUCE-6526.03.patch
          JIRA Issue MAPREDUCE-6526
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 93296d3396ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 9s Maven dependency ordering for branch +1 mvninstall 6m 54s trunk passed +1 compile 1m 24s trunk passed with JDK v1.8.0_91 +1 compile 1m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 26s trunk passed +1 findbugs 1m 50s trunk passed +1 javadoc 0m 41s trunk passed with JDK v1.8.0_91 +1 javadoc 0m 52s trunk passed with JDK v1.7.0_95 0 mvndep 0m 9s Maven dependency ordering for patch +1 mvninstall 0m 45s the patch passed +1 compile 1m 27s the patch passed with JDK v1.8.0_91 +1 javac 2m 21s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 346 unchanged - 16 fixed = 346 total (was 362) +1 javac 1m 27s hadoop-mapreduce-client in the patch passed with JDK v1.8.0_91. +1 compile 1m 40s the patch passed with JDK v1.7.0_95 +1 javac 4m 1s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 350 unchanged - 17 fixed = 350 total (was 367) +1 javac 1m 40s hadoop-mapreduce-client in the patch passed with JDK v1.7.0_95. -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75) +1 mvnsite 0m 52s the patch passed +1 mvneclipse 0m 23s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 13s the patch passed +1 javadoc 0m 37s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 48s the patch passed with JDK v1.7.0_95 +1 unit 1m 59s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_91. +1 unit 0m 38s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 19s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 unit 0m 47s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 32m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801852/MAPREDUCE-6526.03.patch JIRA Issue MAPREDUCE-6526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 93296d3396ff 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6480/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 57s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 36s Maven dependency ordering for branch
          +1 mvninstall 7m 0s trunk passed
          +1 compile 1m 26s trunk passed with JDK v1.8.0_91
          +1 compile 1m 38s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          +1 findbugs 1m 47s trunk passed
          +1 javadoc 0m 41s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 11s Maven dependency ordering for patch
          +1 mvninstall 0m 44s the patch passed
          +1 compile 1m 27s the patch passed with JDK v1.8.0_91
          +1 javac 2m 22s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 346 unchanged - 16 fixed = 346 total (was 362)
          +1 javac 1m 27s hadoop-mapreduce-client in the patch passed with JDK v1.8.0_91.
          +1 compile 1m 37s the patch passed with JDK v1.7.0_95
          +1 javac 4m 0s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 350 unchanged - 17 fixed = 350 total (was 367)
          +1 javac 1m 37s hadoop-mapreduce-client in the patch passed with JDK v1.7.0_95.
          -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75)
          +1 mvnsite 0m 50s the patch passed
          +1 mvneclipse 0m 21s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 5s the patch passed
          +1 javadoc 0m 37s the patch passed with JDK v1.8.0_91
          +1 javadoc 0m 46s the patch passed with JDK v1.7.0_95
          -1 unit 1m 55s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_91.
          +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95.
          +1 unit 0m 46s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          43m 59s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.mapreduce.tools.TestCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801852/MAPREDUCE-6526.03.patch
          JIRA Issue MAPREDUCE-6526
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 082187417c72 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_91.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/testReport/
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 57s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 36s Maven dependency ordering for branch +1 mvninstall 7m 0s trunk passed +1 compile 1m 26s trunk passed with JDK v1.8.0_91 +1 compile 1m 38s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 27s trunk passed +1 findbugs 1m 47s trunk passed +1 javadoc 0m 41s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 3s trunk passed with JDK v1.7.0_95 0 mvndep 0m 11s Maven dependency ordering for patch +1 mvninstall 0m 44s the patch passed +1 compile 1m 27s the patch passed with JDK v1.8.0_91 +1 javac 2m 22s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.8.0_91 with JDK v1.8.0_91 generated 0 new + 346 unchanged - 16 fixed = 346 total (was 362) +1 javac 1m 27s hadoop-mapreduce-client in the patch passed with JDK v1.8.0_91. +1 compile 1m 37s the patch passed with JDK v1.7.0_95 +1 javac 4m 0s hadoop-mapreduce-project_hadoop-mapreduce-client-jdk1.7.0_95 with JDK v1.7.0_95 generated 0 new + 350 unchanged - 17 fixed = 350 total (was 367) +1 javac 1m 37s hadoop-mapreduce-client in the patch passed with JDK v1.7.0_95. -1 checkstyle 0m 22s hadoop-mapreduce-project/hadoop-mapreduce-client: patch generated 1 new + 74 unchanged - 1 fixed = 75 total (was 75) +1 mvnsite 0m 50s the patch passed +1 mvneclipse 0m 21s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 37s the patch passed with JDK v1.8.0_91 +1 javadoc 0m 46s the patch passed with JDK v1.7.0_95 -1 unit 1m 55s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_91. +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 14s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_95. +1 unit 0m 46s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 43m 59s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.mapreduce.tools.TestCLI Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801852/MAPREDUCE-6526.03.patch JIRA Issue MAPREDUCE-6526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 082187417c72 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6476/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          andrew.wang Andrew Wang added a comment -

          Still LGTM +1

          Show
          andrew.wang Andrew Wang added a comment - Still LGTM +1
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Andrew for the review! I forgot to fix the following checkstyle issue:

          ShuffleClientMetrics.java
          public void inputBytes(long numBytes) {
            this.numBytes.incr(numBytes);
          }
          

          so I've updated the patch. Would you review it?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Andrew for the review! I forgot to fix the following checkstyle issue: ShuffleClientMetrics.java public void inputBytes( long numBytes) { this .numBytes.incr(numBytes); } so I've updated the patch. Would you review it?
          Hide
          andrew.wang Andrew Wang added a comment -

          +1 LGTM, thanks Akira!

          Show
          andrew.wang Andrew Wang added a comment - +1 LGTM, thanks Akira!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 12s trunk passed
          +1 compile 2m 41s trunk passed with JDK v1.8.0_60
          +1 compile 2m 43s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 2m 17s trunk passed
          +1 javadoc 0m 48s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 56s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 50s the patch passed
          +1 compile 2m 41s the patch passed with JDK v1.8.0_60
          +1 javac 2m 41s the patch passed
          +1 compile 2m 28s the patch passed with JDK v1.7.0_79
          +1 javac 2m 28s the patch passed
          -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client (total was 78, now 79).
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 29s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 26s the patch passed
          +1 javadoc 0m 46s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 53s the patch passed with JDK v1.7.0_79
          +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 42s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79.
          +1 unit 2m 1s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 21s Patch generated 1 ASF License warnings.
          33m 17s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771928/MAPREDUCE-6526.02.patch
          JIRA Issue MAPREDUCE-6526
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b3734396cf87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 9ad708a
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 227MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 12s trunk passed +1 compile 2m 41s trunk passed with JDK v1.8.0_60 +1 compile 2m 43s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 5s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 2m 17s trunk passed +1 javadoc 0m 48s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 56s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 50s the patch passed +1 compile 2m 41s the patch passed with JDK v1.8.0_60 +1 javac 2m 41s the patch passed +1 compile 2m 28s the patch passed with JDK v1.7.0_79 +1 javac 2m 28s the patch passed -1 checkstyle 0m 19s Patch generated 1 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client (total was 78, now 79). +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 29s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 26s the patch passed +1 javadoc 0m 46s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 53s the patch passed with JDK v1.7.0_79 +1 unit 0m 42s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60. +1 unit 1m 42s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60. +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79. +1 unit 2m 1s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 21s Patch generated 1 ASF License warnings. 33m 17s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771928/MAPREDUCE-6526.02.patch JIRA Issue MAPREDUCE-6526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b3734396cf87 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 9ad708a findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 227MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6153/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Removed final modifier from ShuffleClientMetrics to fix test failure.

          Show
          ajisakaa Akira Ajisaka added a comment - Removed final modifier from ShuffleClientMetrics to fix test failure.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 6s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 5s trunk passed
          +1 compile 2m 25s trunk passed with JDK v1.8.0_60
          +1 compile 2m 27s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 2m 3s trunk passed
          +1 javadoc 0m 47s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 52s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 47s the patch passed
          +1 compile 2m 36s the patch passed with JDK v1.8.0_60
          +1 javac 2m 36s the patch passed
          +1 compile 2m 43s the patch passed with JDK v1.7.0_79
          +1 javac 2m 43s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 31s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 37s the patch passed
          +1 javadoc 0m 48s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 56s the patch passed with JDK v1.7.0_79
          +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60.
          -1 unit 1m 57s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_60.
          +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79.
          -1 unit 2m 1s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_79.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          32m 59s



          Reason Tests
          JDK v1.8.0_60 Failed junit tests hadoop.mapreduce.task.reduce.TestFetcher
          JDK v1.7.0_79 Failed junit tests hadoop.mapreduce.task.reduce.TestFetcher



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771919/MAPREDUCE-6526.01.patch
          JIRA Issue MAPREDUCE-6526
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux bfeb24126fbc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 9ad708a
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 226MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 6s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 5s trunk passed +1 compile 2m 25s trunk passed with JDK v1.8.0_60 +1 compile 2m 27s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 19s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 0m 47s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 52s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 47s the patch passed +1 compile 2m 36s the patch passed with JDK v1.8.0_60 +1 javac 2m 36s the patch passed +1 compile 2m 43s the patch passed with JDK v1.7.0_79 +1 javac 2m 43s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 31s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 37s the patch passed +1 javadoc 0m 48s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 56s the patch passed with JDK v1.7.0_79 +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60. -1 unit 1m 57s hadoop-mapreduce-client-core in the patch failed with JDK v1.8.0_60. +1 unit 0m 48s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79. -1 unit 2m 1s hadoop-mapreduce-client-core in the patch failed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 32m 59s Reason Tests JDK v1.8.0_60 Failed junit tests hadoop.mapreduce.task.reduce.TestFetcher JDK v1.7.0_79 Failed junit tests hadoop.mapreduce.task.reduce.TestFetcher Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771919/MAPREDUCE-6526.01.patch JIRA Issue MAPREDUCE-6526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux bfeb24126fbc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 9ad708a findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 226MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6152/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Fixed checkstyle issue.

          Show
          ajisakaa Akira Ajisaka added a comment - Fixed checkstyle issue.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 3m 16s trunk passed
          +1 compile 2m 39s trunk passed with JDK v1.8.0_60
          +1 compile 2m 34s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 24s trunk passed
          +1 mvnsite 0m 56s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 2m 6s trunk passed
          +1 javadoc 0m 47s trunk passed with JDK v1.8.0_60
          +1 javadoc 0m 53s trunk passed with JDK v1.7.0_79
          +1 mvninstall 0m 49s the patch passed
          +1 compile 2m 26s the patch passed with JDK v1.8.0_60
          +1 javac 2m 26s the patch passed
          +1 compile 2m 31s the patch passed with JDK v1.7.0_79
          +1 javac 2m 31s the patch passed
          -1 checkstyle 0m 20s Patch generated 2 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client (total was 78, now 80).
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 27s the patch passed
          +1 javadoc 0m 46s the patch passed with JDK v1.8.0_60
          +1 javadoc 0m 54s the patch passed with JDK v1.7.0_79
          +1 unit 0m 41s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60.
          +1 unit 1m 43s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60.
          +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79.
          +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79.
          -1 asflicense 0m 23s Patch generated 1 ASF License warnings.
          32m 53s



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771913/MAPREDUCE-6526.00.patch
          JIRA Issue MAPREDUCE-6526
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 877cc419869a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh
          git revision trunk / 9ad708a
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/testReport/
          asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/artifact/patchprocess/patch-asflicense-problems.txt
          modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client
          Max memory used 228MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 3m 16s trunk passed +1 compile 2m 39s trunk passed with JDK v1.8.0_60 +1 compile 2m 34s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 24s trunk passed +1 mvnsite 0m 56s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 2m 6s trunk passed +1 javadoc 0m 47s trunk passed with JDK v1.8.0_60 +1 javadoc 0m 53s trunk passed with JDK v1.7.0_79 +1 mvninstall 0m 49s the patch passed +1 compile 2m 26s the patch passed with JDK v1.8.0_60 +1 javac 2m 26s the patch passed +1 compile 2m 31s the patch passed with JDK v1.7.0_79 +1 javac 2m 31s the patch passed -1 checkstyle 0m 20s Patch generated 2 new checkstyle issues in hadoop-mapreduce-project/hadoop-mapreduce-client (total was 78, now 80). +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 27s the patch passed +1 javadoc 0m 46s the patch passed with JDK v1.8.0_60 +1 javadoc 0m 54s the patch passed with JDK v1.7.0_79 +1 unit 0m 41s hadoop-mapreduce-client-common in the patch passed with JDK v1.8.0_60. +1 unit 1m 43s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_60. +1 unit 0m 49s hadoop-mapreduce-client-common in the patch passed with JDK v1.7.0_79. +1 unit 2m 7s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_79. -1 asflicense 0m 23s Patch generated 1 ASF License warnings. 32m 53s Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-11-12 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12771913/MAPREDUCE-6526.00.patch JIRA Issue MAPREDUCE-6526 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 877cc419869a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-MAPREDUCE-Build/patchprocess/apache-yetus-fa12328/precommit/personality/hadoop.sh git revision trunk / 9ad708a findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core U: hadoop-mapreduce-project/hadoop-mapreduce-client Max memory used 228MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6151/console This message was automatically generated.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Sounds good.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Sounds good.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          IMHO, they are still useful to analyse performance. I prefer to rewrite them to use Metrics v2.

          Agree. I'll upload the patch to use metrics v2.

          Show
          ajisakaa Akira Ajisaka added a comment - IMHO, they are still useful to analyse performance. I prefer to rewrite them to use Metrics v2. Agree. I'll upload the patch to use metrics v2.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Do you think LocalJobRunnerMetrics and ShuffleClientMetrics are not useful Metrics? IMHO, they are still useful to analyse performance. I prefer to rewrite them to use Metrics v2. Compatibility itself is second priority. However, I think third party tools use the values of counters. I also prefer to use same counter name at least.

          Show
          ozawa Tsuyoshi Ozawa added a comment - Do you think LocalJobRunnerMetrics and ShuffleClientMetrics are not useful Metrics? IMHO, they are still useful to analyse performance. I prefer to rewrite them to use Metrics v2. Compatibility itself is second priority. However, I think third party tools use the values of counters. I also prefer to use same counter name at least.

            People

            • Assignee:
              ajisakaa Akira Ajisaka
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development