Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6481

LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.2, 2.6.3, 3.0.0-alpha1
    • Component/s: mrv2
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes.
      There are two issues:

      1. LineRecordReader may give incomplete record: some characters cut off at the end of record.
      2. LineRecordReader may give wrong position/key information.

      The first issue only happens for Custom Delimiter, which is caused by the following code at LineReader#readCustomLine:

          if (appendLength > 0) {
              if (ambiguousByteCount > 0) {
                str.append(recordDelimiterBytes, 0, ambiguousByteCount);
                //appending the ambiguous characters (refer case 2.2)
                bytesConsumed += ambiguousByteCount;
                ambiguousByteCount=0;
              }
              str.append(buffer, startPosn, appendLength);
              txtLength += appendLength;
            }
      

      If appendLength is 0 and ambiguousByteCount is not 0, this bug will be triggered. For example, input is "123456789aab", Custom Delimiter is "ab", bufferSize is 10 and splitLength is 12, the correct record should be "123456789a" with length 10, but we get incomplete record "123456789" with length 9 from current code.

      The second issue can happen for both Custom Delimiter and Default Delimiter, which is caused by the code in UncompressedSplitLineReader#readLine. UncompressedSplitLineReader#readLine may report wrong size information at some corner cases. The reason is unusedBytes in the following code:

      bytesRead += unusedBytes;
      unusedBytes = bufferSize - getBufferPosn();
      bytesRead -= unusedBytes;
      

      If the last bytes read (bufferLength) is less than bufferSize, the previous unusedBytes will be wrong, which should be bufferLength - bufferPosn instead of bufferSize - bufferPosn. It will return larger value.
      For example, input is "1234567890ab12ab345", Custom Delimiter is "ab", bufferSize is 10 and two splits:first splitLength is 15 and second splitLength 4:
      the current code will give the following result:
      First record: Key:0 Value:"1234567890"
      Second record: Key:12 Value:"12"
      Third Record: Key:21 Value:"345"
      You can see the Key for the third record is wrong, it should be 16 instead of 21. It is due to wrong unusedBytes. fillBuffer read 10 bytes for the first time, for the second times, it only read 5 bytes, which is 5 bytes less than the bufferSize. That is why the key we get is 5 bytes larger than the correct one.

        Issue Links

          Activity

          Hide
          zxu zhihai xu added a comment -

          I attached a patch MAPREDUCE-6481.000.patch which should fix both issues. I add several test cases in the patch to cover all these corner cases, these test cases will help avoid regression in the future.

          Show
          zxu zhihai xu added a comment - I attached a patch MAPREDUCE-6481 .000.patch which should fix both issues. I add several test cases in the patch to cover all these corner cases, these test cases will help avoid regression in the future.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 24s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 47s There were no new javac warning messages.
          +1 javadoc 10m 3s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 54s There were no new checkstyle issues.
          +1 whitespace 0m 2s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 58s Tests passed in hadoop-common.
          +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.
              68m 37s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756420/MAPREDUCE-6481.000.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0832b38
          hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 24s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 javadoc 10m 3s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 54s There were no new checkstyle issues. +1 whitespace 0m 2s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 58s Tests passed in hadoop-common. +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.     68m 37s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756420/MAPREDUCE-6481.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0832b38 hadoop-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/artifact/patchprocess/testrun_hadoop-common.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5998/console This message was automatically generated.
          Hide
          jlowe Jason Lowe added a comment -

          Nice catch! Excellent analysis, and patch looks great.

          +1, committing this.

          Show
          jlowe Jason Lowe added a comment - Nice catch! Excellent analysis, and patch looks great. +1, committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks zhihai xu! I committed this to trunk and branch-2.

          It would be nice to get this fixed for 2.7.2, but the patch doesn't apply. Could you provide a patch for branch-2.7 as well?

          Show
          jlowe Jason Lowe added a comment - Thanks zhihai xu ! I committed this to trunk and branch-2. It would be nice to get this fixed for 2.7.2, but the patch doesn't apply. Could you provide a patch for branch-2.7 as well?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8470/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8470 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8470/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1142/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1142 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1142/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #408 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/408/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #408 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/408/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/401/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/401/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2323 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2323/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2323 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2323/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #384 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/384/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #384 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/384/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2348 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2348/)
          MAPREDUCE-6481. LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2348 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2348/ ) MAPREDUCE-6481 . LineRecordReader may give incomplete record and wrong position/key information for uncompressed input sometimes. Contributed by Zhihai Xu (jlowe: rev 58d1a02b8d66b1d2a6ac2158be32bd35ad2e69bd) hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/LineReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapreduce/lib/input/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/test/java/org/apache/hadoop/mapred/TestLineRecordReader.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/UncompressedSplitLineReader.java
          Hide
          zxu zhihai xu added a comment -

          Jason Lowe, thanks for the review and committing the patch! This patch will depend on MAPREDUCE-5948, I can apply the patch cleanly after apply MAPREDUCE-5948. Shall we add both MAPREDUCE-5948 and MAPREDUCE-6481 to 2.7.2 release?

          Show
          zxu zhihai xu added a comment - Jason Lowe , thanks for the review and committing the patch! This patch will depend on MAPREDUCE-5948 , I can apply the patch cleanly after apply MAPREDUCE-5948 . Shall we add both MAPREDUCE-5948 and MAPREDUCE-6481 to 2.7.2 release?
          Hide
          jlowe Jason Lowe added a comment -

          Sure, I'll pull both of them into the 2.7.2 release.

          Show
          jlowe Jason Lowe added a comment - Sure, I'll pull both of them into the 2.7.2 release.
          Hide
          jlowe Jason Lowe added a comment -

          I committed this to branch-2.7 as well.

          Show
          jlowe Jason Lowe added a comment - I committed this to branch-2.7 as well.
          Hide
          zxu zhihai xu added a comment -

          Thanks Jason Lowe! It is great that we have both MAPREDUCE-5948 and MAPREDUCE-6481 fixed at 2.7.2 release.

          Show
          zxu zhihai xu added a comment - Thanks Jason Lowe ! It is great that we have both MAPREDUCE-5948 and MAPREDUCE-6481 fixed at 2.7.2 release.
          Hide
          sjlee0 Sangjin Lee added a comment -

          Does this issue exist in 2.6.x? Should this be backported to branch-2.6?

          Show
          sjlee0 Sangjin Lee added a comment - Does this issue exist in 2.6.x? Should this be backported to branch-2.6?
          Hide
          jlowe Jason Lowe added a comment -

          I committed this to branch-2.6.

          Show
          jlowe Jason Lowe added a comment - I committed this to branch-2.6.

            People

            • Assignee:
              zxu zhihai xu
              Reporter:
              zxu zhihai xu
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development