Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Under extremely rare conditions (.0017% in our sample size), launchTime in the jhist files may be set to -1.

      1. REPRODUCE.patch
        8 kB
        zhihai xu
      2. MAPREDUCE-6433.000.patch
        11 kB
        zhihai xu
      3. MAPREDUCE-6433.001.patch
        11 kB
        zhihai xu
      4. MAPREDUCE-6433-branch-2.7.001.patch
        12 kB
        Chris Douglas

        Activity

        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to branch-2.7. Thanks Chris Douglas for the backport.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to branch-2.7. Thanks Chris Douglas for the backport.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        +1 for the branch-2.7 patch.

        Show
        ajisakaa Akira Ajisaka added a comment - +1 for the branch-2.7 patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 11m 1s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 45s Maven dependency ordering for branch
        +1 mvninstall 7m 18s branch-2.7 passed
        +1 compile 1m 2s branch-2.7 passed with JDK v1.8.0_131
        +1 compile 1m 10s branch-2.7 passed with JDK v1.7.0_131
        +1 checkstyle 0m 31s branch-2.7 passed
        +1 mvnsite 0m 56s branch-2.7 passed
        +1 mvneclipse 0m 25s branch-2.7 passed
        -1 findbugs 0m 41s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in branch-2.7 has 1 extant Findbugs warnings.
        -1 findbugs 1m 1s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in branch-2.7 has 2 extant Findbugs warnings.
        +1 javadoc 0m 33s branch-2.7 passed with JDK v1.8.0_131
        +1 javadoc 0m 37s branch-2.7 passed with JDK v1.7.0_131
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 0m 42s the patch passed
        +1 compile 1m 1s the patch passed with JDK v1.8.0_131
        +1 javac 1m 1s the patch passed
        +1 compile 1m 9s the patch passed with JDK v1.7.0_131
        +1 javac 1m 9s the patch passed
        -1 checkstyle 0m 30s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 8 new + 976 unchanged - 6 fixed = 984 total (was 982)
        +1 mvnsite 0m 51s the patch passed
        +1 mvneclipse 0m 21s the patch passed
        -1 whitespace 0m 0s The patch has 2391 line(s) that end in whitespace. Use git apply --whitespace=fix.
        -1 whitespace 0m 49s The patch 209 line(s) with tabs.
        +1 findbugs 2m 0s the patch passed
        +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131
        +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131
        +1 unit 1m 34s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_131.
        +1 unit 8m 25s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_131.
        +1 unit 1m 47s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_131.
        +1 unit 8m 39s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_131.
        -1 asflicense 0m 16s The patch generated 11 ASF License warnings.
        56m 42s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:67e87c9
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874419/MAPREDUCE-6433-branch-2.7.001.patch
        JIRA Issue MAPREDUCE-6433
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux b6b3c0f0a6a4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision branch-2.7 / 80ed105
        Default Java 1.7.0_131
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
        findbugs v3.0.0
        findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-warnings.html
        findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/whitespace-eol.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/whitespace-tabs.txt
        JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/testReport/
        asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/patch-asflicense-problems.txt
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 1s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 45s Maven dependency ordering for branch +1 mvninstall 7m 18s branch-2.7 passed +1 compile 1m 2s branch-2.7 passed with JDK v1.8.0_131 +1 compile 1m 10s branch-2.7 passed with JDK v1.7.0_131 +1 checkstyle 0m 31s branch-2.7 passed +1 mvnsite 0m 56s branch-2.7 passed +1 mvneclipse 0m 25s branch-2.7 passed -1 findbugs 0m 41s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app in branch-2.7 has 1 extant Findbugs warnings. -1 findbugs 1m 1s hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core in branch-2.7 has 2 extant Findbugs warnings. +1 javadoc 0m 33s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 0m 37s branch-2.7 passed with JDK v1.7.0_131 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 0m 42s the patch passed +1 compile 1m 1s the patch passed with JDK v1.8.0_131 +1 javac 1m 1s the patch passed +1 compile 1m 9s the patch passed with JDK v1.7.0_131 +1 javac 1m 9s the patch passed -1 checkstyle 0m 30s hadoop-mapreduce-project/hadoop-mapreduce-client: The patch generated 8 new + 976 unchanged - 6 fixed = 984 total (was 982) +1 mvnsite 0m 51s the patch passed +1 mvneclipse 0m 21s the patch passed -1 whitespace 0m 0s The patch has 2391 line(s) that end in whitespace. Use git apply --whitespace=fix. -1 whitespace 0m 49s The patch 209 line(s) with tabs. +1 findbugs 2m 0s the patch passed +1 javadoc 0m 28s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 34s the patch passed with JDK v1.7.0_131 +1 unit 1m 34s hadoop-mapreduce-client-core in the patch passed with JDK v1.8.0_131. +1 unit 8m 25s hadoop-mapreduce-client-app in the patch passed with JDK v1.8.0_131. +1 unit 1m 47s hadoop-mapreduce-client-core in the patch passed with JDK v1.7.0_131. +1 unit 8m 39s hadoop-mapreduce-client-app in the patch passed with JDK v1.7.0_131. -1 asflicense 0m 16s The patch generated 11 ASF License warnings. 56m 42s Subsystem Report/Notes Docker Image:yetus/hadoop:67e87c9 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12874419/MAPREDUCE-6433-branch-2.7.001.patch JIRA Issue MAPREDUCE-6433 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b6b3c0f0a6a4 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 80ed105 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-app-warnings.html findbugs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/branch-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core-warnings.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/whitespace-eol.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/whitespace-tabs.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/testReport/ asflicense https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/artifact/patchprocess/patch-asflicense-problems.txt modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6999/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        Backport to branch-2.7.

        This doesn't seem major, but it's easy to include in the upcoming 2.7.4 release.

        Show
        chris.douglas Chris Douglas added a comment - Backport to branch-2.7. This doesn't seem major, but it's easy to include in the upcoming 2.7.4 release.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/270/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #270 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/270/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2200/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2200 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2200/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2219/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2219 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2219/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/262/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/262/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #1003 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1003/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1003 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1003/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/273/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #273 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/273/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        Hide
        zxu zhihai xu added a comment -

        Committed the patch to trunk and branch-2.

        Show
        zxu zhihai xu added a comment - Committed the patch to trunk and branch-2.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8250 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8250/)
        MAPREDUCE-6433. launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8250 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8250/ ) MAPREDUCE-6433 . launchTime may be negative. Contributed by Zhihai Xu (zxu: rev 93d50b782494af7eef980c4d596a59ff4e11646e) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/event/JobStartEvent.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/TestMRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/MRAppMaster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/jobhistory/EventWriter.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/v2/app/job/impl/JobImpl.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        zxu zhihai xu added a comment -

        thanks Robert Kanter for the review! will commit it shortly.

        Show
        zxu zhihai xu added a comment - thanks Robert Kanter for the review! will commit it shortly.
        Hide
        rkanter Robert Kanter added a comment -

        Good catch; I missed the VisibleForTesting that should have been there. +1

        Show
        rkanter Robert Kanter added a comment - Good catch; I missed the VisibleForTesting that should have been there. +1
        Hide
        zxu zhihai xu added a comment -

        I uploaded a new patch MAPREDUCE-6433.001.patch which remove the log LOG.info("testMRAppMasterMidLock stop"); in testMRAppMasterJobLaunchTime and add two annotations VisibleForTesting in EventWriter. These are minor change.
        Robert Kanter, Could you give another look, please ?

        Show
        zxu zhihai xu added a comment - I uploaded a new patch MAPREDUCE-6433 .001.patch which remove the log LOG.info("testMRAppMasterMidLock stop"); in testMRAppMasterJobLaunchTime and add two annotations VisibleForTesting in EventWriter. These are minor change. Robert Kanter , Could you give another look, please ?
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 1s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 34s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 12s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 22s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 14s Tests passed in hadoop-mapreduce-client-app.
        +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.
            51m 18s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12747945/MAPREDUCE-6433.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ddc867ce
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 1s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 12s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 14s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.     51m 18s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747945/MAPREDUCE-6433.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ddc867ce hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5915/console This message was automatically generated.
        Hide
        rkanter Robert Kanter added a comment -

        LGTM +1

        Show
        rkanter Robert Kanter added a comment - LGTM +1
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 14s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 41s There were no new javac warning messages.
        +1 javadoc 9m 39s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 16s There were no new checkstyle issues.
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 24s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 6s Tests passed in hadoop-mapreduce-client-app.
        +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.
            51m 34s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746929/MAPREDUCE-6433.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / ab3197c
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 16s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 24s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 2m 31s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 6s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 1m 45s Tests passed in hadoop-mapreduce-client-core.     51m 34s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746929/MAPREDUCE-6433.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ab3197c hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5909/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 21m 26s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 9m 30s There were no new javac warning messages.
        +1 javadoc 11m 51s There were no new javadoc warning messages.
        +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 31s The applied patch generated 1 new checkstyle issues (total was 4, now 5).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 46s mvn install still works.
        +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse.
        +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 10m 15s Tests passed in hadoop-mapreduce-client-app.
        +1 mapreduce tests 2m 18s Tests passed in hadoop-mapreduce-client-core.
            63m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746910/MAPREDUCE-6433.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 1d3026e
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 30s There were no new javac warning messages. +1 javadoc 11m 51s There were no new javadoc warning messages. +1 release audit 0m 27s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 31s The applied patch generated 1 new checkstyle issues (total was 4, now 5). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 46s mvn install still works. +1 eclipse:eclipse 0m 43s The patch built with eclipse:eclipse. +1 findbugs 3m 14s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 10m 15s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 2m 18s Tests passed in hadoop-mapreduce-client-core.     63m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746910/MAPREDUCE-6433.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1d3026e checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5908/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 16m 53s Findbugs (version ) appears to be broken on trunk.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 8m 12s There were no new javac warning messages.
        +1 javadoc 10m 24s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 0m 51s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 26s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 9m 18s Tests passed in hadoop-mapreduce-client-app.
        +1 mapreduce tests 1m 50s Tests passed in hadoop-mapreduce-client-core.
            52m 32s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12746157/MAPREDUCE-6433.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 98c2bc8
        hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 53s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 12s There were no new javac warning messages. +1 javadoc 10m 24s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 51s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 2m 37s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 18s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 1m 50s Tests passed in hadoop-mapreduce-client-core.     52m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12746157/MAPREDUCE-6433.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 98c2bc8 hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5895/console This message was automatically generated.
        Hide
        zxu zhihai xu added a comment -

        I uploaded a patch MAPREDUCE-6433.000.patch for review, The patch initialize MRAppMaster#recoveredJobStartTime as -1 instead of 0 and use jse.getRecoveredJobStartTime() as launch time only when jse.getRecoveredJobStartTime() is not -1.

        Show
        zxu zhihai xu added a comment - I uploaded a patch MAPREDUCE-6433 .000.patch for review, The patch initialize MRAppMaster#recoveredJobStartTime as -1 instead of 0 and use jse.getRecoveredJobStartTime() as launch time only when jse.getRecoveredJobStartTime() is not -1.
        Hide
        zxu zhihai xu added a comment -

        I uploaded a patch REPRODUCE.patch, which can reproduce this issue.
        I will upload a patch to fix this issue shortly.

        Show
        zxu zhihai xu added a comment - I uploaded a patch REPRODUCE.patch, which can reproduce this issue. I will upload a patch to fix this issue shortly.
        Hide
        zxu zhihai xu added a comment -

        Thanks for reporting this issue Allen Wittenauer! I can work on this issue.
        I looked at the code, there is only one possibility to generate negative launchTime.
        Based on the code:
        job launch time is from JobInitedEvent which is created at JobImpl.java

              JobStartEvent jse = (JobStartEvent) event;
              if (jse.getRecoveredJobStartTime() != 0) {
                job.startTime = jse.getRecoveredJobStartTime();
              } else {
                job.startTime = job.clock.getTime();
              }
        

        So the only possibility is jse.getRecoveredJobStartTime() returns negative value.
        JobStartEvent is created at MRAppMaster.java. getRecoveredJobStartTime depends on MRAppMaster#recoveredJobStartTime
        recoveredJobStartTime is initialized as 0 but it will be changed at the following code in MRAppMaster#parsePreviousJobHistory

            recoveredJobStartTime = jobInfo.getLaunchTime();
        

        It means jobInfo.getLaunchTime() may return negative value.
        jobInfo is defined in JobHistoryParser#JobInfo and the launchTime is initialized as -1, It will only be changed by handleJobInitedEvent.

              submitTime = launchTime = finishTime = -1;
        

        So if previous JobHistory file doesn't have JOB_INITED event, the issue may happen.
        Based on this, I think if the first job attempt failed to init job(JOB_INIT), we may hit this issue for the second job attempt.
        I will create a test case to reproduce this issue.

        Show
        zxu zhihai xu added a comment - Thanks for reporting this issue Allen Wittenauer ! I can work on this issue. I looked at the code, there is only one possibility to generate negative launchTime. Based on the code: job launch time is from JobInitedEvent which is created at JobImpl.java JobStartEvent jse = (JobStartEvent) event; if (jse.getRecoveredJobStartTime() != 0) { job.startTime = jse.getRecoveredJobStartTime(); } else { job.startTime = job.clock.getTime(); } So the only possibility is jse.getRecoveredJobStartTime() returns negative value. JobStartEvent is created at MRAppMaster.java. getRecoveredJobStartTime depends on MRAppMaster#recoveredJobStartTime recoveredJobStartTime is initialized as 0 but it will be changed at the following code in MRAppMaster#parsePreviousJobHistory recoveredJobStartTime = jobInfo.getLaunchTime(); It means jobInfo.getLaunchTime() may return negative value. jobInfo is defined in JobHistoryParser#JobInfo and the launchTime is initialized as -1, It will only be changed by handleJobInitedEvent. submitTime = launchTime = finishTime = -1; So if previous JobHistory file doesn't have JOB_INITED event, the issue may happen. Based on this, I think if the first job attempt failed to init job(JOB_INIT), we may hit this issue for the second job attempt. I will create a test case to reproduce this issue.
        Hide
        aw Allen Wittenauer added a comment -

        Job is completing successfully and is not an über job.

        {"type":"JOB_QUEUE_CHANGED","event":{"org.apache.hadoop.mapreduce.jobhistory.JobQueueChange":{"jobid":"job_1422313663957_17410","jobQueueName":"dev"}}}
        
        {"type":"JOB_INITED","event":{"org.apache.hadoop.mapreduce.jobhistory.JobInited":{"jobid":"job_1422313663957_17410","launchTime":-1,"totalMaps":21,"totalReduces":0,"jobStatus":"INITED","uberized":false}}}
        
        {"type":"JOB_INFO_CHANGED","event":{"org.apache.hadoop.mapreduce.jobhistory.JobInfoChange":{"jobid":"job_1422313663957_17410","submitTime":1423558926793,"launchTime":-1}}}
        
        {"type":"TASK_STARTED","event":{"org.apache.hadoop.mapreduce.jobhistory.TaskStarted":{"taskid":"task_1422313663957_17410_m_000000","taskType":"MAP","startTime":1423558939862,"splitLocations":""}}}
        
        Show
        aw Allen Wittenauer added a comment - Job is completing successfully and is not an über job. { "type" : "JOB_QUEUE_CHANGED" , "event" :{ "org.apache.hadoop.mapreduce.jobhistory.JobQueueChange" :{ "jobid" : "job_1422313663957_17410" , "jobQueueName" : "dev" }}} { "type" : "JOB_INITED" , "event" :{ "org.apache.hadoop.mapreduce.jobhistory.JobInited" :{ "jobid" : "job_1422313663957_17410" , "launchTime" :-1, "totalMaps" :21, "totalReduces" :0, "jobStatus" : "INITED" , "uberized" : false }}} { "type" : "JOB_INFO_CHANGED" , "event" :{ "org.apache.hadoop.mapreduce.jobhistory.JobInfoChange" :{ "jobid" : "job_1422313663957_17410" , "submitTime" :1423558926793, "launchTime" :-1}}} { "type" : "TASK_STARTED" , "event" :{ "org.apache.hadoop.mapreduce.jobhistory.TaskStarted" :{ "taskid" : "task_1422313663957_17410_m_000000" , "taskType" : "MAP" , "startTime" :1423558939862, "splitLocations" :""}}}

          People

          • Assignee:
            zxu zhihai xu
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development