Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change, Reviewed
    • Release Note:
      There is a typo in the event string "WORKFLOW_ID" (as "WORKLFOW_ID"). The branch-2 change will publish both event strings for compatibility with consumers, but the misspelled metric will be removed in trunk.

      Description

      JobHistoryEventHandler#processEventForTimelineServer

      tEvent.addEventInfo("WORKLFOW_ID", jse.getWorkflowId());

      should be like below.

      tEvent.addEventInfo("WORKFLOW_ID", jse.getWorkflowId()); 
      1. MAPREDUCE-6427.001.branch-2.patch
        1 kB
        Ray Chiang
      2. MAPREDUCE-6427.001.patch
        1 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Ray Chiang assigned to you as you worked on HADOOP-11854..Please check Chris Douglas comment here for more info.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Ray Chiang assigned to you as you worked on HADOOP-11854 ..Please check Chris Douglas comment here for more info.
          Hide
          rchiang Ray Chiang added a comment -

          Initial version. branch-2 and trunk versions appear identical.

          Show
          rchiang Ray Chiang added a comment - Initial version. branch-2 and trunk versions appear identical.
          Hide
          rchiang Ray Chiang added a comment -

          Submit for testing. Not sure about any potential incompatibilities.

          Show
          rchiang Ray Chiang added a comment - Submit for testing. Not sure about any potential incompatibilities.
          Hide
          rchiang Ray Chiang added a comment -

          Done. Thanks for splitting out the new JIRA.

          Show
          rchiang Ray Chiang added a comment - Done. Thanks for splitting out the new JIRA.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 42s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 32s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 6s Tests passed in hadoop-mapreduce-client-app.
              45m 59s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744341/MAPREDUCE-6427.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2e3d83f
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 42s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 32s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 6s Tests passed in hadoop-mapreduce-client-app.     45m 59s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744341/MAPREDUCE-6427.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2e3d83f Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5876/console This message was automatically generated.
          Hide
          chris.douglas Chris Douglas added a comment -

          Initial version. branch-2 and trunk versions appear identical.

          The branch-2 version should publish both the old metric and the correctly spelled label. Trunk can replace it outright. Please also add a release note.

          Show
          chris.douglas Chris Douglas added a comment - Initial version. branch-2 and trunk versions appear identical. The branch-2 version should publish both the old metric and the correctly spelled label. Trunk can replace it outright. Please also add a release note.
          Hide
          rchiang Ray Chiang added a comment -

          Got it. That makes sense.

          Show
          rchiang Ray Chiang added a comment - Got it. That makes sense.
          Hide
          rchiang Ray Chiang added a comment -

          branch-2 version of patch

          Show
          rchiang Ray Chiang added a comment - branch-2 version of patch
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 15m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 38s There were no new javac warning messages.
          +1 javadoc 9m 33s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 37s The applied patch generated 2 new checkstyle issues (total was 323, now 324).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 19s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 3s Tests passed in hadoop-mapreduce-client-app.
              46m 6s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744521/MAPREDUCE-6427.001.branch-2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / ac60483
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 15m 50s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 33s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 37s The applied patch generated 2 new checkstyle issues (total was 323, now 324). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 19s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 6s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 3s Tests passed in hadoop-mapreduce-client-app.     46m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744521/MAPREDUCE-6427.001.branch-2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ac60483 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5877/console This message was automatically generated.
          Hide
          chris.douglas Chris Douglas added a comment -

          +1 I committed this. Thanks Ray

          Show
          chris.douglas Chris Douglas added a comment - +1 I committed this. Thanks Ray
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8165 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8165/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8165 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8165/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Hide
          rchiang Ray Chiang added a comment -

          Thanks for the reviews getting to this point. And for the commit.

          Show
          rchiang Ray Chiang added a comment - Thanks for the reviews getting to this point. And for the commit.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #257 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/257/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #257 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/257/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #987 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/987/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #987 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/987/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2184/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2184 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2184/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #245 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/245/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #245 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/245/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/255/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #255 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/255/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2203/)
          MAPREDUCE-6427. Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2203 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2203/ ) MAPREDUCE-6427 . Fix typo in JobHistoryEventHandler. Contributed by Ray Chiang (cdouglas: rev f4ccdb11dca17db139a3746584e321d884651d01) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/main/java/org/apache/hadoop/mapreduce/jobhistory/JobHistoryEventHandler.java

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              brahmareddy Brahma Reddy Battula
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development