Details

    • Hadoop Flags:
      Reviewed

      Description

      In HsTasksBlock#render(), there is a loop to create a Javascript table which slows down immensely on jobs with a large number of tasks (200k or more).

      1. MAPREDUCE-6394.010.patch
        23 kB
        Ray Chiang
      2. MAPREDUCE-6394.009.patch
        23 kB
        Ray Chiang
      3. MAPREDUCE-6394.008.patch
        22 kB
        Ray Chiang
      4. MAPREDUCE-6394.007.patch
        16 kB
        Ray Chiang
      5. MAPREDUCE-6394.006.patch
        11 kB
        Ray Chiang
      6. MAPREDUCE-6394.005.patch
        10 kB
        Ray Chiang
      7. MAPREDUCE-6394.004.patch
        10 kB
        Ray Chiang
      8. MAPREDUCE-6394.003.patch
        57 kB
        Ray Chiang
      9. MAPREDUCE-6394.002.patch
        57 kB
        Ray Chiang
      10. MAPREDUCE-6394.001.patch
        55 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -

          In doing some profiling, it looks as though the bulk of the runtime occurs copying the YARN counters into the TaskReport. Since this value isn't used in the web display for the tasks page, turn it off for webapp rendering.

          For 404k map tasks, this reduces the loop from about 50 seconds down to about 5 seconds.

          Show
          rchiang Ray Chiang added a comment - In doing some profiling, it looks as though the bulk of the runtime occurs copying the YARN counters into the TaskReport. Since this value isn't used in the web display for the tasks page, turn it off for webapp rendering. For 404k map tasks, this reduces the loop from about 50 seconds down to about 5 seconds.
          Hide
          rchiang Ray Chiang added a comment -

          Initial version to remove copying YARN counters to TaskReports.

          Show
          rchiang Ray Chiang added a comment - Initial version to remove copying YARN counters to TaskReports.
          Hide
          rchiang Ray Chiang added a comment -

          Submit for testing.

          Show
          rchiang Ray Chiang added a comment - Submit for testing.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 3s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 16 new or modified test files.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 37s There were no new checkstyle issues.
          +1 whitespace 0m 7s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 1m 59s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 9m 46s Tests failed in hadoop-mapreduce-client-app.
          -1 mapreduce tests 5m 48s Tests failed in hadoop-mapreduce-client-hs.
              54m 17s  



          Reason Tests
          FindBugs module:hadoop-mapreduce-client-app
          Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks
            hadoop.mapreduce.v2.hs.TestJobHistoryParsing
            hadoop.mapreduce.v2.hs.webapp.dao.TestJobInfo
            hadoop.mapreduce.v2.hs.TestJobHistoryEntities
            hadoop.mapreduce.v2.hs.webapp.TestBlocks



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12738931/MAPREDUCE-6394.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / a7a7768
          Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 3s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 16 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 37s There were no new checkstyle issues. +1 whitespace 0m 7s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 1m 59s The patch appears to introduce 2 new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 9m 46s Tests failed in hadoop-mapreduce-client-app. -1 mapreduce tests 5m 48s Tests failed in hadoop-mapreduce-client-hs.     54m 17s   Reason Tests FindBugs module:hadoop-mapreduce-client-app Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks   hadoop.mapreduce.v2.hs.TestJobHistoryParsing   hadoop.mapreduce.v2.hs.webapp.dao.TestJobInfo   hadoop.mapreduce.v2.hs.TestJobHistoryEntities   hadoop.mapreduce.v2.hs.webapp.TestBlocks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738931/MAPREDUCE-6394.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a7a7768 Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5792/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 5s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 16 new or modified test files.
          +1 javac 7m 42s There were no new javac warning messages.
          +1 javadoc 9m 49s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 430, now 430).
          +1 whitespace 0m 7s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 2m 5s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 10m 4s Tests failed in hadoop-mapreduce-client-app.
          -1 mapreduce tests 5m 50s Tests failed in hadoop-mapreduce-client-hs.
              56m 14s  



          Reason Tests
          FindBugs module:hadoop-mapreduce-client-app
          Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.hs.webapp.TestBlocks
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12738931/MAPREDUCE-6394.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / a7a7768
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 5s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 16 new or modified test files. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 49s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 430, now 430). +1 whitespace 0m 7s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 2m 5s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 10m 4s Tests failed in hadoop-mapreduce-client-app. -1 mapreduce tests 5m 50s Tests failed in hadoop-mapreduce-client-hs.     56m 14s   Reason Tests FindBugs module:hadoop-mapreduce-client-app Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.hs.webapp.TestBlocks   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738931/MAPREDUCE-6394.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a7a7768 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5794/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix unit test issues
          Show
          rchiang Ray Chiang added a comment - Fix unit test issues
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 16 new or modified test files.
          +1 javac 7m 33s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 47s The applied patch generated 2 new checkstyle issues (total was 429, now 430).
          +1 whitespace 0m 8s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          -1 findbugs 2m 0s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings.
          -1 mapreduce tests 9m 3s Tests failed in hadoop-mapreduce-client-app.
          -1 mapreduce tests 5m 51s Tests failed in hadoop-mapreduce-client-hs.
              54m 1s  



          Reason Tests
          FindBugs module:hadoop-mapreduce-client-app
          Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks
            hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12739107/MAPREDUCE-6394.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b258b34
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 19s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 16 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 47s The applied patch generated 2 new checkstyle issues (total was 429, now 430). +1 whitespace 0m 8s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. -1 findbugs 2m 0s The patch appears to introduce 1 new Findbugs (version 3.0.0) warnings. -1 mapreduce tests 9m 3s Tests failed in hadoop-mapreduce-client-app. -1 mapreduce tests 5m 51s Tests failed in hadoop-mapreduce-client-hs.     54m 1s   Reason Tests FindBugs module:hadoop-mapreduce-client-app Failed unit tests hadoop.mapreduce.v2.app.webapp.TestAMWebServicesTasks   hadoop.mapreduce.v2.hs.webapp.TestHsWebServicesTasks Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739107/MAPREDUCE-6394.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b258b34 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5797/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Missed one accidentally deleted line. Restore it.
          Show
          rchiang Ray Chiang added a comment - Missed one accidentally deleted line. Restore it.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 40s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 16 new or modified test files.
          +1 javac 7m 48s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 429, now 429).
          +1 whitespace 0m 8s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 15s Tests passed in hadoop-mapreduce-client-app.
          +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.
              55m 9s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12739129/MAPREDUCE-6394.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 587309b
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 40s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 16 new or modified test files. +1 javac 7m 48s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 1 new checkstyle issues (total was 429, now 429). +1 whitespace 0m 8s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 1s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 15s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.     55m 9s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12739129/MAPREDUCE-6394.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 587309b Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/trunkFindbugsWarningshadoop-mapreduce-client-app.html checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-app.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5798/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: checkstyle

          File was previously over 2000 lines.

          Show
          rchiang Ray Chiang added a comment - RE: checkstyle File was previously over 2000 lines.
          Hide
          rchiang Ray Chiang added a comment -

          Found task counters section in UI. Need to figure out alternative to speedup.

          Show
          rchiang Ray Chiang added a comment - Found task counters section in UI. Need to figure out alternative to speedup.
          Hide
          rchiang Ray Chiang added a comment -

          So, from everything I can tell, the HTML/Javascript Table generated in the for loop of HsTasksBlock#render() ends up being slow for really large numbers of Tasks (e.g. taking up 102 out of 109 seconds for my 751k tasks .jhist file).

          The bulk of that time taken up in the method with the signature:

          TypeConverter#toYarn(org.apache.hadoop.mapreduce.Counters counters)

          Given the CounterGroup/Counters are pretty simple and from what I can figure out through crude profiling is that the outer loop gets called some 4.5 million times and the inner loop nets out around 37 million times. Even as fast as it may be, the sheer number of counters adds up over so many tasks.

          The only solution I can see offhand would be to defer this conversion to when the user clicks on the Counters link in the Tasks page. This would mean substituting the calls like:

          report.setCounters(TypeConverter.toYarn(getCounters()));

          in CompletedTaskAttempt (and similar places if any) and adjusting the JHS method that accesses the counters to do the parsing at link click time.

          Show
          rchiang Ray Chiang added a comment - So, from everything I can tell, the HTML/Javascript Table generated in the for loop of HsTasksBlock#render() ends up being slow for really large numbers of Tasks (e.g. taking up 102 out of 109 seconds for my 751k tasks .jhist file). The bulk of that time taken up in the method with the signature: TypeConverter#toYarn(org.apache.hadoop.mapreduce.Counters counters) Given the CounterGroup/Counters are pretty simple and from what I can figure out through crude profiling is that the outer loop gets called some 4.5 million times and the inner loop nets out around 37 million times. Even as fast as it may be, the sheer number of counters adds up over so many tasks. The only solution I can see offhand would be to defer this conversion to when the user clicks on the Counters link in the Tasks page. This would mean substituting the calls like: report.setCounters(TypeConverter.toYarn(getCounters())); in CompletedTaskAttempt (and similar places if any) and adjusting the JHS method that accesses the counters to do the parsing at link click time.
          Hide
          rchiang Ray Chiang added a comment -

          Robert Kanter, Jason Lowe any thoughts on the above suggested change? I don't think there will be any side effects outside of JHS, but this just occurred to me today so I thought I'd get feedback early.

          Show
          rchiang Ray Chiang added a comment - Robert Kanter , Jason Lowe any thoughts on the above suggested change? I don't think there will be any side effects outside of JHS, but this just occurred to me today so I thought I'd get feedback early.
          Hide
          rchiang Ray Chiang added a comment -
          • Change direct setCounters()/getCounters() to use late-binding combo setRawCounters()/getCounters() for conversion.
          • Profiling-wise for 751k tasks, the loop in HsTasksBlock#render() takes ~100-110 seconds without this fix and around 20-25 seconds with this fix.
          Show
          rchiang Ray Chiang added a comment - Change direct setCounters()/getCounters() to use late-binding combo setRawCounters()/getCounters() for conversion. Profiling-wise for 751k tasks, the loop in HsTasksBlock#render() takes ~100-110 seconds without this fix and around 20-25 seconds with this fix.
          Hide
          rchiang Ray Chiang added a comment -

          Uploading identical patch to get Jenkins run.

          Show
          rchiang Ray Chiang added a comment - Uploading identical patch to get Jenkins run.
          Hide
          rchiang Ray Chiang added a comment -

          Allen Wittenauer any idea why my last two patches haven't gotten a Jenkins run?

          Show
          rchiang Ray Chiang added a comment - Allen Wittenauer any idea why my last two patches haven't gotten a Jenkins run?
          Hide
          aw Allen Wittenauer added a comment -

          any idea why my last two patches haven't gotten a Jenkins run?

          Yes.

          Show
          aw Allen Wittenauer added a comment - any idea why my last two patches haven't gotten a Jenkins run? Yes.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 48s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 53s The applied patch generated 4 new checkstyle issues (total was 98, now 102).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 23s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 55s Tests passed in hadoop-mapreduce-client-hs.
              46m 6s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744899/MAPREDUCE-6394.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d7319de
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 53s The applied patch generated 4 new checkstyle issues (total was 98, now 102). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 23s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 59s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 55s Tests passed in hadoop-mapreduce-client-hs.     46m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744899/MAPREDUCE-6394.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d7319de checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5886/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Thanks! That's what I get for staring at it for too long.

          Show
          rchiang Ray Chiang added a comment - Thanks! That's what I get for staring at it for too long.
          Hide
          rchiang Ray Chiang added a comment -

          RE: checkstyle

          • Redundant 'public' modified matches previous declarations
          • For long lines in method names, those aren't fixed by breaking into two lines. Keeping a single line for readability.
          Show
          rchiang Ray Chiang added a comment - RE: checkstyle Redundant 'public' modified matches previous declarations For long lines in method names, those aren't fixed by breaking into two lines. Keeping a single line for readability.
          Hide
          rchiang Ray Chiang added a comment -

          Jason Lowe, this is the second JHS fix. I believe this one is also no-impact other than the speedup for jobs with large tasks. Please review at your leisure. Thanks.

          Show
          rchiang Ray Chiang added a comment - Jason Lowe , this is the second JHS fix. I believe this one is also no-impact other than the speedup for jobs with large tasks. Please review at your leisure. Thanks.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix some checkstyle issues
          • Once counters is converted, free up rawCounters
          Show
          rchiang Ray Chiang added a comment - Fix some checkstyle issues Once counters is converted, free up rawCounters
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 27s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 50s The applied patch generated 4 new checkstyle issues (total was 98, now 102).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 2m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 54s Tests passed in hadoop-mapreduce-client-hs.
              45m 43s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12745668/MAPREDUCE-6394.006.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1ba2986
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 27s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 50s The applied patch generated 4 new checkstyle issues (total was 98, now 102). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 2m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 54s Tests passed in hadoop-mapreduce-client-hs.     45m 43s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12745668/MAPREDUCE-6394.006.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1ba2986 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5892/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Exact same checkstyle stuff as before:

          RE: checkstyle

          • Redundant 'public' modified matches previous declarations
          • For long lines in method names, those aren't fixed by breaking into two lines. Keeping a single line for readability.
          Show
          rchiang Ray Chiang added a comment - Exact same checkstyle stuff as before: RE: checkstyle Redundant 'public' modified matches previous declarations For long lines in method names, those aren't fixed by breaking into two lines. Keeping a single line for readability.
          Hide
          rchiang Ray Chiang added a comment -

          RE: No new unit tests

          Should be functionally identical. Not sure if a test would be useful here.

          Show
          rchiang Ray Chiang added a comment - RE: No new unit tests Should be functionally identical. Not sure if a test would be useful here.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for the analysis and patch, Ray! Sorry for the delay in reviewing.

          General comment: If the file is going to import a particular version of Counters then I don't see the need to go changing it in many but not all places in the file. It should either remove the import and explicitly list the fully qualified classname in each instance or only list it when it's not using the one that was imported. My preference is for the latter, as this is already done for mapred vs. mapreduce and similar situations like this. It also makes the patch smaller.

          In the PBImpl files, I don't see why we need a separate boolean to track whether we've converted rawCounters into counters. If counters is null and rawCounters isn't, we should convert and null out rawCounters otherwise we shouldn't. Am I missing the case where the separate boolean is really needed to distinguish?

          Also in the PBImpl files, it looks like building the protobuf is incorrect if someone sets the raw counters and then tries to build. The build method simply checks if counters is not null to see if they should be included, but they will be null if only rawCounters was set and nobody called getCounters before calling getProto. That's an example where unit tests would have been useful, since the patch adds a new interface to those PBImpls that isn't currently covered by tests.

          Show
          jlowe Jason Lowe added a comment - Thanks for the analysis and patch, Ray! Sorry for the delay in reviewing. General comment: If the file is going to import a particular version of Counters then I don't see the need to go changing it in many but not all places in the file. It should either remove the import and explicitly list the fully qualified classname in each instance or only list it when it's not using the one that was imported. My preference is for the latter, as this is already done for mapred vs. mapreduce and similar situations like this. It also makes the patch smaller. In the PBImpl files, I don't see why we need a separate boolean to track whether we've converted rawCounters into counters. If counters is null and rawCounters isn't, we should convert and null out rawCounters otherwise we shouldn't. Am I missing the case where the separate boolean is really needed to distinguish? Also in the PBImpl files, it looks like building the protobuf is incorrect if someone sets the raw counters and then tries to build. The build method simply checks if counters is not null to see if they should be included, but they will be null if only rawCounters was set and nobody called getCounters before calling getProto. That's an example where unit tests would have been useful, since the patch adds a new interface to those PBImpls that isn't currently covered by tests.
          Hide
          rchiang Ray Chiang added a comment -

          Thanks! I'll work on those items.

          Show
          rchiang Ray Chiang added a comment - Thanks! I'll work on those items.
          Hide
          rchiang Ray Chiang added a comment -
          • Add two unit tests
          • Move rawCounter to Counter conversion into single method. Call method in appropriate places
          • Remove unneeded boolean variable
          Show
          rchiang Ray Chiang added a comment - Add two unit tests Move rawCounter to Counter conversion into single method. Call method in appropriate places Remove unneeded boolean variable
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 31s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 38s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 16s The applied patch generated 2 new checkstyle issues (total was 98, now 100).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 24s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 4s Tests passed in hadoop-mapreduce-client-app.
          +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 54s Tests passed in hadoop-mapreduce-client-hs.
              57m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12747124/MAPREDUCE-6394.007.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / ff9c13e
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 16s The applied patch generated 2 new checkstyle issues (total was 98, now 100). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 24s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 18s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 4s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 54s Tests passed in hadoop-mapreduce-client-hs.     57m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747124/MAPREDUCE-6394.007.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / ff9c13e checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5911/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: checkstyle

          Matches surrounding method definitions.

          Show
          rchiang Ray Chiang added a comment - RE: checkstyle Matches surrounding method definitions.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch, Ray!

          In the unit tests, the implicit raw counter test should be checking if the proto has counters rather than calling getCounters on the report. I think that test would have passed even with the original code, since getCounters() checks for converting raw counters. The bug I mentioned above was that setting the raw counters and then building the proto would cause the counters to be missing from the resulting protobuf. The test should verify that setting the raw counters causes the counters to appear in the generated protobuf.

          Another thing occurred to me: what should the behavior be when someone sets the counters and the raw counters? Arguably it should take the last setting, but I believe currently if one sets counters and then the raw counters it will ignore the raw counters. We probably should be calling setCounters(null) in setRawCounters and vice-versa. Would be nice to have a test to cover these behaviors as well.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch, Ray! In the unit tests, the implicit raw counter test should be checking if the proto has counters rather than calling getCounters on the report. I think that test would have passed even with the original code, since getCounters() checks for converting raw counters. The bug I mentioned above was that setting the raw counters and then building the proto would cause the counters to be missing from the resulting protobuf. The test should verify that setting the raw counters causes the counters to appear in the generated protobuf. Another thing occurred to me: what should the behavior be when someone sets the counters and the raw counters? Arguably it should take the last setting, but I believe currently if one sets counters and then the raw counters it will ignore the raw counters. We probably should be calling setCounters(null) in setRawCounters and vice-versa. Would be nice to have a test to cover these behaviors as well.
          Hide
          rchiang Ray Chiang added a comment -

          Thanks again. I'll update the tests.

          And I was assuming for now that doing setCounters would always override any setting by setRawCounters--preserving legacy behavior. I'll update the tests to cover that as well.

          Show
          rchiang Ray Chiang added a comment - Thanks again. I'll update the tests. And I was assuming for now that doing setCounters would always override any setting by setRawCounters--preserving legacy behavior. I'll update the tests to cover that as well.
          Hide
          rchiang Ray Chiang added a comment -
          • Update setCounters() and setRawCounters() to override each other. Thus, the "last set" will be used.
          • Add several more unit tests to test various orders of setting counters and/or setting raw counters.
          Show
          rchiang Ray Chiang added a comment - Update setCounters() and setRawCounters() to override each other. Thus, the "last set" will be used. Add several more unit tests to test various orders of setting counters and/or setting raw counters.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 8m 17s There were no new javac warning messages.
          +1 javadoc 10m 30s There were no new javadoc warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 30s The applied patch generated 4 new checkstyle issues (total was 98, now 100).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 26s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 16s Tests passed in hadoop-mapreduce-client-app.
          +1 mapreduce tests 0m 48s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.
              61m 40s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12747691/MAPREDUCE-6394.008.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / 69b0957
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 8m 17s There were no new javac warning messages. +1 javadoc 10m 30s There were no new javadoc warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 30s The applied patch generated 4 new checkstyle issues (total was 98, now 100). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 26s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 3m 19s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 16s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 0m 48s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 59s Tests passed in hadoop-mapreduce-client-hs.     61m 40s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747691/MAPREDUCE-6394.008.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / 69b0957 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5914/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: checkstyle

          Same errors as before. Keep matching style for now.

          Show
          rchiang Ray Chiang added a comment - RE: checkstyle Same errors as before. Keep matching style for now.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks for updating the patch. I think we're almost there.

          This should either call setCounters(null) instead of manipulating counters and the builder directly or unconditionally call builder.clearCounters, otherwise we will continue to hold onto the old counters in the builder for no good reason.

          +  public void setRawCounters(org.apache.hadoop.mapreduce.Counters rCounters) {
          +    maybeInitBuilder();
          +    if (counters == null) {
          +      builder.clearCounters();
          +    }
          +    this.counters = null;
          +    this.rawCounters = rCounters;
          +  }
          

          The unit tests should be using the assert methods from junit rather than native Java asserts, as the latter implicitly relies on the JVM being run with assertions enabled for the unit tests to function properly. Failure to do so will have every test passing whether it should or not. Running with assertions enabled should happen when running under surefire and what-not, but it's better to not have that implicit dependency. My apologies for missing that in the last review.

          Show
          jlowe Jason Lowe added a comment - Thanks for updating the patch. I think we're almost there. This should either call setCounters(null) instead of manipulating counters and the builder directly or unconditionally call builder.clearCounters, otherwise we will continue to hold onto the old counters in the builder for no good reason. + public void setRawCounters(org.apache.hadoop.mapreduce.Counters rCounters) { + maybeInitBuilder(); + if (counters == null ) { + builder.clearCounters(); + } + this .counters = null ; + this .rawCounters = rCounters; + } The unit tests should be using the assert methods from junit rather than native Java asserts, as the latter implicitly relies on the JVM being run with assertions enabled for the unit tests to function properly. Failure to do so will have every test passing whether it should or not. Running with assertions enabled should happen when running under surefire and what-not, but it's better to not have that implicit dependency. My apologies for missing that in the last review.
          Hide
          rchiang Ray Chiang added a comment -

          Okay. I was trying to figure that out after the last comment, but I couldn't quite see it. Thanks.

          Not a problem. That's what I get for relying on IntelliJ. It's very good for importing the right package for me, but not in this case where there's already a corresponding native Java class.

          Show
          rchiang Ray Chiang added a comment - Okay. I was trying to figure that out after the last comment, but I couldn't quite see it. Thanks. Not a problem. That's what I get for relying on IntelliJ. It's very good for importing the right package for me, but not in this case where there's already a corresponding native Java class.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix based on latest feedback (setCounters and junit assert* methods)
          Show
          rchiang Ray Chiang added a comment - Fix based on latest feedback (setCounters and junit assert* methods)
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 17m 36s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 19s The applied patch generated 4 new checkstyle issues (total was 98, now 100).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 5s Tests passed in hadoop-mapreduce-client-app.
          +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 55s Tests passed in hadoop-mapreduce-client-hs.
              57m 45s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748117/MAPREDUCE-6394.009.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / c5caa25
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 19s The applied patch generated 4 new checkstyle issues (total was 98, now 100). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 12s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 5s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 0m 46s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 55s Tests passed in hadoop-mapreduce-client-hs.     57m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748117/MAPREDUCE-6394.009.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / c5caa25 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5920/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Put up correctly generated patch this time.
          Show
          rchiang Ray Chiang added a comment - Put up correctly generated patch this time.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 17m 22s Findbugs (version 3.0.0) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 2 new or modified test files.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 9m 52s There were no new javadoc warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 12s The applied patch generated 4 new checkstyle issues (total was 98, now 100).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 24s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 mapreduce tests 9m 18s Tests passed in hadoop-mapreduce-client-app.
          +1 mapreduce tests 0m 47s Tests passed in hadoop-mapreduce-client-common.
          +1 mapreduce tests 5m 57s Tests passed in hadoop-mapreduce-client-hs.
              58m 11s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748121/MAPREDUCE-6394.010.patch
          Optional Tests javac unit findbugs checkstyle javadoc
          git revision trunk / 93d50b7
          checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt
          hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt
          hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 17m 22s Findbugs (version 3.0.0) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 2 new or modified test files. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 9m 52s There were no new javadoc warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 12s The applied patch generated 4 new checkstyle issues (total was 98, now 100). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 24s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 3m 17s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 9m 18s Tests passed in hadoop-mapreduce-client-app. +1 mapreduce tests 0m 47s Tests passed in hadoop-mapreduce-client-common. +1 mapreduce tests 5m 57s Tests passed in hadoop-mapreduce-client-hs.     58m 11s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748121/MAPREDUCE-6394.010.patch Optional Tests javac unit findbugs checkstyle javadoc git revision trunk / 93d50b7 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-common.txt hadoop-mapreduce-client-app test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-app.txt hadoop-mapreduce-client-common test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-common.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5921/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          RE: checkstyle

          The same four public declarations as before.

          Show
          rchiang Ray Chiang added a comment - RE: checkstyle The same four public declarations as before.
          Hide
          jlowe Jason Lowe added a comment -

          +1 for the latest patch. Committing this.

          Show
          jlowe Jason Lowe added a comment - +1 for the latest patch. Committing this.
          Hide
          jlowe Jason Lowe added a comment -

          Thanks, Ray! I committed this to trunk and branch-2.

          Show
          jlowe Jason Lowe added a comment - Thanks, Ray! I committed this to trunk and branch-2.
          Hide
          rchiang Ray Chiang added a comment -

          Excellent. Thanks for all the help!

          Show
          rchiang Ray Chiang added a comment - Excellent. Thanks for all the help!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8252 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8252/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8252 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8252/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1004 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1004/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1004 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1004/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #274 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/274/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #274 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/274/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2220/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2220/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2201/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2201/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/263/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/263/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/271/)
          MAPREDUCE-6394. Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf)

          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java
          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java
          • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/271/ ) MAPREDUCE-6394 . Speed up Task processing loop in HsTasksBlock#render(). Contributed by Ray Chiang (jlowe: rev d0e0ba8010b72f58ddede5303f2b88404263d4bf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTaskAttempt.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/CompletedTask.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskAttemptReportPBImpl.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/impl/pb/TaskReportPBImpl.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskAttemptReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/src/main/java/org/apache/hadoop/mapreduce/v2/api/records/TaskReport.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/api/records/TestTaskReport.java

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development