Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-632

Merge TestCustomOutputCommitter with TestCommandLineJobSubmission

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Modifies TestCommandLineJobSubmission to add a test for testing custom output committer and removes TestCustomOutputCommitter

      Description

      TestCommandLineJobSubmission tests job submisison with different command line options. This can be easily enhanced to test custom output committer too and we can do away with TestCustomOutputCommitter

      1. hadoop-5978.java
        4 kB
        Jothi Padmanabhan

        Activity

        Jothi Padmanabhan created issue -
        Hide
        Jothi Padmanabhan added a comment -

        Simple patch for the issue

        Show
        Jothi Padmanabhan added a comment - Simple patch for the issue
        Jothi Padmanabhan made changes -
        Field Original Value New Value
        Attachment hadoop-5978.java [ 12410119 ]
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410119/hadoop-5978.java
        against trunk revision 782083.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 10 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410119/hadoop-5978.java against trunk revision 782083. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 10 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/480/console This message is automatically generated.
        Jothi Padmanabhan made changes -
        Component/s mapred [ 12310690 ]
        Component/s test [ 12311440 ]
        Owen O'Malley made changes -
        Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
        Key HADOOP-5978 MAPREDUCE-632
        Issue Type Test [ 6 ] Bug [ 1 ]
        Component/s mapred [ 12310690 ]
        Component/s test [ 12311440 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Amareshwari Sriramadasu added a comment -

        +1 for the patch

        Show
        Amareshwari Sriramadasu added a comment - +1 for the patch
        Sharad Agarwal made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Sharad Agarwal added a comment -

        I committed this. Thanks Jothi!

        Show
        Sharad Agarwal added a comment - I committed this. Thanks Jothi!
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.21.0 [ 12314045 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/20/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #20 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/20/ )
        Jothi Padmanabhan made changes -
        Release Note Modifies TestCommandLineJobSubmission to add a test for testing custom output committer and removes TestCustomOutputCommitter
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        3d 2h 43m 1 Jothi Padmanabhan 08/Jun/09 10:46
        Patch Available Patch Available Resolved Resolved
        32d 2h 17m 1 Sharad Agarwal 10/Jul/09 13:04
        Resolved Resolved Closed Closed
        410d 9h 9m 1 Tom White 24/Aug/10 22:13

          People

          • Assignee:
            Jothi Padmanabhan
            Reporter:
            Jothi Padmanabhan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development