Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6305

AM/Task log page should be able to link back to the job

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Hadoop Flags:
      Reviewed
    1. MAPREDUCE-6305.v1.patch
      4 kB
      Siqi Li
    2. MAPREDUCE-6305.v2.patch
      8 kB
      Siqi Li
    3. MAPREDUCE-6305.v3.patch
      8 kB
      Siqi Li
    4. MAPREDUCE-6305.v4.patch
      8 kB
      Siqi Li

      Activity

      Hide
      l201514 Siqi Li added a comment -

      The latest patch can be applied to 2.6.0 branch cleanly

      Show
      l201514 Siqi Li added a comment - The latest patch can be applied to 2.6.0 branch cleanly
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk #2181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2181/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2181 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2181/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/233/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/233/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/224/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/224/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Hdfs-trunk #2163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2163/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2163 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2163/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk #965 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/965/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #965 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/965/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #235 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/235/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/CHANGES.txt
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #235 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/235/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      Hide
      hudson Hudson added a comment -

      FAILURE: Integrated in Hadoop-trunk-Commit #8042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8042/)
      MAPREDUCE-6305. AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed)

      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java
      • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java
      • hadoop-mapreduce-project/CHANGES.txt
      Show
      hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8042 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8042/ ) MAPREDUCE-6305 . AM/Task log page should be able to link back to the job. (Siqi Li via gera) (gera: rev 055cd5a9a11bd3e544a8a67c6c44b53efcb3a9ed) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsLogsPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsSingleCounterPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsCountersPage.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsView.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/main/java/org/apache/hadoop/mapreduce/v2/hs/webapp/HsController.java hadoop-mapreduce-project/CHANGES.txt
      Hide
      jira.shegalov Gera Shegalov added a comment -

      Thanks Siqi Li for the contribution. Committed to trunk and branch-2

      Show
      jira.shegalov Gera Shegalov added a comment - Thanks Siqi Li for the contribution. Committed to trunk and branch-2
      Hide
      jira.shegalov Gera Shegalov added a comment -

      +1 for v4 . Checkstyle warning is false.

      Show
      jira.shegalov Gera Shegalov added a comment - +1 for v4 . Checkstyle warning is false.
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 14m 36s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 javac 7m 30s There were no new javac warning messages.
      +1 javadoc 9m 39s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      -1 checkstyle 5m 28s The applied patch generated 1 additional checkstyle issues.
      +1 install 1m 33s mvn install still works.
      +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
      +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
      +1 mapreduce tests 6m 1s Tests passed in hadoop-mapreduce-client-hs.
          46m 28s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12727974/MAPREDUCE-6305.v4.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / cf6c8a1
      checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/artifact/patchprocess/checkstyle-result-diff.txt
      hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
      Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/testReport/
      Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 36s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 28s The applied patch generated 1 additional checkstyle issues. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 6m 1s Tests passed in hadoop-mapreduce-client-hs.     46m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727974/MAPREDUCE-6305.v4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / cf6c8a1 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/artifact/patchprocess/checkstyle-result-diff.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/testReport/ Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5446/console This message was automatically generated.
      Hide
      hadoopqa Hadoop QA added a comment -

      The patch artifact directory on has been removed!
      This is a fatal error for test-patch.sh. Aborting.
      Jenkins (node H8) information at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5445/ may provide some hints.

      Show
      hadoopqa Hadoop QA added a comment - The patch artifact directory on has been removed! This is a fatal error for test-patch.sh. Aborting. Jenkins (node H8) information at https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5445/ may provide some hints.
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 15m 5s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 javac 7m 42s There were no new javac warning messages.
      +1 javadoc 9m 47s There were no new javadoc warning messages.
      +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
      -1 checkstyle 4m 3s The applied patch generated 1 additional checkstyle issues.
      +1 install 1m 39s mvn install still works.
      +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
      +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
      +1 mapreduce tests 5m 51s Tests passed in hadoop-mapreduce-client-hs.
          45m 53s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12727749/MAPREDUCE-6305.v3.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / ac281e3
      checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/artifact/patchprocess/checkstyle-result-diff.txt
      hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
      Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/testReport/
      Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 5s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 4m 3s The applied patch generated 1 additional checkstyle issues. +1 install 1m 39s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 5m 51s Tests passed in hadoop-mapreduce-client-hs.     45m 53s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727749/MAPREDUCE-6305.v3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ac281e3 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/artifact/patchprocess/checkstyle-result-diff.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/testReport/ Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5440/console This message was automatically generated.
      Hide
      jira.shegalov Gera Shegalov added a comment -

      Thanks for the updated patch Siqi Li. Please address the checkstyle diff.

      In logs(), make sure the block with TaskAttemptId is executed only when the previous did not succeed.

      I think we should do it in another JIRA, but it would be great if the NM log page for running containers would point back to the app proxy uri.

      Show
      jira.shegalov Gera Shegalov added a comment - Thanks for the updated patch Siqi Li . Please address the checkstyle diff. In logs() , make sure the block with TaskAttemptId is executed only when the previous did not succeed. I think we should do it in another JIRA, but it would be great if the NM log page for running containers would point back to the app proxy uri.
      Hide
      l201514 Siqi Li added a comment -

      Thanks Gera Shegalov for your feedback, I have uploaded v2 that using forName method to parse JobID and TaskAttemptID. Also refactoring set active nav column method in their super class

      Show
      l201514 Siqi Li added a comment - Thanks Gera Shegalov for your feedback, I have uploaded v2 that using forName method to parse JobID and TaskAttemptID. Also refactoring set active nav column method in their super class
      Hide
      hadoopqa Hadoop QA added a comment -



      -1 overall



      Vote Subsystem Runtime Comment
      0 pre-patch 14m 31s Pre-patch trunk compilation is healthy.
      +1 @author 0m 0s The patch does not contain any @author tags.
      -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
      +1 whitespace 0m 0s The patch has no lines that end in whitespace.
      +1 javac 7m 29s There were no new javac warning messages.
      +1 javadoc 9m 34s There were no new javadoc warning messages.
      +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
      -1 checkstyle 5m 34s The applied patch generated 1 additional checkstyle issues.
      +1 install 1m 34s mvn install still works.
      +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
      +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
      +1 mapreduce tests 5m 53s Tests passed in hadoop-mapreduce-client-hs.
          46m 14s  



      Subsystem Report/Notes
      Patch URL http://issues.apache.org/jira/secure/attachment/12727719/MAPREDUCE-6305.v2.patch
      Optional Tests javadoc javac unit findbugs checkstyle
      git revision trunk / ef4e996
      checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/artifact/patchprocess/checkstyle-result-diff.txt
      hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
      Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/testReport/
      Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/console

      This message was automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 34s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 5m 34s The applied patch generated 1 additional checkstyle issues. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 5m 53s Tests passed in hadoop-mapreduce-client-hs.     46m 14s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12727719/MAPREDUCE-6305.v2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / ef4e996 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/artifact/patchprocess/checkstyle-result-diff.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/testReport/ Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5437/console This message was automatically generated.
      Hide
      jira.shegalov Gera Shegalov added a comment -

      Thanks for the pach Siqi Li.

      You don't need to use explicit regex. You can call JobID#forName and TaskAttemptID#forName instead.

      Also in HsLogsPage#preHead you need to implement the same logic as in Hs/Single/CountersPage#preHead

          commonPreHead(html);
          String tid = $(TASK_ID);
          String activeNav = "2";
          if(tid == null || tid.isEmpty()) {
            activeNav = "1";
          }
          set(initID(ACCORDION, "nav"), "{autoHeight:false, active:"+activeNav+"}");
      

      Maybe you can factor it out to a single super class or better single util method to avoid code triplication.

      Show
      jira.shegalov Gera Shegalov added a comment - Thanks for the pach Siqi Li . You don't need to use explicit regex. You can call JobID#forName and TaskAttemptID#forName instead. Also in HsLogsPage#preHead you need to implement the same logic as in Hs/Single/CountersPage#preHead commonPreHead(html); String tid = $(TASK_ID); String activeNav = "2" ; if (tid == null || tid.isEmpty()) { activeNav = "1" ; } set(initID(ACCORDION, "nav" ), "{autoHeight: false , active:" +activeNav+ "}" ); Maybe you can factor it out to a single super class or better single util method to avoid code triplication.
      Hide
      hadoopqa Hadoop QA added a comment -

      -1 overall. Here are the results of testing the latest attachment
      http://issues.apache.org/jira/secure/attachment/12709031/MAPREDUCE-6305.v1.patch
      against trunk revision 96649c3.

      +1 @author. The patch does not contain any @author tags.

      -1 tests included. The patch doesn't appear to include any new or modified tests.
      Please justify why no new tests are needed for this patch.
      Also please list what manual steps were performed to verify this patch.

      +1 javac. The applied patch does not increase the total number of javac compiler warnings.

      +1 javadoc. There were no new javadoc warning messages.

      -1 eclipse:eclipse. The patch failed to build with eclipse:eclipse.

      +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

      +1 release audit. The applied patch does not increase the total number of release audit warnings.

      +1 core tests. The patch passed unit tests in .

      Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5368//testReport/
      Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5368//console

      This message is automatically generated.

      Show
      hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12709031/MAPREDUCE-6305.v1.patch against trunk revision 96649c3. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. -1 eclipse:eclipse . The patch failed to build with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5368//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5368//console This message is automatically generated.

        People

        • Assignee:
          l201514 Siqi Li
          Reporter:
          l201514 Siqi Li
        • Votes:
          0 Vote for this issue
          Watchers:
          7 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development