Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6287

Deprecated methods in org.apache.hadoop.examples.Sort

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: examples
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      org.apache.hadoop.examples.Sort is still using deprecated methods like Path#makeQualified and DistributedCache. It is better to replace them.

        Activity

        Hide
        qwertymaniac Harsh J added a comment -

        Thanks for reporting and working on this Chao. Please attach the patch via More -> Attach Files before marking it as Patch Available, so we may review and commit!

        Please also set only the target version, as the fix version field is to be used only by committers to track actual committed branches.

        Show
        qwertymaniac Harsh J added a comment - Thanks for reporting and working on this Chao. Please attach the patch via More -> Attach Files before marking it as Patch Available, so we may review and commit! Please also set only the target version, as the fix version field is to be used only by committers to track actual committed branches.
        Hide
        qwertymaniac Harsh J added a comment -

        +1, looks good to me. Thanks Chao.

        Marking as Patch Available, will commit after jenkins run.

        Show
        qwertymaniac Harsh J added a comment - +1, looks good to me. Thanks Chao. Marking as Patch Available, will commit after jenkins run.
        Hide
        ComboZhc Chao Zhang added a comment -

        I am also manually testing the new sort example against 2.6.0 release version. Will leave a comment here if I have found any bug.

        Show
        ComboZhc Chao Zhang added a comment - I am also manually testing the new sort example against 2.6.0 release version. Will leave a comment here if I have found any bug.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12706389/MAPREDUCE-6287.patch
        against trunk revision 4cd54d9.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5326//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5326//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12706389/MAPREDUCE-6287.patch against trunk revision 4cd54d9. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5326//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5326//console This message is automatically generated.
        Hide
        ComboZhc ComboZhc added a comment -

        It seems okay in stand-alone mode.

        Show
        ComboZhc ComboZhc added a comment - It seems okay in stand-alone mode.
        Hide
        qwertymaniac Harsh J added a comment -

        Committed to branch-2 and trunk, thanks again!

        Show
        qwertymaniac Harsh J added a comment - Committed to branch-2 and trunk, thanks again!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7400 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7400/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7400 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7400/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/141/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/141/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #875 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/875/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #875 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/875/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2073 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2073/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2073 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2073/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/132/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #132 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/132/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/141/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #141 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/141/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2091 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2091/)
        MAPREDUCE-6287. Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2091 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2091/ ) MAPREDUCE-6287 . Deprecated methods in org.apache.hadoop.examples.Sort. Contributed by Chao Zhang. (harsh: rev b375d1fc936913edf4a75212559f160c41043906) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/Sort.java

          People

          • Assignee:
            ComboZhc Chao Zhang
            Reporter:
            ComboZhc Chao Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development