Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-625

Modify TestTaskLimits to improve execution time

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Modifies TestTaskLimits to do unit testing instead of running jobs using MR clusters

      Description

      With some small modifications like using a sleep job instead of PI Estimator and using localFS instead of DFS, the run time of this test can be reduced almost by half.

      1. hadoop-5993.patch
        5 kB
        Jothi Padmanabhan
      2. mapred-625.patch
        6 kB
        Jothi Padmanabhan
      3. mapreduce-625-v1.patch
        11 kB
        Jothi Padmanabhan
      4. mapreduce-625-v2.patch
        10 kB
        Jothi Padmanabhan

        Activity

        Jothi Padmanabhan created issue -
        Hide
        Jothi Padmanabhan added a comment -

        Straight forward fix

        Show
        Jothi Padmanabhan added a comment - Straight forward fix
        Jothi Padmanabhan made changes -
        Field Original Value New Value
        Attachment hadoop-5993.patch [ 12410199 ]
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12410199/hadoop-5993.patch
        against trunk revision 782881.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12410199/hadoop-5993.patch against trunk revision 782881. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/484/console This message is automatically generated.
        Hide
        Steve Loughran added a comment -

        failing test is org.apache.hadoop.hdfsproxy.TestHdfsProxy.testHdfsProxyInterface; unrelated.

        Show
        Steve Loughran added a comment - failing test is org.apache.hadoop.hdfsproxy.TestHdfsProxy.testHdfsProxyInterface; unrelated.
        Hide
        Jothi Padmanabhan added a comment -

        Actually this test can be made into a unit test. Will attach a patch soon for this

        Show
        Jothi Padmanabhan added a comment - Actually this test can be made into a unit test. Will attach a patch soon for this
        Jothi Padmanabhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Jothi Padmanabhan made changes -
        Component/s mapred [ 12310690 ]
        Owen O'Malley made changes -
        Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
        Key HADOOP-5993 MAPREDUCE-625
        Issue Type Test [ 6 ] Bug [ 1 ]
        Component/s mapred [ 12310690 ]
        Component/s test [ 12311440 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Jothi Padmanabhan added a comment -

        Made the test into a unit test.
        This required refactoring the checking of task limits in JobInProgress.initTasks into a separate method.

        Show
        Jothi Padmanabhan added a comment - Made the test into a unit test. This required refactoring the checking of task limits in JobInProgress.initTasks into a separate method.
        Jothi Padmanabhan made changes -
        Attachment mapred-625.patch [ 12411632 ]
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Jothi Padmanabhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jothi Padmanabhan added a comment -

        Code that makes TestTaskLimits as a unit test
        The Patch also re-factors initTasks of JobInProgress into separate methods so that they could be overridden and used by test cases. There is no addition or deletion of actual code, only re-factoring.

        Show
        Jothi Padmanabhan added a comment - Code that makes TestTaskLimits as a unit test The Patch also re-factors initTasks of JobInProgress into separate methods so that they could be overridden and used by test cases. There is no addition or deletion of actual code, only re-factoring.
        Jothi Padmanabhan made changes -
        Attachment mapreduce-625-v1.patch [ 12412247 ]
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Sharad Agarwal added a comment -

        In JobInProgress, instead of 'protected' as access level, package private should be sufficient.

        Show
        Sharad Agarwal added a comment - In JobInProgress, instead of 'protected' as access level, package private should be sufficient.
        Jothi Padmanabhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Jothi Padmanabhan added a comment -

        Patch that addresses the review comments

        Show
        Jothi Padmanabhan added a comment - Patch that addresses the review comments
        Jothi Padmanabhan made changes -
        Attachment mapreduce-625-v2.patch [ 12412388 ]
        Jothi Padmanabhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Jothi Padmanabhan added a comment -

        All mapred unit tests except TestJobTrackerRestart and TestJobTrackerRestartWithLostTracker passed. Both of these test failures are known issues.

        Test Patch Results:
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 3 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jothi Padmanabhan added a comment - All mapred unit tests except TestJobTrackerRestart and TestJobTrackerRestartWithLostTracker passed. Both of these test failures are known issues. Test Patch Results: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12412388/mapreduce-625-v2.patch
        against trunk revision 790543.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12412388/mapreduce-625-v2.patch against trunk revision 790543. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-vesta.apache.org/338/console This message is automatically generated.
        Hide
        Jothi Padmanabhan added a comment -

        Test failures are unrelated

        Show
        Jothi Padmanabhan added a comment - Test failures are unrelated
        Sharad Agarwal made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        Hide
        Sharad Agarwal added a comment -

        I committed this. Thanks Jothi.

        Show
        Sharad Agarwal added a comment - I committed this. Thanks Jothi.
        Sharad Agarwal made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.21.0 [ 12314045 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/ )
        Jothi Padmanabhan made changes -
        Release Note Modifies TestTaskLimits to do unit testing instead of running jobs using MR clusters
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Patch Available Patch Available Open Open
        16d 9h 22m 3 Jothi Padmanabhan 02/Jul/09 13:03
        Open Open Patch Available Patch Available
        6d 21h 56m 4 Jothi Padmanabhan 02/Jul/09 13:04
        Patch Available Patch Available Resolved Resolved
        18h 10m 1 Sharad Agarwal 03/Jul/09 07:15
        Resolved Resolved Closed Closed
        417d 14h 58m 1 Tom White 24/Aug/10 22:13

          People

          • Assignee:
            Jothi Padmanabhan
            Reporter:
            Jothi Padmanabhan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development