Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6246

DBOutputFormat.java appending extra semicolon to query which is incompatible with DB2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 3.0.0-beta1, 2.8.2
    • Component/s: mrv1, mrv2
    • Labels:
      None
    • Environment:

      OS: RHEL 5.x, RHEL 6.x, SLES 11.x
      Platform: xSeries, pSeries
      Browser: Firefox, IE
      Security Settings: No Security, Flat file, LDAP, PAM
      File System: HDFS, GPFS FPO

    • Hadoop Flags:
      Reviewed

      Description

      DBoutputformat is used for writing output of mapreduce jobs to the database and when used with db2 jdbc drivers it fails with following error

      com.ibm.db2.jcc.am.SqlSyntaxErrorException: DB2 SQL Error: SQLCODE=-104, SQLSTATE=42601, SQLERRMC=;;,COUNT) VALUES (?,?);END-OF-STATEMENT, DRIVER=4.16.53 at com.ibm.db2.jcc.am.fd.a(fd.java:739) at com.ibm.db2.jcc.am.fd.a(fd.java:60) at com.ibm.db2.jcc.am.fd.a(fd.java:127)

      In DBOutputFormat class there is constructQuery method that generates "INSERT INTO" statement with semicolon(";") at the end.

      Semicolon is ANSI SQL-92 standard character for a statement terminator but this feature is disabled(OFF) as a default settings in IBM DB2.

      Although by using -t we can turn it ON for db2. (http://www-01.ibm.com/support/knowledgecenter/SSEPGG_9.7.0/com.ibm.db2.luw.admin.cmd.doc/doc/r0010410.html?cp=SSEPGG_9.7.0%2F3-6-2-0-2). But there are some products that already built on top of this default setting (OFF) so by turning ON this feature make them error prone.

      1. MAPREDUCE-6246.002.patch
        4 kB
        ramtin
      2. MAPREDUCE-6246.003.patch
        4 kB
        ramtin
      3. MAPREDUCE-6246.004.patch
        5 kB
        Gergely Novák
      4. MAPREDUCE-6246.patch
        2 kB
        ramtin

        Activity

        Hide
        ramtinb ramtin added a comment -

        I changed the current DBOutputFormat class by checking the product name from connection object to see if it is DB2 then generates "INSERT INTO" query without semicolon(";").

        This technique is already used in DBInputFormat class for generating different "SELECT" statements for Oracle and MySQL databases.

        Show
        ramtinb ramtin added a comment - I changed the current DBOutputFormat class by checking the product name from connection object to see if it is DB2 then generates "INSERT INTO" query without semicolon(";"). This technique is already used in DBInputFormat class for generating different "SELECT" statements for Oracle and MySQL databases.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12697540/MAPREDUCE-6246.patch
        against trunk revision af08425.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5177//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5177//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12697540/MAPREDUCE-6246.patch against trunk revision af08425. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5177//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5177//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        I think a test here would be good.

        Show
        aw Allen Wittenauer added a comment - I think a test here would be good.
        Hide
        hadoopqa Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726452/MAPREDUCE-6246.002.patch
        against trunk revision 5459b24.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5412//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5412//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726452/MAPREDUCE-6246.002.patch against trunk revision 5459b24. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5412//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5412//console This message is automatically generated.
        Hide
        ramtinb ramtin added a comment -

        I found the similar issue for ORACLE in MAPREDUCE-3695 so I provided a new patch for fixing this problem for both dbs.

        Show
        ramtinb ramtin added a comment - I found the similar issue for ORACLE in MAPREDUCE-3695 so I provided a new patch for fixing this problem for both dbs.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 45s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 34s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 12s The applied patch generated 5 new checkstyle issues (total was 8, now 13).
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 1m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 1m 37s Tests passed in hadoop-mapreduce-client-core.
        +1 mapreduce tests 106m 36s Tests passed in hadoop-mapreduce-client-jobclient.
            146m 13s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12734265/MAPREDUCE-6246.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 5774f6b
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt
        whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/whitespace.txt
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/testReport/
        Java 1.7.0_55
        uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 45s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 34s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 12s The applied patch generated 5 new checkstyle issues (total was 8, now 13). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 57s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 1m 37s Tests passed in hadoop-mapreduce-client-core. +1 mapreduce tests 106m 36s Tests passed in hadoop-mapreduce-client-jobclient.     146m 13s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12734265/MAPREDUCE-6246.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 5774f6b checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-core.txt whitespace https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/whitespace.txt hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5747/console This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Thanks ramtin for the patch contribution. Latest patch LGTM. Will commit it shortly if no further comments.

        Show
        djp Junping Du added a comment - Thanks ramtin for the patch contribution. Latest patch LGTM. Will commit it shortly if no further comments.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s MAPREDUCE-6246 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue MAPREDUCE-6246
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12734265/MAPREDUCE-6246.003.patch
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7004/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s MAPREDUCE-6246 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue MAPREDUCE-6246 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12734265/MAPREDUCE-6246.003.patch Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7004/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        djp Junping Du added a comment -

        Looks like the patch doesn't apply to trunk any more. ramtin, would you rebase your patch according to latest trunk?
        Also, in your test for testORACLEConstructQuery(), I think we should get rid of "db2" name but using oracle instead. Other looks fine to me.

        Show
        djp Junping Du added a comment - Looks like the patch doesn't apply to trunk any more. ramtin , would you rebase your patch according to latest trunk? Also, in your test for testORACLEConstructQuery(), I think we should get rid of "db2" name but using oracle instead. Other looks fine to me.
        Hide
        GergelyNovak Gergely Novák added a comment -

        I did the rebase, plus added @Test annotations and did some refactor in the unit tests.

        Show
        GergelyNovak Gergely Novák added a comment - I did the rebase, plus added @Test annotations and did some refactor in the unit tests.
        Hide
        djp Junping Du added a comment -

        Thanks Gergely Novák! submit the patch to kick off Jenkins.

        Show
        djp Junping Du added a comment - Thanks Gergely Novák ! submit the patch to kick off Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        1 overall



        Vote Subsystem Runtime Comment
        0 reexec 18m 48s Docker mode activated.
        1 @author 0m 0s The patch does not contain any @author tags.
        1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 1m 46s Maven dependency ordering for branch
        1 mvninstall 15m 19s trunk passed
        1 compile 1m 41s trunk passed
        1 checkstyle 0m 30s trunk passed
        1 mvnsite 0m 55s trunk passed
        1 mvneclipse 0m 37s trunk passed
        1 findbugs 1m 15s trunk passed
        1 javadoc 0m 36s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        1 mvninstall 0m 45s the patch passed
        1 compile 1m 38s the patch passed
        1 javac 1m 38s the patch passed
        1 checkstyle 0m 27s the patch passed
        1 mvnsite 0m 48s the patch passed
        1 mvneclipse 0m 30s the patch passed
        1 whitespace 0m 0s The patch has no whitespace issues.
        1 findbugs 1m 22s the patch passed
        1 javadoc 0m 29s the patch passed
        1 unit 2m 39s hadoop-mapreduce-client-core in the patch passed.
        1 unit 105m 3s hadoop-mapreduce-client-jobclient in the patch passed.
        1 asflicense 0m 27s The patch does not generate ASF License warnings.
        156m 26s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue MAPREDUCE-6246
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875244/MAPREDUCE-6246.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 5c7abcfa1d63 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7576a68
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7019/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7019/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - 1 overall Vote Subsystem Runtime Comment 0 reexec 18m 48s Docker mode activated. 1 @author 0m 0s The patch does not contain any @author tags. 1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 1m 46s Maven dependency ordering for branch 1 mvninstall 15m 19s trunk passed 1 compile 1m 41s trunk passed 1 checkstyle 0m 30s trunk passed 1 mvnsite 0m 55s trunk passed 1 mvneclipse 0m 37s trunk passed 1 findbugs 1m 15s trunk passed 1 javadoc 0m 36s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch 1 mvninstall 0m 45s the patch passed 1 compile 1m 38s the patch passed 1 javac 1m 38s the patch passed 1 checkstyle 0m 27s the patch passed 1 mvnsite 0m 48s the patch passed 1 mvneclipse 0m 30s the patch passed 1 whitespace 0m 0s The patch has no whitespace issues. 1 findbugs 1m 22s the patch passed 1 javadoc 0m 29s the patch passed 1 unit 2m 39s hadoop-mapreduce-client-core in the patch passed. 1 unit 105m 3s hadoop-mapreduce-client-jobclient in the patch passed. 1 asflicense 0m 27s The patch does not generate ASF License warnings. 156m 26s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6246 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875244/MAPREDUCE-6246.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5c7abcfa1d63 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7576a68 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7019/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7019/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
        1 @author 0m 0s The patch does not contain any @author tags.
        1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 22s Maven dependency ordering for branch
        1 mvninstall 13m 10s trunk passed
        1 compile 1m 41s trunk passed
        1 checkstyle 0m 28s trunk passed
        1 mvnsite 0m 54s trunk passed
        1 mvneclipse 0m 34s trunk passed
        1 findbugs 1m 11s trunk passed
        1 javadoc 0m 35s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        1 mvninstall 0m 46s the patch passed
        1 compile 1m 40s the patch passed
        1 javac 1m 40s the patch passed
        1 checkstyle 0m 27s the patch passed
        1 mvnsite 0m 49s the patch passed
        1 mvneclipse 0m 29s the patch passed
        1 whitespace 0m 0s The patch has no whitespace issues.
        1 findbugs 1m 21s the patch passed
        1 javadoc 0m 29s the patch passed
        1 unit 2m 38s hadoop-mapreduce-client-core in the patch passed.
        1 unit 107m 31s hadoop-mapreduce-client-jobclient in the patch passed.
        1 asflicense 0m 26s The patch does not generate ASF License warnings.
        136m 41s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue MAPREDUCE-6246
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875244/MAPREDUCE-6246.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0e41911e4bd8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7576a68
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7020/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7020/console
        Powered by Apache Yetus 0.4.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - 1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. 1 @author 0m 0s The patch does not contain any @author tags. 1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 22s Maven dependency ordering for branch 1 mvninstall 13m 10s trunk passed 1 compile 1m 41s trunk passed 1 checkstyle 0m 28s trunk passed 1 mvnsite 0m 54s trunk passed 1 mvneclipse 0m 34s trunk passed 1 findbugs 1m 11s trunk passed 1 javadoc 0m 35s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch 1 mvninstall 0m 46s the patch passed 1 compile 1m 40s the patch passed 1 javac 1m 40s the patch passed 1 checkstyle 0m 27s the patch passed 1 mvnsite 0m 49s the patch passed 1 mvneclipse 0m 29s the patch passed 1 whitespace 0m 0s The patch has no whitespace issues. 1 findbugs 1m 21s the patch passed 1 javadoc 0m 29s the patch passed 1 unit 2m 38s hadoop-mapreduce-client-core in the patch passed. 1 unit 107m 31s hadoop-mapreduce-client-jobclient in the patch passed. 1 asflicense 0m 26s The patch does not generate ASF License warnings. 136m 41s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue MAPREDUCE-6246 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12875244/MAPREDUCE-6246.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0e41911e4bd8 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7576a68 Default Java 1.8.0_131 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7020/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/7020/console Powered by Apache Yetus 0.4.0 http://yetus.apache.org This message was automatically generated.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11976/)
        MAPREDUCE-6246. DBOutputFormat.java appending extra semicolon to query (junping_du: rev f484a6ff602d48413556a1d046670e2003c71c2e)

        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/db/DBOutputFormat.java
        • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/db/TestDBOutputFormat.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11976 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11976/ ) MAPREDUCE-6246 . DBOutputFormat.java appending extra semicolon to query (junping_du: rev f484a6ff602d48413556a1d046670e2003c71c2e) (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/db/DBOutputFormat.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/lib/db/TestDBOutputFormat.java
        Hide
        djp Junping Du added a comment -

        I have commit the patch to trunk, branch-2, branch-2.8 and branch-2.8.2. Thanks ramtin and Gergely Novák for patch contribution!

        Show
        djp Junping Du added a comment - I have commit the patch to trunk, branch-2, branch-2.8 and branch-2.8.2. Thanks ramtin and Gergely Novák for patch contribution!

          People

          • Assignee:
            GergelyNovak Gergely Novák
            Reporter:
            ramtinb ramtin
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Due:
              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 24h
              24h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development