Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6240

Hadoop client displays confusing error message

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: client
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Hadoop client often throws exception with "java.io.IOException: Cannot initialize Cluster. Please check your configuration for mapreduce.framework.name and the correspond server addresses".

      This is a misleading and generic message for any cluster initialization problem. It takes a lot of debugging hours to identify the root cause. The correct error message could resolve this problem quickly.

      In one such instance, Oozie log showed the following exception while the root cause was CNF that Hadoop client didn't return in the exception.

       JA009: Cannot initialize Cluster. Please check your configuration for mapreduce.framework.name and the correspond server addresses.
              at org.apache.oozie.action.ActionExecutor.convertExceptionHelper(ActionExecutor.java:412)
              at org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:392)
              at org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:979)
              at org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1134)
              at org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:228)
              at org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:63)
              at org.apache.oozie.command.XCommand.call(XCommand.java:281)
              at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:323)
              at org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:252)
              at org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:174)
              at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
              at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
              at java.lang.Thread.run(Thread.java:744)
      Caused by: java.io.IOException: Cannot initialize Cluster. Please check your configuration for mapreduce.framework.name and the correspond server addresses.
              at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:120)
              at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:82)
              at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:75)
              at org.apache.hadoop.mapred.JobClient.init(JobClient.java:470)
              at org.apache.hadoop.mapred.JobClient.<init>(JobClient.java:449)
              at org.apache.oozie.service.HadoopAccessorService$1.run(HadoopAccessorService.java:372)
              at org.apache.oozie.service.HadoopAccessorService$1.run(HadoopAccessorService.java:370)
              at java.security.AccessController.doPrivileged(Native Method)
              at javax.security.auth.Subject.doAs(Subject.java:415)
              at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1548)
              at org.apache.oozie.service.HadoopAccessorService.createJobClient(HadoopAccessorService.java:379)
              at org.apache.oozie.action.hadoop.JavaActionExecutor.createJobClient(JavaActionExecutor.java:1185)
              at org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:927)
       ... 10 more
      
      1. MAPREDUCE-6240.1.patch
        2 kB
        Mohammad Kamrul Islam
      2. MAPREDUCE-6240-gera.001.patch
        6 kB
        Gera Shegalov
      3. MAPREDUCE-6240-gera.001.patch
        6 kB
        Gera Shegalov
      4. MAPREDUCE-6240-gera.002.patch
        6 kB
        Gera Shegalov
      5. MAPREDUCE-6240.003.patch
        5 kB
        Gera Shegalov
      6. MAPREDUCE-6240.004.patch
        4 kB
        Gera Shegalov

        Activity

        Hide
        jira.shegalov Gera Shegalov added a comment -

        Hi Mohammad Kamrul Islam, I actually ran into this problem with my recent project, and have a fix that I could submit later today.

        Show
        jira.shegalov Gera Shegalov added a comment - Hi Mohammad Kamrul Islam , I actually ran into this problem with my recent project, and have a fix that I could submit later today.
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        I also prepared a patch as well.

        I will upload mine too. Then we can combine.

        Show
        kamrul Mohammad Kamrul Islam added a comment - I also prepared a patch as well. I will upload mine too. Then we can combine.
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        Gera Shegalov this is my patch. Please put yours. We can definitely combine both.

        Show
        kamrul Mohammad Kamrul Islam added a comment - Gera Shegalov this is my patch. Please put yours. We can definitely combine both.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Hi Mohammad Kamrul Islam, my patch is similar. It chains exceptions like this:

        java.io.IOException: Cannot initialize Cluster. Please check your configuration for mapreduce.framework.name and the correspond server addresses.
        	at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:127)
        	at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:82)
        	at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:75)
        	at org.apache.hadoop.mapreduce.TestClientProtocolProviderImpls.testClusterException(TestClientProtocolProviderImpls.java:105)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:606)
        	at junit.framework.TestCase.runTest(TestCase.java:176)
        	at junit.framework.TestCase.runBare(TestCase.java:141)
        	at junit.framework.TestResult$1.protect(TestResult.java:122)
        	at junit.framework.TestResult.runProtected(TestResult.java:142)
        	at junit.framework.TestResult.run(TestResult.java:125)
        	at junit.framework.TestCase.run(TestCase.java:129)
        	at junit.framework.TestSuite.runTest(TestSuite.java:255)
        	at junit.framework.TestSuite.run(TestSuite.java:250)
        	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84)
        	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:254)
        	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149)
        	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124)
        	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200)
        	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153)
        	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
        Caused by: java.io.IOException: Failed to use org.apache.hadoop.mapred.YarnClientProtocolProvider
        	at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:120)
        	... 22 more
        Caused by: java.lang.RuntimeException: Error in instantiating YarnClient
        	at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:140)
        	at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:122)
        	at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:112)
        	at org.apache.hadoop.mapred.YarnClientProtocolProvider.create(YarnClientProtocolProvider.java:34)
        	at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95)
        	... 22 more
        Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: fs.AbstractFileSystem.nosuchfs.impl=null: No AbstractFileSystem configured for scheme: nosuchfs
        	at org.apache.hadoop.fs.AbstractFileSystem.createFileSystem(AbstractFileSystem.java:161)
        	at org.apache.hadoop.fs.AbstractFileSystem.get(AbstractFileSystem.java:250)
        	at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:324)
        	at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:321)
        	at java.security.AccessController.doPrivileged(Native Method)
        	at javax.security.auth.Subject.doAs(Subject.java:415)
        	at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669)
        	at org.apache.hadoop.fs.FileContext.getAbstractFileSystem(FileContext.java:321)
        	at org.apache.hadoop.fs.FileContext.getFileContext(FileContext.java:438)
        	at org.apache.hadoop.fs.FileContext.getFileContext(FileContext.java:464)
        	at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:138)
        	... 26 more
        
        Show
        jira.shegalov Gera Shegalov added a comment - Hi Mohammad Kamrul Islam , my patch is similar. It chains exceptions like this: java.io.IOException: Cannot initialize Cluster. Please check your configuration for mapreduce.framework.name and the correspond server addresses. at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:127) at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:82) at org.apache.hadoop.mapreduce.Cluster.<init>(Cluster.java:75) at org.apache.hadoop.mapreduce.TestClientProtocolProviderImpls.testClusterException(TestClientProtocolProviderImpls.java:105) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at junit.framework.TestCase.runTest(TestCase.java:176) at junit.framework.TestCase.runBare(TestCase.java:141) at junit.framework.TestResult$1.protect(TestResult.java:122) at junit.framework.TestResult.runProtected(TestResult.java:142) at junit.framework.TestResult.run(TestResult.java:125) at junit.framework.TestCase.run(TestCase.java:129) at junit.framework.TestSuite.runTest(TestSuite.java:255) at junit.framework.TestSuite.run(TestSuite.java:250) at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:84) at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:254) at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:149) at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:124) at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:200) at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:153) at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103) Caused by: java.io.IOException: Failed to use org.apache.hadoop.mapred.YarnClientProtocolProvider at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:120) ... 22 more Caused by: java.lang.RuntimeException: Error in instantiating YarnClient at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:140) at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:122) at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:112) at org.apache.hadoop.mapred.YarnClientProtocolProvider.create(YarnClientProtocolProvider.java:34) at org.apache.hadoop.mapreduce.Cluster.initialize(Cluster.java:95) ... 22 more Caused by: org.apache.hadoop.fs.UnsupportedFileSystemException: fs.AbstractFileSystem.nosuchfs.impl= null : No AbstractFileSystem configured for scheme: nosuchfs at org.apache.hadoop.fs.AbstractFileSystem.createFileSystem(AbstractFileSystem.java:161) at org.apache.hadoop.fs.AbstractFileSystem.get(AbstractFileSystem.java:250) at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:324) at org.apache.hadoop.fs.FileContext$2.run(FileContext.java:321) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAs(Subject.java:415) at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1669) at org.apache.hadoop.fs.FileContext.getAbstractFileSystem(FileContext.java:321) at org.apache.hadoop.fs.FileContext.getFileContext(FileContext.java:438) at org.apache.hadoop.fs.FileContext.getFileContext(FileContext.java:464) at org.apache.hadoop.mapred.YARNRunner.<init>(YARNRunner.java:138) ... 26 more
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696338/MAPREDUCE-6240.1.patch
        against trunk revision b73e776.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696338/MAPREDUCE-6240.1.patch against trunk revision b73e776. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5150//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696345/MAPREDUCE-6240-gera.001.patch
        against trunk revision b73e776.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.conf.TestJobConf
        org.apache.hadoop.mapred.TestClusterMapReduceTestCase
        org.apache.hadoop.mapreduce.TestLargeSort
        org.apache.hadoop.mapreduce.v2.TestMRAppWithCombiner

        The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapred.TestMRIntermediateDataEncryption
        org.apache.hadoop.mapred.TestMerge
        org.apache.hadoop.mapreduce.v2.TestUberAM

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696345/MAPREDUCE-6240-gera.001.patch against trunk revision b73e776. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.conf.TestJobConf org.apache.hadoop.mapred.TestClusterMapReduceTestCase org.apache.hadoop.mapreduce.TestLargeSort org.apache.hadoop.mapreduce.v2.TestMRAppWithCombiner The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.TestMRIntermediateDataEncryption org.apache.hadoop.mapred.TestMerge org.apache.hadoop.mapreduce.v2.TestUberAM Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5151//console This message is automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        I don't think any of these failures related. Resubmitting the same patch to get another Jenkins run.

        Show
        jira.shegalov Gera Shegalov added a comment - I don't think any of these failures related. Resubmitting the same patch to get another Jenkins run.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        I also ran the tests locally, only TestJobConf MAPREDUCE-6223 failed.

        Show
        jira.shegalov Gera Shegalov added a comment - I also ran the tests locally, only TestJobConf MAPREDUCE-6223 failed.
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        Gera Shegalov Thanks for your comments.
        I also thought the similar way: not to loose the individual stack traces. But I'm not sure chaining is the best approach.
        The reason: the exceptions created in the loop are not related by "Caused by". They are all independent.

        Based on this understanding, I want to stringify all stacktraces and then append then as one error message with "either .. or ..or " pattern. It is not fully clean though.

        Do you have any suggestion?

        Show
        kamrul Mohammad Kamrul Islam added a comment - Gera Shegalov Thanks for your comments. I also thought the similar way: not to loose the individual stack traces. But I'm not sure chaining is the best approach. The reason: the exceptions created in the loop are not related by "Caused by". They are all independent. Based on this understanding, I want to stringify all stacktraces and then append then as one error message with "either .. or ..or " pattern. It is not fully clean though. Do you have any suggestion?
        Hide
        jira.shegalov Gera Shegalov added a comment -

        The intuition behind chaining is the following. We would not try provider 2 if provider 1 worked, in other words: our provider 2 failures are indirectly caused by provider 1 failures.

        Show
        jira.shegalov Gera Shegalov added a comment - The intuition behind chaining is the following. We would not try provider 2 if provider 1 worked, in other words: our provider 2 failures are indirectly caused by provider 1 failures.
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        if provider1 and provider2 both failed, the user will get only the provider 1 error. He will not get any error for provider 2 that may be resolved easily by the user.
        My understanding is : if any one provider is fine then cluster is initialized properly. This good case is handled correctly. But when all failed, we would not have full stack traces for both. In some instances, resolving the provider 2 may be easier than provider 1.
        right?

        Show
        kamrul Mohammad Kamrul Islam added a comment - if provider1 and provider2 both failed, the user will get only the provider 1 error. He will not get any error for provider 2 that may be resolved easily by the user. My understanding is : if any one provider is fine then cluster is initialized properly. This good case is handled correctly. But when all failed, we would not have full stack traces for both. In some instances, resolving the provider 2 may be easier than provider 1. right?
        Hide
        jira.shegalov Gera Shegalov added a comment -

        if provider1 and provider2 both failed, the user will get only the provider 1 error. He will not get any error for provider 2 that may be resolved easily by the user.

        Good catch, Mohammad Kamrul Islam! I was talking about my intention to chain all exceptions but had a typo. I was supposed to be:

        reason = new IOException("Failed to use " +
                      provider.getClass().getName(), rootCause);
        

        Uploading 002.

        Show
        jira.shegalov Gera Shegalov added a comment - if provider1 and provider2 both failed, the user will get only the provider 1 error. He will not get any error for provider 2 that may be resolved easily by the user. Good catch, Mohammad Kamrul Islam ! I was talking about my intention to chain all exceptions but had a typo. I was supposed to be: reason = new IOException( "Failed to use " + provider.getClass().getName(), rootCause); Uploading 002.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696556/MAPREDUCE-6240-gera.001.patch
        against trunk revision e04e8fa.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapreduce.TestLargeSort
        org.apache.hadoop.conf.TestJobConf

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696556/MAPREDUCE-6240-gera.001.patch against trunk revision e04e8fa. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapreduce.TestLargeSort org.apache.hadoop.conf.TestJobConf Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5154//console This message is automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        The intuition behind chaining is the following. We would not try provider 2 if provider 1 worked, in other words: our provider 2 failures are indirectly caused by provider 1 failures.

        Wait, this is synthetically stitching exceptions together from a retry loop? That would be very confusing to debug. Have you looked at an approach like MultipleIOException?

        There's also a spurious change to AbstractFileSystem in the latest patch.

        Show
        chris.douglas Chris Douglas added a comment - The intuition behind chaining is the following. We would not try provider 2 if provider 1 worked, in other words: our provider 2 failures are indirectly caused by provider 1 failures. Wait, this is synthetically stitching exceptions together from a retry loop? That would be very confusing to debug. Have you looked at an approach like MultipleIOException ? There's also a spurious change to AbstractFileSystem in the latest patch.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Chris Douglas, thanks for the pointer, we should use MultipleIOException for consistency. AFS change is visibility for the unit test.

        Show
        jira.shegalov Gera Shegalov added a comment - Chris Douglas , thanks for the pointer, we should use MultipleIOException for consistency. AFS change is visibility for the unit test.
        Hide
        chris.douglas Chris Douglas added a comment -

        I see. Would it be possible to construct a test that's both more direct for the fix and doesn't require a change to common? Possibly initialize two providers that throw different exceptions, then verify that both messages are in the output. Just looking at the patch so I don't know the context, but wouldn't the old code pass, also?

        Show
        chris.douglas Chris Douglas added a comment - I see. Would it be possible to construct a test that's both more direct for the fix and doesn't require a change to common? Possibly initialize two providers that throw different exceptions, then verify that both messages are in the output. Just looking at the patch so I don't know the context, but wouldn't the old code pass, also?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12696588/MAPREDUCE-6240-gera.002.patch
        against trunk revision 5f4ef2d.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 1 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.ipc.TestIPC
        org.apache.hadoop.security.token.delegation.web.TestWebDelegationToken
        org.apache.hadoop.conf.TestJobConf
        org.apache.hadoop.mapreduce.TestLargeSort

        The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:

        org.apache.hadoop.mapred.TestLazyOutput

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696588/MAPREDUCE-6240-gera.002.patch against trunk revision 5f4ef2d. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 1 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.ipc.TestIPC org.apache.hadoop.security.token.delegation.web.TestWebDelegationToken org.apache.hadoop.conf.TestJobConf org.apache.hadoop.mapreduce.TestLargeSort The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient: org.apache.hadoop.mapred.TestLazyOutput Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//artifact/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5155//console This message is automatically generated.
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        Gera Shegalov if this message "Please check your configuration for mapreduce.framework.name and the correspond server addresses." is shown, please include what is the current values of those properties. It will help users to find out if their configurations is effective.

        Show
        kamrul Mohammad Kamrul Islam added a comment - Gera Shegalov if this message "Please check your configuration for mapreduce.framework.name and the correspond server addresses." is shown, please include what is the current values of those properties. It will help users to find out if their configurations is effective.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Mohammad Kamrul Islam, this JIRA is still assigned to you. Do you have time to work on it?

        Show
        jira.shegalov Gera Shegalov added a comment - Mohammad Kamrul Islam , this JIRA is still assigned to you. Do you have time to work on it?
        Hide
        kamrul Mohammad Kamrul Islam added a comment -

        Gera Shegalov sorry for the long pause.
        I will not be available to work on this soon.
        Please feel free to take it.

        Show
        kamrul Mohammad Kamrul Islam added a comment - Gera Shegalov sorry for the long pause. I will not be available to work on this soon. Please feel free to take it.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        003 patch for review. Sorry for the delay!

        Show
        jira.shegalov Gera Shegalov added a comment - 003 patch for review. Sorry for the delay!
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 17m 3s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 43s There were no new javac warning messages.
        +1 javadoc 9m 57s There were no new javadoc warning messages.
        +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 19s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 40s mvn install still works.
        +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
        +1 findbugs 2m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 mapreduce tests 1m 47s Tests passed in hadoop-mapreduce-client-core.
        +1 mapreduce tests 100m 18s Tests passed in hadoop-mapreduce-client-jobclient.
            143m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742446/MAPREDUCE-6240.003.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / a95d39f
        hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt
        hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/testReport/
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 17m 3s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 43s There were no new javac warning messages. +1 javadoc 9m 57s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 19s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 40s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. +1 findbugs 2m 16s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 mapreduce tests 1m 47s Tests passed in hadoop-mapreduce-client-core. +1 mapreduce tests 100m 18s Tests passed in hadoop-mapreduce-client-jobclient.     143m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742446/MAPREDUCE-6240.003.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / a95d39f hadoop-mapreduce-client-core test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/artifact/patchprocess/testrun_hadoop-mapreduce-client-core.txt hadoop-mapreduce-client-jobclient test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/artifact/patchprocess/testrun_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5848/console This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        I would appreciate a review for 003 patch. /cc: Chris Douglas, Jason Lowe

        Show
        jira.shegalov Gera Shegalov added a comment - I would appreciate a review for 003 patch. /cc: Chris Douglas , Jason Lowe
        Hide
        ajithshetty Ajith S added a comment -

        Hi Gera Shegalov

        private void initialize(InetSocketAddress jobTrackAddr, Configuration conf)
        throws IOException {
        
        final List<IOException> ioExceptions = new ArrayList<IOException>();
        synchronized (frameworkLoader) {
        for (ClientProtocolProvider provider : frameworkLoader) {
        .........
        
        

        As ioExceptions as this is outside syncronized block, in multi thread env, wouldn it get reset if Thread 1 is inside synchronized block and Thread 2 enters method.?

        Show
        ajithshetty Ajith S added a comment - Hi Gera Shegalov private void initialize(InetSocketAddress jobTrackAddr, Configuration conf) throws IOException { final List<IOException> ioExceptions = new ArrayList<IOException>(); synchronized (frameworkLoader) { for (ClientProtocolProvider provider : frameworkLoader) { ......... As ioExceptions as this is outside syncronized block, in multi thread env, wouldn it get reset if Thread 1 is inside synchronized block and Thread 2 enters method.?
        Hide
        ajithshetty Ajith S added a comment -

        Got it. Please ignore my previous comment.

        Show
        ajithshetty Ajith S added a comment - Got it. Please ignore my previous comment.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks for taking a look Ajith S. Yes, it's ok since each method invocation has its own local copy.

        Show
        jira.shegalov Gera Shegalov added a comment - Thanks for taking a look Ajith S . Yes, it's ok since each method invocation has its own local copy.
        Hide
        chris.douglas Chris Douglas added a comment -

        Minor (not blocking for commit):

        • This could just add the IOException to the list instead of throw/catch
        • The message doesn't need to append t:
          +            ioExceptions.add(new IOException("Failed to initialize protocol: "
          +                + t, t));
          
        • Should this continue to catch only Exception, instead of Throwable?
        • If the cause of the exception is an IOException, this discards the caught exception? Is this a special/common case?

        It's a little odd to wrap all of this as an IOException, but I don't think it's worth adding another composite type.

        Show
        chris.douglas Chris Douglas added a comment - Minor (not blocking for commit): This could just add the IOException to the list instead of throw/catch The message doesn't need to append t : + ioExceptions.add(new IOException("Failed to initialize protocol: " + + t, t)); Should this continue to catch only Exception , instead of Throwable ? If the cause of the exception is an IOException , this discards the caught exception? Is this a special/common case? It's a little odd to wrap all of this as an IOException , but I don't think it's worth adding another composite type.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks Chris Douglas, ran out of time this week. Will take care of it next week.

        Show
        jira.shegalov Gera Shegalov added a comment - Thanks Chris Douglas , ran out of time this week. Will take care of it next week.
        Hide
        ajithshetty Ajith S added a comment -

        Hi Gera Shegalov

        Any reason why we dint just throw a IOException with all these exception added as suppressed exceptions.?

        ............
        catch (IOException e) {
                  if(generalException == null)
                  {
                    generalException = new IOException("General exception");
                  }
                  generalException.addSuppressed(e);
                }
        

        just like how java does it in a try-with-resource block

        Show
        ajithshetty Ajith S added a comment - Hi Gera Shegalov Any reason why we dint just throw a IOException with all these exception added as suppressed exceptions.? ............ catch (IOException e) { if (generalException == null ) { generalException = new IOException( "General exception" ); } generalException.addSuppressed(e); } just like how java does it in a try-with-resource block
        Hide
        chris.douglas Chris Douglas added a comment -

        Any reason why we dint just throw a IOException with all these exception added as suppressed exceptions.?

        Neat! I didn't know this was added to 1.7. I like this approach

        Show
        chris.douglas Chris Douglas added a comment - Any reason why we dint just throw a IOException with all these exception added as suppressed exceptions.? Neat! I didn't know this was added to 1.7. I like this approach
        Hide
        ajithshetty Ajith S added a comment -

        Hi Chris Douglas

        +1 of avoiding composites. So, how about refactoring it and removing this class org.apache.hadoop.io.MultipleIOException u think its a good idea.?

        Show
        ajithshetty Ajith S added a comment - Hi Chris Douglas +1 of avoiding composites. So, how about refactoring it and removing this class org.apache.hadoop.io.MultipleIOException u think its a good idea.?
        Hide
        chris.douglas Chris Douglas added a comment -

        how about refactoring it and removing this class org.apache.hadoop.io.MultipleIOException

        We'd have to audit where it's used. If there could be systems that expect and handle it, we'd have to deprecate it first, but I think it makes sense to remove it in trunk. Separate issue, of course.

        Show
        chris.douglas Chris Douglas added a comment - how about refactoring it and removing this class org.apache.hadoop.io.MultipleIOException We'd have to audit where it's used. If there could be systems that expect and handle it, we'd have to deprecate it first, but I think it makes sense to remove it in trunk. Separate issue, of course.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        +1 for 1.7 addSuppressed for trunk, but we also need a patch backportable to 2.6.1.

        Show
        jira.shegalov Gera Shegalov added a comment - +1 for 1.7 addSuppressed for trunk, but we also need a patch backportable to 2.6.1.
        Hide
        bolke Bolke de Bruin added a comment -

        Where are we on this one? We have the issue now when compiling bigtop's sqoop2 and we don't even know where to start debugging.

        Show
        bolke Bolke de Bruin added a comment - Where are we on this one? We have the issue now when compiling bigtop's sqoop2 and we don't even know where to start debugging.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 4s MAPREDUCE-6240 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12742446/MAPREDUCE-6240.003.patch
        JIRA Issue MAPREDUCE-6240
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6441/console
        Powered by Apache Yetus 0.2.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s MAPREDUCE-6240 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12742446/MAPREDUCE-6240.003.patch JIRA Issue MAPREDUCE-6240 Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6441/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        MAPREDUCE-6240.004.patch based on Ajith S's suggestions.

        Show
        jira.shegalov Gera Shegalov added a comment - MAPREDUCE-6240 .004.patch based on Ajith S 's suggestions.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 27s Maven dependency ordering for branch
        +1 mvninstall 6m 5s trunk passed
        +1 compile 1m 29s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 1m 6s trunk passed
        +1 javadoc 0m 32s trunk passed
        0 mvndep 0m 8s Maven dependency ordering for patch
        +1 mvninstall 0m 40s the patch passed
        +1 compile 1m 27s the patch passed
        +1 javac 1m 27s the patch passed
        +1 checkstyle 0m 22s the patch passed
        +1 mvnsite 0m 47s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 15s the patch passed
        +1 javadoc 0m 29s the patch passed
        -1 unit 1m 56s hadoop-mapreduce-client-core in the patch failed.
        -1 unit 143m 42s hadoop-mapreduce-client-jobclient in the patch failed.
        +1 asflicense 0m 24s The patch does not generate ASF License warnings.
        163m 50s



        Reason Tests
        Failed junit tests hadoop.mapreduce.tools.TestCLI
          hadoop.mapred.TestReduceFetch
          hadoop.mapred.TestMerge
          hadoop.mapreduce.TestMapReduceLazyOutput
          hadoop.mapred.TestMRIntermediateDataEncryption
          hadoop.mapred.TestLazyOutput
          hadoop.mapreduce.TestLargeSort
          hadoop.mapred.TestReduceFetchFromPartialMem
          hadoop.mapreduce.v2.TestMRJobsWithProfiler
          hadoop.mapreduce.lib.output.TestJobOutputCommitter
          hadoop.mapreduce.security.ssl.TestEncryptedShuffle
          hadoop.mapreduce.v2.TestMROldApiJobs
          hadoop.mapred.TestJobCleanup
          hadoop.mapreduce.v2.TestSpeculativeExecution
          hadoop.mapred.TestClusterMRNotification
          hadoop.mapreduce.security.TestUmbilicalProtocolWithJobToken
          hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities
          hadoop.mapreduce.v2.TestMRJobs
          hadoop.mapred.TestJobName
          hadoop.mapreduce.TestMRJobClient
          hadoop.mapred.TestClusterMapReduceTestCase
          hadoop.mapred.TestAuditLogger
          hadoop.mapreduce.security.TestMRCredentials
          hadoop.mapred.TestMRTimelineEventHandling
          hadoop.mapreduce.v2.TestMiniMRProxyUser
          hadoop.mapreduce.v2.TestMRJobsWithHistoryService
          hadoop.mapred.TestMiniMRClientCluster
          hadoop.mapred.TestMiniMRChildTask
          hadoop.mapreduce.TestChild
          hadoop.mapreduce.security.TestBinaryTokenFile
          hadoop.mapred.TestJobCounters
        Timed out junit tests org.apache.hadoop.mapred.TestMiniMRClasspath
          org.apache.hadoop.mapred.TestJobSysDirWithDFS
          org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers
          org.apache.hadoop.mapred.TestMROpportunisticMaps



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806867/MAPREDUCE-6240.004.patch
        JIRA Issue MAPREDUCE-6240
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 2eccc0c4d2a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / f5ff05c
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 27s Maven dependency ordering for branch +1 mvninstall 6m 5s trunk passed +1 compile 1m 29s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 32s trunk passed 0 mvndep 0m 8s Maven dependency ordering for patch +1 mvninstall 0m 40s the patch passed +1 compile 1m 27s the patch passed +1 javac 1m 27s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 47s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 29s the patch passed -1 unit 1m 56s hadoop-mapreduce-client-core in the patch failed. -1 unit 143m 42s hadoop-mapreduce-client-jobclient in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 163m 50s Reason Tests Failed junit tests hadoop.mapreduce.tools.TestCLI   hadoop.mapred.TestReduceFetch   hadoop.mapred.TestMerge   hadoop.mapreduce.TestMapReduceLazyOutput   hadoop.mapred.TestMRIntermediateDataEncryption   hadoop.mapred.TestLazyOutput   hadoop.mapreduce.TestLargeSort   hadoop.mapred.TestReduceFetchFromPartialMem   hadoop.mapreduce.v2.TestMRJobsWithProfiler   hadoop.mapreduce.lib.output.TestJobOutputCommitter   hadoop.mapreduce.security.ssl.TestEncryptedShuffle   hadoop.mapreduce.v2.TestMROldApiJobs   hadoop.mapred.TestJobCleanup   hadoop.mapreduce.v2.TestSpeculativeExecution   hadoop.mapred.TestClusterMRNotification   hadoop.mapreduce.security.TestUmbilicalProtocolWithJobToken   hadoop.mapreduce.v2.TestMRAMWithNonNormalizedCapabilities   hadoop.mapreduce.v2.TestMRJobs   hadoop.mapred.TestJobName   hadoop.mapreduce.TestMRJobClient   hadoop.mapred.TestClusterMapReduceTestCase   hadoop.mapred.TestAuditLogger   hadoop.mapreduce.security.TestMRCredentials   hadoop.mapred.TestMRTimelineEventHandling   hadoop.mapreduce.v2.TestMiniMRProxyUser   hadoop.mapreduce.v2.TestMRJobsWithHistoryService   hadoop.mapred.TestMiniMRClientCluster   hadoop.mapred.TestMiniMRChildTask   hadoop.mapreduce.TestChild   hadoop.mapreduce.security.TestBinaryTokenFile   hadoop.mapred.TestJobCounters Timed out junit tests org.apache.hadoop.mapred.TestMiniMRClasspath   org.apache.hadoop.mapred.TestJobSysDirWithDFS   org.apache.hadoop.mapred.TestMiniMRWithDFSWithDistinctUsers   org.apache.hadoop.mapred.TestMROpportunisticMaps Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12806867/MAPREDUCE-6240.004.patch JIRA Issue MAPREDUCE-6240 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 2eccc0c4d2a8 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f5ff05c Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-core.txt https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6529/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        trying a jenkins rerun

        Show
        jira.shegalov Gera Shegalov added a comment - trying a jenkins rerun
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 8m 46s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        0 mvndep 0m 28s Maven dependency ordering for branch
        +1 mvninstall 6m 10s trunk passed
        +1 compile 1m 29s trunk passed
        +1 checkstyle 0m 25s trunk passed
        +1 mvnsite 0m 51s trunk passed
        +1 mvneclipse 0m 23s trunk passed
        +1 findbugs 1m 6s trunk passed
        +1 javadoc 0m 32s trunk passed
        0 mvndep 0m 7s Maven dependency ordering for patch
        +1 mvninstall 0m 40s the patch passed
        +1 compile 1m 26s the patch passed
        +1 javac 1m 26s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 45s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 15s the patch passed
        +1 javadoc 0m 28s the patch passed
        +1 unit 1m 55s hadoop-mapreduce-client-core in the patch passed.
        -1 unit 116m 7s hadoop-mapreduce-client-jobclient in the patch failed.
        +1 asflicense 0m 27s The patch does not generate ASF License warnings.
        144m 53s



        Reason Tests
        Failed junit tests hadoop.mapred.TestMiniMRChildTask



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:2c91fd8
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807042/MAPREDUCE-6240.004.patch
        JIRA Issue MAPREDUCE-6240
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 3b042c8b8239 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 93d8a7f
        Default Java 1.8.0_91
        findbugs v3.0.0
        unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/testReport/
        modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/console
        Powered by Apache Yetus 0.3.0 http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 8m 46s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. 0 mvndep 0m 28s Maven dependency ordering for branch +1 mvninstall 6m 10s trunk passed +1 compile 1m 29s trunk passed +1 checkstyle 0m 25s trunk passed +1 mvnsite 0m 51s trunk passed +1 mvneclipse 0m 23s trunk passed +1 findbugs 1m 6s trunk passed +1 javadoc 0m 32s trunk passed 0 mvndep 0m 7s Maven dependency ordering for patch +1 mvninstall 0m 40s the patch passed +1 compile 1m 26s the patch passed +1 javac 1m 26s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 45s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 15s the patch passed +1 javadoc 0m 28s the patch passed +1 unit 1m 55s hadoop-mapreduce-client-core in the patch passed. -1 unit 116m 7s hadoop-mapreduce-client-jobclient in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 144m 53s Reason Tests Failed junit tests hadoop.mapred.TestMiniMRChildTask Subsystem Report/Notes Docker Image:yetus/hadoop:2c91fd8 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12807042/MAPREDUCE-6240.004.patch JIRA Issue MAPREDUCE-6240 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3b042c8b8239 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 93d8a7f Default Java 1.8.0_91 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt unit test logs https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapreduce-client-jobclient.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/testReport/ modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient U: hadoop-mapreduce-project/hadoop-mapreduce-client Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6530/console Powered by Apache Yetus 0.3.0 http://yetus.apache.org This message was automatically generated.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        TestMiniMRChildTask failures are tracked in MAPREDUCE-6702. Chris Douglas, Ajith S, and/or anyone watching please review.

        Show
        jira.shegalov Gera Shegalov added a comment - TestMiniMRChildTask failures are tracked in MAPREDUCE-6702 . Chris Douglas , Ajith S , and/or anyone watching please review.
        Hide
        ajithshetty Ajith S added a comment -

        Hi

        Thanks for the patch. Just a small concern, would creating IOException inside catch block will be better.? as stacktrace will indicate the line Exception object is created.?

        Show
        ajithshetty Ajith S added a comment - Hi Thanks for the patch. Just a small concern, would creating IOException inside catch block will be better.? as stacktrace will indicate the line Exception object is created.?
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 lgtm

        would creating IOException inside catch block will be better?

        The suppressed exceptions are the interesting part. The code is easier to read as-is (IMO), but either way is fine.

        Show
        chris.douglas Chris Douglas added a comment - +1 lgtm would creating IOException inside catch block will be better? The suppressed exceptions are the interesting part. The code is easier to read as-is (IMO), but either way is fine.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Thanks Ajith S and Chris Douglas for the comments.
        imo including additional exceptions only distracts from the suppressed root cause by making exception chains longer. Committing as is.

        Show
        jira.shegalov Gera Shegalov added a comment - Thanks Ajith S and Chris Douglas for the comments. imo including additional exceptions only distracts from the suppressed root cause by making exception chains longer. Committing as is.
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Actually sorry I misunderstood the comment by Ajith.

        It reminds me that I left extra wrapping for suppressed exceptions as an artifact of using MultiIOExceptions in prior patches. I would normally get rid of them, but I find adding the provider class name to the message actually quite useful.

        Show
        jira.shegalov Gera Shegalov added a comment - Actually sorry I misunderstood the comment by Ajith. It reminds me that I left extra wrapping for suppressed exceptions as an artifact of using MultiIOExceptions in prior patches. I would normally get rid of them, but I find adding the provider class name to the message actually quite useful.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #9932 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9932/)
        MAPREDUCE-6240. Hadoop client displays confusing error message. (gera) (gera: rev 0af96a1c08594c809ecb254cee4f60dd22399772)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestClientProtocolProviderImpls.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #9932 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9932/ ) MAPREDUCE-6240 . Hadoop client displays confusing error message. (gera) (gera: rev 0af96a1c08594c809ecb254cee4f60dd22399772) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/Cluster.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/TestClientProtocolProviderImpls.java
        Hide
        jira.shegalov Gera Shegalov added a comment -

        Committed to trunk and branch-2. Thanks to Mohammad Kamrul Islam for the initial patch and Chris Douglas and Ajith S for reviews.

        Show
        jira.shegalov Gera Shegalov added a comment - Committed to trunk and branch-2. Thanks to Mohammad Kamrul Islam for the initial patch and Chris Douglas and Ajith S for reviews.

          People

          • Assignee:
            jira.shegalov Gera Shegalov
            Reporter:
            kamrul Mohammad Kamrul Islam
          • Votes:
            1 Vote for this issue
            Watchers:
            15 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development