Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-6038

A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Environment:

      java version 1.8.0_11 hostspot 64-bit

    • Hadoop Flags:
      Reviewed

      Description

      As a beginner, when I learned about the basic of the mr, I found that I cound't run the WordCount2 using the command "bin/hadoop jar wc.jar WordCount2 /user/joe/wordcount/input /user/joe/wordcount/output" in the Tutorial. The VM throwed the NullPoniterException at the line 47. In the line 45, the returned default value of "conf.getBoolean" is true. That is to say when "wordcount.skip.patterns" is not set ,the WordCount2 will continue to execute getCacheFiles.. Then patternsURIs gets the null value. When the "-skip" option dosen't exist, "wordcount.skip.patterns" will not be set. Then a NullPointerException come out.
      At all, the block after the if-statement in line no. 45 shoudn't be executed when the "-skip" option dosen't exist in command. Maybe the line 45 should like that "if (conf.getBoolean("wordcount.skip.patterns", false)) { "
      .Just change the boolean.

      1. MAPREDUCE-6038.1.patch
        1.0 kB
        Tsuyoshi Ozawa
      2. MAPREDUCE-6038.2.patch
        1.0 kB
        Chris Douglas

        Activity

        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thanks for your reporting, Pei Ma. As you mentioned, it's a bug of the document. Attached a patch to fix it.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thanks for your reporting, Pei Ma . As you mentioned, it's a bug of the document. Attached a patch to fix it.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch
        against trunk revision c4c9a78.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4833//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4833//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch against trunk revision c4c9a78. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4833//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4833//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch
        Optional Tests site
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5561/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch Optional Tests site git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5561/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 patch 0m 0s The patch command could not apply the patch during dryrun.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch
        Optional Tests site
        git revision trunk / f1a152c
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5563/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12665076/MAPREDUCE-6038.1.patch Optional Tests site git revision trunk / f1a152c Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5563/console This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        Rebased patch

        Show
        chris.douglas Chris Douglas added a comment - Rebased patch
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 2m 50s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
        +1 site 2m 54s Site still builds.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            6m 8s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12731662/MAPREDUCE-6038.2.patch
        Optional Tests site
        git revision trunk / 6471d18
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5688/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 2m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 site 2m 54s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     6m 8s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731662/MAPREDUCE-6038.2.patch Optional Tests site git revision trunk / 6471d18 Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5688/console This message was automatically generated.
        Hide
        chris.douglas Chris Douglas added a comment -

        +1 I committed this. Thanks Tsuyoshi

        Show
        chris.douglas Chris Douglas added a comment - +1 I committed this. Thanks Tsuyoshi
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8126 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8126/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8126 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8126/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thanks for the commit, Chris.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thanks for the commit, Chris.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #248 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/248/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #248 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/248/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2196 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2196/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2196 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2196/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2177 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2177/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md hadoop-mapreduce-project/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/)
        MAPREDUCE-6038. A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md
        • hadoop-mapreduce-project/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #238 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/238/ ) MAPREDUCE-6038 . A boolean may be set error in the Word Count v2.0 in MapReduce Tutorial. Contributed by Tsuyoshi Ozawa (cdouglas: rev 7e2fe8c9f28ec6fff32741ebf1bdbf47729d9eaf) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/markdown/MapReduceTutorial.md hadoop-mapreduce-project/CHANGES.txt

          People

          • Assignee:
            ozawa Tsuyoshi Ozawa
            Reporter:
            myfly537 Pei Ma
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development