Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5972

Fix typo 'programatically' in job.xml (and a few other places)

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.2.0
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      Fix a typo. If a configuration is set through program, the source of the configuration is set to 'programmatically' instead of 'programatically' now.

      Description

      In job.xml, there's a typo 'programatically' as the below if a property is set through program.

      <property>
        <name>mapreduce.job.map.class</name>
        <value>org.apache.hadoop.examples.WordCount$TokenizerMapper</value>
        <source>programatically</source>
      </property>
      

      should be 'programmatically'.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1866/)
        MAPREDUCE-5972. Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536)

        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1866 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1866/ ) MAPREDUCE-5972 . Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm hadoop-mapreduce-project/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1891 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1891/)
        MAPREDUCE-5972. Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536)

        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
        • hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1891 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1891/ ) MAPREDUCE-5972 . Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536) hadoop-mapreduce-project/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #675 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/675/)
        MAPREDUCE-5972. Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
        • hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js
        • hadoop-mapreduce-project/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #675 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/675/ ) MAPREDUCE-5972 . Fix typo 'programatically' in job.xml (and a few other places) (Akira AJISAKA via aw) (aw: rev d989ac04449dc33da5e2c32a7f24d59cc92de536) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java hadoop-tools/hadoop-sls/src/main/html/js/thirdparty/jquery.js hadoop-mapreduce-project/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfServlet.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs/src/site/apt/HistoryServerRest.apt.vm hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewer.java hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/site/apt/MapredAppMasterRest.apt.vm
        Hide
        aw Allen Wittenauer added a comment -

        +1. Committed to trunk!

        Thanks!

        Show
        aw Allen Wittenauer added a comment - +1. Committed to trunk! Thanks!
        Hide
        ajisakaa Akira Ajisaka added a comment -

        job.xml is generated automatically by MapReduce framework, so users don't set the parameter 'programmatically'. However, users will affected if

        1. they are using a script to parse job.xml and search 'programatically'
        2. they are using a program to verify the resource of the configuration
          I'll mark this issue as incompatible change and moving target version to 3.0.0.
        Show
        ajisakaa Akira Ajisaka added a comment - job.xml is generated automatically by MapReduce framework, so users don't set the parameter 'programmatically'. However, users will affected if they are using a script to parse job.xml and search 'programatically' they are using a program to verify the resource of the configuration I'll mark this issue as incompatible change and moving target version to 3.0.0.
        Hide
        aw Allen Wittenauer added a comment -

        IMO, I'm a bit uncomfortable about this going into branch-2 since it changes a typo in a parameter.

        But we should fix it nonetheless.

        Show
        aw Allen Wittenauer added a comment - IMO, I'm a bit uncomfortable about this going into branch-2 since it changes a typo in a parameter. But we should fix it nonetheless.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12656108/MAPREDUCE-5972.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-sls:

        org.apache.hadoop.ipc.TestIPC
        org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
        org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
        org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4743//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4743//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656108/MAPREDUCE-5972.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-tools/hadoop-sls: org.apache.hadoop.ipc.TestIPC org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem org.apache.hadoop.fs.TestSymlinkLocalFSFileContext org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.tools.TestDFSAdminWithHA +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4743//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4743//console This message is automatically generated.

          People

          • Assignee:
            ajisakaa Akira Ajisaka
            Reporter:
            ajisakaa Akira Ajisaka
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development