Details
-
Improvement
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
2.4.1
-
None
-
Reviewed
Description
MR task profiling can be enabled with a simple switch mapreduce.task.profile=true. We can analogously have yarn.app.mapreduce.am.profile for MR-AM
Attachments
Attachments
- MAPREDUCE-5970.v01.patch
- 4 kB
- Gera Shegalov
- MAPREDUCE-5970.v02.patch
- 7 kB
- Gera Shegalov
- MAPREDUCE-5970.v03.patch
- 7 kB
- Gera Shegalov
Activity
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12655973/MAPREDUCE-5970.v01.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. There were no new javadoc warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4739//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4739//console
This message is automatically generated.
Thanks for the patch, Gera! Looks good overall. It should be straightforward to add a test case to TestYARNRunner to verify the new property behaves as expected, see TestYARNRunner.testAMAdminCommandOpts as an example.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12655973/MAPREDUCE-5970.v01.patch
against trunk revision 3affad9.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 2 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. There were no new javadoc warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.web.TestWebHDFSXAttr
org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4935//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4935//console
This message is automatically generated.
Thanks jlowe for review. v02 adds negative and positive tests per your suggestion.
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12673945/MAPREDUCE-5970.v02.patch
against trunk revision 180afa2.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. There were no new javadoc warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
-1 release audit. The applied patch generated 1 release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:
org.apache.hadoop.mapred.pipes.TestPipeApplication
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//artifact/patchprocess/patchReleaseAuditProblems.txt
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4948//console
This message is automatically generated.
Thanks for updating the patch, Gera! The audit and unit test failures are unrelated. Patch looks good except for one minor thing which I missed in the initial review. I noticed that tasks add their profile params as the last parameter before the classname on the JVM command-line, but YARNRunner is adding the AM profile options as the first thing. For consistency in case there's overlap between the profile params and admin/user options these should be last to match the existing behavior for tasks.
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12674653/MAPREDUCE-5970.v03.patch
against trunk revision cc93e7e.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. There were no new javadoc warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4961//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4961//console
This message is automatically generated.
Thanks, Gera! I committed this to trunk, branch-2, and branch-2.6.
FAILURE: Integrated in Hadoop-trunk-Commit #6266 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6266/)
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
FAILURE: Integrated in Hadoop-Yarn-trunk #713 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/713/)
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
FAILURE: Integrated in Hadoop-Hdfs-trunk #1903 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1903/)
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
- hadoop-mapreduce-project/CHANGES.txt
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1928 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1928/)
MAPREDUCE-5970. Provide a boolean switch to enable MR-AM profiling. Contributed by Gera Shegalov (jlowe: rev f19771a24c2f90982cf6dec35889836a6146c968)
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/MRJobConfig.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/JobConf.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapred/TestYARNRunner.java
- hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/main/java/org/apache/hadoop/mapred/YARNRunner.java
- hadoop-mapreduce-project/CHANGES.txt
v01 patch for review.