Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.0
    • Fix Version/s: 2.5.0
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:

      Description

      Now that we have the YARN HistoryServer, perhaps we should move HistoryServerRest.apt.vm and MapRedAppMasterRest.apt.vm into the MapReduce section where it really belongs?

      1. MAPREDUCE-5874.3.patch
        326 kB
        Tsuyoshi Ozawa
      2. MAPREDUCE-5874.2.patch
        326 kB
        Tsuyoshi Ozawa
      3. YARN-1999.1.patch
        246 kB
        Tsuyoshi Ozawa

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          6h 51m 1 Tsuyoshi Ozawa 30/Apr/14 09:59
          Patch Available Patch Available Resolved Resolved
          16d 8h 12m 1 Ravi Prakash 16/May/14 18:11
          Resolved Resolved Closed Closed
          90d 12h 36m 1 Karthik Kambatla (Inactive) 15/Aug/14 06:48
          Karthik Kambatla (Inactive) made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Ravi Prakash made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 2.5.0 [ 12326265 ]
          Resolution Fixed [ 1 ]
          Hide
          Ravi Prakash added a comment -

          I've committed to trunk and branch-2

          Show
          Ravi Prakash added a comment - I've committed to trunk and branch-2
          Hide
          Ravi Prakash added a comment -

          I did run mvn site prior to staging. The problem was that I was using maven 3.1.1. Switching to maven 3.2.1 fixed the issue.

          I'm +1 on this change. I will commit it shortly. Thanks a lot Tsyoshi and Akira!

          Show
          Ravi Prakash added a comment - I did run mvn site prior to staging. The problem was that I was using maven 3.1.1. Switching to maven 3.2.1 fixed the issue. I'm +1 on this change. I will commit it shortly. Thanks a lot Tsyoshi and Akira!
          Hide
          Akira AJISAKA added a comment -

          Before running "mvn site:stage", it is needed to run "mvn site".
          I can run the following command successfully:

          $ mvn site; mvn site:stage -DstagingDirectory=/path/to/dir/
          
          Show
          Akira AJISAKA added a comment - Before running "mvn site:stage", it is needed to run "mvn site". I can run the following command successfully: $ mvn site; mvn site:stage -DstagingDirectory=/path/to/dir/
          Hide
          Ravi Prakash added a comment -

          Were you able to run mvn site:stage ? Mine failed with this error

          [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:stage (default-cli) on project hadoop-main: Execution default-cli of goal org.apache.maven.plugins:maven-site-plugin:3.3:stage failed: A required class was missing while executing org.apache.maven.plugins:maven-site-plugin:3.3:stage: org/apache/commons/lang/StringUtils
          
          Show
          Ravi Prakash added a comment - Were you able to run mvn site:stage ? Mine failed with this error [ERROR] Failed to execute goal org.apache.maven.plugins:maven-site-plugin:3.3:stage ( default -cli) on project hadoop-main: Execution default -cli of goal org.apache.maven.plugins:maven-site-plugin:3.3:stage failed: A required class was missing while executing org.apache.maven.plugins:maven-site-plugin:3.3:stage: org/apache/commons/lang/StringUtils
          Hide
          Akira AJISAKA added a comment -

          +1 (non-binding)

          Show
          Akira AJISAKA added a comment - +1 (non-binding)
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12644468/MAPREDUCE-5874.3.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4598//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4598//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12644468/MAPREDUCE-5874.3.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4598//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4598//console This message is automatically generated.
          Tsuyoshi Ozawa made changes -
          Attachment MAPREDUCE-5874.3.patch [ 12644468 ]
          Hide
          Tsuyoshi Ozawa added a comment -

          Thanks for your suggestion, Akira. Removed a link to top page from both docs.

          Show
          Tsuyoshi Ozawa added a comment - Thanks for your suggestion, Akira. Removed a link to top page from both docs.
          Hide
          Akira AJISAKA added a comment -

          Thanks Tsuyoshi Ozawa for updating the patch.
          Would you remove the "Go Back" links in the both documents in addition? Since index.html does not exist in the both MapReduce projects, the links become dead.

            \[ {{{./index.html}Go Back}} \]
          

          I'm +1 (non-binding) after that is addressed.

          Show
          Akira AJISAKA added a comment - Thanks Tsuyoshi Ozawa for updating the patch. Would you remove the "Go Back" links in the both documents in addition? Since index.html does not exist in the both MapReduce projects, the links become dead. \[ {{{./index.html}Go Back}} \] I'm +1 (non-binding) after that is addressed.
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12643047/MAPREDUCE-5874.2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4576//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4576//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12643047/MAPREDUCE-5874.2.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4576//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4576//console This message is automatically generated.
          Hide
          Tsuyoshi Ozawa added a comment -

          Thanks for your review, Akira and Zhijie. Updated a patch as follows:

          • Changed the section name from "History Server" to "MR History Server"
          • Removed dead links from YARN REST APIs' section
          • Updated a sentence Akira pointed out
          • Moved HistoryServerRest.apt.vm correctly
          Show
          Tsuyoshi Ozawa added a comment - Thanks for your review, Akira and Zhijie. Updated a patch as follows: Changed the section name from "History Server" to "MR History Server" Removed dead links from YARN REST APIs' section Updated a sentence Akira pointed out Moved HistoryServerRest.apt.vm correctly
          Tsuyoshi Ozawa made changes -
          Attachment MAPREDUCE-5874.2.patch [ 12643047 ]
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12642614/YARN-1999.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4575//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4575//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642614/YARN-1999.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4575//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4575//console This message is automatically generated.
          Hide
          Zhijie Shen added a comment -

          or "MR History Server" as the section header.

          Show
          Zhijie Shen added a comment - or "MR History Server" as the section header.
          Hide
          Zhijie Shen added a comment -

          +1 for reorganizing the web pages. For clarity, maybe it's better to say "Job History Server" instead?

          Move the ticket to MR

          Show
          Zhijie Shen added a comment - +1 for reorganizing the web pages. For clarity, maybe it's better to say "Job History Server" instead? Move the ticket to MR
          Zhijie Shen made changes -
          Project Hadoop YARN [ 12313722 ] Hadoop Map/Reduce [ 12310941 ]
          Key YARN-1999 MAPREDUCE-5874
          Affects Version/s 2.4.0 [ 12326141 ]
          Affects Version/s 2.4.0 [ 12326142 ]
          Target Version/s 2.5.0 [ 12326262 ] 2.5.0 [ 12326265 ]
          Component/s documentation [ 12312910 ]
          Component/s documentation [ 12320410 ]
          Zhijie Shen made changes -
          Link This issue is duplicated by YARN-1995 [ YARN-1995 ]
          Hide
          Akira AJISAKA added a comment -

          I'm also +1 (non-binding) for the change, and thanks Tsuyoshi Ozawa for taking this issue.
          Here are three comments:

          • HistoryServerRest.apt.vm looks deleted. You should git add the file and then create a patch.
          • Please remove the dead links from YARN REST APIs section in site.xml.
          • When moving HistoryServerRest.apt.vm to MapReduce REST APIs section, it would be better to change the sentence
            -  The history server REST API's allow the user to get status on finished applications. Currently it only supports MapReduce and provides information on finished jobs.
            

            like

            The history server REST API's allow the user to get status on finished MapReduce jobs.
            

            because the document itself is now MapReduce-specific.

          Show
          Akira AJISAKA added a comment - I'm also +1 (non-binding) for the change, and thanks Tsuyoshi Ozawa for taking this issue. Here are three comments: HistoryServerRest.apt.vm looks deleted. You should git add the file and then create a patch. Please remove the dead links from YARN REST APIs section in site.xml. When moving HistoryServerRest.apt.vm to MapReduce REST APIs section, it would be better to change the sentence - The history server REST API's allow the user to get status on finished applications. Currently it only supports MapReduce and provides information on finished jobs. like The history server REST API's allow the user to get status on finished MapReduce jobs. because the document itself is now MapReduce-specific.
          Tsuyoshi Ozawa made changes -
          Description Now that we have the YARN HistoryServer, perhaps we should move HistoryServerRest.apt.vm into the MapReduce section where it really belongs? Now that we have the YARN HistoryServer, perhaps we should move HistoryServerRest.apt.vm and MapRedAppMasterRest.apt.vm into the MapReduce section where it really belongs?
          Tsuyoshi Ozawa made changes -
          Summary Move HistoryServerRest.apt.vm into the Mapreduce section Creating MapReduce REST API section
          Hide
          Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12642614/YARN-1999.1.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3663//testReport/
          Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3663//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642614/YARN-1999.1.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3663//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3663//console This message is automatically generated.
          Tsuyoshi Ozawa made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Assignee Tsuyoshi OZAWA [ ozawa ]
          Tsuyoshi Ozawa made changes -
          Attachment YARN-1999.1.patch [ 12642614 ]
          Hide
          Tsuyoshi Ozawa added a comment -

          Created MapReduce API section and moved MapRedAppMasterRest into hadoop-mapreduce-client-core and HistoryServerRest into hadoop-mapreduce-client-fs.

          Show
          Tsuyoshi Ozawa added a comment - Created MapReduce API section and moved MapRedAppMasterRest into hadoop-mapreduce-client-core and HistoryServerRest into hadoop-mapreduce-client-fs.
          Hide
          Tsuyoshi Ozawa added a comment -

          +1 for the change(non-binding).
          IMO, we should create MapReduce API section and MapredAppMasterRest.apt.vm should be also moved into the section.

          Show
          Tsuyoshi Ozawa added a comment - +1 for the change(non-binding). IMO, we should create MapReduce API section and MapredAppMasterRest.apt.vm should be also moved into the section.
          Ravi Prakash made changes -
          Component/s documentation [ 12320410 ]
          Ravi Prakash made changes -
          Target Version/s 2.5.0 [ 12326262 ]
          Ravi Prakash made changes -
          Field Original Value New Value
          Affects Version/s 2.4.0 [ 12326142 ]
          Ravi Prakash created issue -

            People

            • Assignee:
              Tsuyoshi Ozawa
              Reporter:
              Ravi Prakash
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development