Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5812

Make job context available to OutputCommitter.isRecoverySupported()

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.0
    • Fix Version/s: 2.5.0
    • Component/s: mr-am
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Background
      ==========
      The system like Hive provides its version of OutputCommitter. The custom implementation of isRecoverySupported() requires task context. From taskContext:getConfiguration(), hive checks if hive-defined specific property is set or not. Based on the property value, it returns true or false. However, in the current OutputCommitter:isRecoverySupported(), there is no way of getting task config. As a result, user can't turn on/off the MRAM recovery feature.

      Proposed resolution:
      ===============
      1. Pass Task Context into isRecoverySupported() method.
      Pros: Easy and clean
      Cons: Possible backward compatibility issue due to aPI changes. (Is it true?)

      2. Call outputCommitter.setupTask(taskContext) from MRAM: The new OutputCommitter will store the context in the class level variable and use it from isRecoverySupported()

      Props: No API changes. No backward compatibility issue. This call can be made from MRAppMaster.getOutputCommitter() method for old API case.
      Cons: Might not be very clean solution due to class level variable.

      Please give your comments.

        Attachments

        1. MAPREDUCE-5812.1.patch
          13 kB
          Mohammad Kamrul Islam
        2. MAPREDUCE-5812.2.patch
          16 kB
          Mohammad Kamrul Islam
        3. MAPREDUCE-5812.3.patch
          15 kB
          Mohammad Kamrul Islam
        4. MAPREDUCE-5812.4.patch
          18 kB
          Mohammad Kamrul Islam
        5. MAPREDUCE-5812.5.patch
          19 kB
          Mohammad Kamrul Islam
        6. MAPREDUCE-5812.6.patch
          20 kB
          Mohammad Kamrul Islam
        7. MAPREDUCE-5812.7.patch
          22 kB
          Mohammad Kamrul Islam

          Issue Links

            Activity

              People

              • Assignee:
                kamrul Mohammad Kamrul Islam
                Reporter:
                kamrul Mohammad Kamrul Islam
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: