Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-5747

Potential null pointer deference in HsTasksBlock#render()

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Tags:
      Newbie

      Description

      At line 140:

              } else {
                ta = new TaskAttemptInfo(successful, type, false);
      

      There is no check for type against null.
      TaskAttemptInfo ctor deferences type:

        public TaskAttemptInfo(TaskAttempt ta, TaskType type, Boolean isRunning) {
          final TaskAttemptReport report = ta.getReport();
          this.type = type.toString();
      

        Activity

        Hide
        Rahul Palamuttam added a comment -

        TaskAttemptInfo has a constructor that does not require a TaskType variable.
        If the type variable is null then use this constructor instead.

        I am fairly new here so any help is appreciated!

        Show
        Rahul Palamuttam added a comment - TaskAttemptInfo has a constructor that does not require a TaskType variable. If the type variable is null then use this constructor instead. I am fairly new here so any help is appreciated!
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch
        against trunk revision 4baca31.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4973//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4973//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch against trunk revision 4baca31. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4973//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4973//console This message is automatically generated.
        Hide
        Rahul Palamuttam added a comment -

        Waiting for review.

        Also is there need for a test on this patch?
        I don't see the TestHsTasksBlock.java file in the test directory.

        Show
        Rahul Palamuttam added a comment - Waiting for review. Also is there need for a test on this patch? I don't see the TestHsTasksBlock.java file in the test directory.
        Hide
        Ted Yu added a comment -

        See TestBlocks which has HsTasksBlockForTest

        Thanks

        Show
        Ted Yu added a comment - See TestBlocks which has HsTasksBlockForTest Thanks
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 31s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 29s There were no new javac warning messages.
        +1 javadoc 9m 32s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 26s The applied patch generated 2 new checkstyle issues (total was 10, now 11).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 mapreduce tests 5m 43s Tests passed in hadoop-mapreduce-client-hs.
            40m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / e8d0ee5
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 31s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 32s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 26s The applied patch generated 2 new checkstyle issues (total was 10, now 11). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 5m 43s Tests passed in hadoop-mapreduce-client-hs.     40m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / e8d0ee5 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5620/console This message was automatically generated.
        Hide
        Devaraj K added a comment -

        Thanks Rahul Palamuttam for the patch, can you have a look into the checkstyle issues?

        Show
        Devaraj K added a comment - Thanks Rahul Palamuttam for the patch, can you have a look into the checkstyle issues?
        Hide
        Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 33s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 32s There were no new javac warning messages.
        +1 javadoc 9m 38s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 0m 27s The applied patch generated 2 new checkstyle issues (total was 10, now 11).
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 34s mvn install still works.
        +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
        +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
        +1 mapreduce tests 5m 42s Tests passed in hadoop-mapreduce-client-hs.
            41m 7s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 92c38e4
        checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt
        hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt
        Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/console

        This message was automatically generated.

        Show
        Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 33s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 32s There were no new javac warning messages. +1 javadoc 9m 38s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 27s The applied patch generated 2 new checkstyle issues (total was 10, now 11). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 42s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 mapreduce tests 5m 42s Tests passed in hadoop-mapreduce-client-hs.     41m 7s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12676205/MAPREDUCE-5747-1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 92c38e4 checkstyle https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/artifact/patchprocess/diffcheckstylehadoop-mapreduce-client-hs.txt hadoop-mapreduce-client-hs test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/artifact/patchprocess/testrun_hadoop-mapreduce-client-hs.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5726/console This message was automatically generated.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:

              Development