[MAPREDUCE-5660] Log info about possible thrashing (when using memory-based scheduling in Capacity Scheduler) is not printed

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.2.1
• Fix Version/s: 1.3.0
• Component/s: capacity-sched, mrv1, tasktracker
• Hadoop Flags: Reviewed
• Assignee: Adam Kawa
• Reporter: Adam Kawa
• Created: 01/Dec/13 14:09
• Updated: 21/Mar/15 21:08
• Resolved: 21/Mar/15 21:08

Description

There is a tiny, but confusing when troubleshooting, bug in TaskTracker code:

if (totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT) {
  LOG.info("totalMemoryAllottedForTasks > totalPhysicalMemoryOnTT."
      + " Thrashing might happen.");
} else if (totalMemoryAllottedForTasks > totalVirtualMemoryOnTT) {
  LOG.info("totalMemoryAllottedForTasks > totalVirtualMemoryOnTT."
      + " Thrashing might happen.");
}

totalMemoryAllottedForTasks is calculated in megabytes, while totalPhysicalMemoryOnTT (and totalVirtualMemoryOnTT) is calculated in bytes. totalMemoryAllottedForTasks should be converted to bytes for a correct comparison.