Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.1.0-beta
    • Fix Version/s: 2.3.0
    • Component/s: build
    • Labels:

      Description

      There is a missing dependencies in the mr-client pom.xml that is exposed when running a mvn-rpmbuild against system dependencies. Regular mvn build bypasses the issue via its default classpath. patch provided by pmackinn@redhat.com

      1. HADOOP-9610.patch
        0.6 kB
        Timothy St. Clair
      2. HADOOP-2.2.0-9610.patch
        1 kB
        Robert Rati

        Issue Links

          Activity

          Timothy St. Clair created issue -
          Hide
          Timothy St. Clair added a comment -

          Update which calls out the commons-collection dependency.

          Show
          Timothy St. Clair added a comment - Update which calls out the commons-collection dependency.
          Timothy St. Clair made changes -
          Field Original Value New Value
          Attachment HADOOP-9610.patch [ 12585452 ]
          Timothy St. Clair made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585452/HADOOP-9610.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2588//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2588//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585452/HADOOP-9610.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2588//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2588//console This message is automatically generated.
          Hide
          Timothy St. Clair added a comment -

          This is ready for review.

          Show
          Timothy St. Clair added a comment - This is ready for review.
          Timothy St. Clair made changes -
          Description There is a missing dependencies in the mr-client pom.xml that is exposed when running a mvn-rpmbuild against system dependencies. Regular mvn build bypasses the issue via its default classpath. There is a missing dependencies in the mr-client pom.xml that is exposed when running a mvn-rpmbuild against system dependencies. Regular mvn build bypasses the issue via its default classpath. patch provided by pmackinn@redhat.com
          Hide
          Timothy St. Clair added a comment -

          I figured I would ping this again as it's a very simple mod for review.

          Show
          Timothy St. Clair added a comment - I figured I would ping this again as it's a very simple mod for review.
          Hide
          Vinod Kumar Vavilapalli added a comment -

          This should have been a MR JIRA. Please create mapreduce tickets at https://issues.apache.org/jira/browse/MAPREDUCE. Moving this myself for now..

          Show
          Vinod Kumar Vavilapalli added a comment - This should have been a MR JIRA. Please create mapreduce tickets at https://issues.apache.org/jira/browse/MAPREDUCE . Moving this myself for now..
          Vinod Kumar Vavilapalli made changes -
          Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
          Key HADOOP-9610 MAPREDUCE-5431
          Affects Version/s 3.0.0 [ 12320355 ]
          Affects Version/s 2.1.0-beta [ 12324032 ]
          Affects Version/s 3.0.0 [ 12320357 ]
          Affects Version/s 2.1.0-beta [ 12324030 ]
          Component/s build [ 12312909 ]
          Component/s build [ 12311543 ]
          Hide
          Vinod Kumar Vavilapalli added a comment -

          Also, does 'pmackinn@redhat.com' have an Apache JIRA account? Have to assign this ticket to him. Or if mutually agreed, you can assign it to yourselves.

          Now that admin stuff is out of the way, can you explain a little more on "exposed when running a mvn-rpmbuild against system dependencies". Harmless patch it is, but I'd like to understand what it is fixing. Thanks!

          Show
          Vinod Kumar Vavilapalli added a comment - Also, does 'pmackinn@redhat.com' have an Apache JIRA account? Have to assign this ticket to him. Or if mutually agreed, you can assign it to yourselves. Now that admin stuff is out of the way, can you explain a little more on "exposed when running a mvn-rpmbuild against system dependencies". Harmless patch it is, but I'd like to understand what it is fixing. Thanks!
          Timothy St. Clair made changes -
          Assignee Timothy St. Clair [ tstclair ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12585452/HADOOP-9610.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3910//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3910//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12585452/HADOOP-9610.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3910//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3910//console This message is automatically generated.
          Hide
          Timothy St. Clair added a comment -

          The dependency graph requires explicit call-out when building against system dependencies, because indirect dependencies usually get a pass when building directly from maven repos. This is exposed when packaging against system-distro based jars vs. maven repo based jars.

          The goal in doing this, is to enable packaging on fedora.

          Show
          Timothy St. Clair added a comment - The dependency graph requires explicit call-out when building against system dependencies, because indirect dependencies usually get a pass when building directly from maven repos. This is exposed when packaging against system-distro based jars vs. maven repo based jars. The goal in doing this, is to enable packaging on fedora.
          Robert Rati made changes -
          Attachment HADOOP-2.2.0-9610.patch [ 12610119 ]
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12610119/HADOOP-2.2.0-9610.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4135//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4135//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12610119/HADOOP-2.2.0-9610.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4135//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/4135//console This message is automatically generated.
          Steve Loughran made changes -
          Link This issue is depended upon by HADOOP-9991 [ HADOOP-9991 ]
          Hide
          Steve Loughran added a comment -

          Fixed! (This doesn't just help builds, it helps IDEs understand what's going on)

          Show
          Steve Loughran added a comment - Fixed! (This doesn't just help builds, it helps IDEs understand what's going on)
          Steve Loughran made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 2.3.0 [ 12324590 ]
          Resolution Fixed [ 1 ]
          Robert Rati made changes -
          Link This issue is duplicated by HADOOP-10096 [ HADOOP-10096 ]
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #4728 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4728/)
          MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-mapreduce-project
          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #4728 (See https://builds.apache.org/job/Hadoop-trunk-Commit/4728/ ) MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-mapreduce-project /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Hide
          Steve Loughran added a comment -

          oh, and +1

          Show
          Steve Loughran added a comment - oh, and +1
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/)
          MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-mapreduce-project
          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #391 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/391/ ) MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-mapreduce-project /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/)
          MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-mapreduce-project
          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Show
          Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1608 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1608/ ) MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-mapreduce-project /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/)
          MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682)

          • /hadoop/common/trunk
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml
          • /hadoop/common/trunk/hadoop-mapreduce-project
          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Show
          Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1582 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1582/ ) MAPREDUCE-5431 Missing pom dependency in MR-client (stevel: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1541682 ) /hadoop/common/trunk /hadoop/common/trunk/hadoop-common-project/hadoop-common/pom.xml /hadoop/common/trunk/hadoop-mapreduce-project /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          Arun C Murthy made changes -
          Fix Version/s 2.3.0 [ 12325257 ]
          Fix Version/s 2.4.0 [ 12324590 ]
          Arun C Murthy made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          2m 2s 1 Timothy St. Clair 30/May/13 18:56
          Patch Available Patch Available Resolved Resolved
          167d 56m 1 Steve Loughran 13/Nov/13 19:53
          Resolved Resolved Closed Closed
          103d 1h 4m 1 Arun C Murthy 24/Feb/14 20:57

            People

            • Assignee:
              Timothy St. Clair
              Reporter:
              Timothy St. Clair
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development