Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 0.23.1, 2.0.0-alpha
    • Fix Version/s: 2.1.0-beta, 0.23.9
    • Component/s: distcp
    • Labels:
      None

      Description

      DistCp doesn't check the job-status when run in blocking-mode, before returning its exit-code. (The Yahoo-internal version did this correctly.)

      In blocking-mode, DistCp must check that the launched job runs to completion, and return an appropriate exit-code.

      Pretty serious bug, since it affects data integrity, in Oozie-launched-DistCp actions.

      (I could've sworn I had another JIRA with this patch attached.)

      1. MAPREDUCE-5315-2.patch
        0.8 kB
        Jason Lowe
      2. MAPREDUCE-5315.branch-0.23.patch
        0.7 kB
        Mithun Radhakrishnan

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1455 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1455/)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914)

        Result = SUCCESS
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1455 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1455/ ) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1428 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1428/)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914)

        Result = FAILURE
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1428 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1428/ ) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914) Result = FAILURE daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #636 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/636/)
        svn merge -c 1491914 FIXES: MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491921)

        Result = SUCCESS
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491921
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #636 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/636/ ) svn merge -c 1491914 FIXES: MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491921) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491921 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #238 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/238/)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914)

        Result = SUCCESS
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #238 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/238/ ) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Hide
        Daryn Sharp added a comment -

        Committed to trunk, branch-2, branch-2.1-beta, and branch-23. Thanks Mithun & Jason!

        Show
        Daryn Sharp added a comment - Committed to trunk, branch-2, branch-2.1-beta, and branch-23. Thanks Mithun & Jason!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3897 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3897/)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917)
        MAPREDUCE-5315. DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914)

        Result = SUCCESS
        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt

        daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3897 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3897/ ) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491917) MAPREDUCE-5315 . DistCp reports success even on failure. (mithun and jlowe via daryn) (Revision 1491914) Result = SUCCESS daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491917 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt daryn : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1491914 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCp.java
        Hide
        Daryn Sharp added a comment -

        +1 Committing shortly.

        Show
        Daryn Sharp added a comment - +1 Committing shortly.
        Hide
        Jason Lowe added a comment -

        Is there perhaps a way to throw an exception that is more useful to the user than "something went wrong! go dig in the logs"?

        Good point, attaching an updated patch that should shed a bit more light in the exception message about a job that did not complete successfully.

        Show
        Jason Lowe added a comment - Is there perhaps a way to throw an exception that is more useful to the user than "something went wrong! go dig in the logs"? Good point, attaching an updated patch that should shed a bit more light in the exception message about a job that did not complete successfully.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12587132/MAPREDUCE-5315.branch-0.23.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-distcp.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3759//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3759//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12587132/MAPREDUCE-5315.branch-0.23.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-distcp. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3759//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3759//console This message is automatically generated.
        Hide
        Jason Lowe added a comment -

        Patch does apply to trunk, so kicking Jenkins. Looks like this has been broken at least since MAPREDUCE-2765, which is way back in 0.23.1.

        Show
        Jason Lowe added a comment - Patch does apply to trunk, so kicking Jenkins. Looks like this has been broken at least since MAPREDUCE-2765 , which is way back in 0.23.1.
        Hide
        Daryn Sharp added a comment -

        Is there perhaps a way to throw an exception that is more useful to the user than "something went wrong! go dig in the logs"?

        Show
        Daryn Sharp added a comment - Is there perhaps a way to throw an exception that is more useful to the user than "something went wrong! go dig in the logs"?
        Hide
        Karthik Kambatla added a comment -

        +1, looks good to me.

        Show
        Karthik Kambatla added a comment - +1, looks good to me.
        Hide
        Mithun Radhakrishnan added a comment -

        The fix. Patch should apply to branch-2 as well.

        Show
        Mithun Radhakrishnan added a comment - The fix. Patch should apply to branch-2 as well.

          People

          • Assignee:
            Mithun Radhakrishnan
            Reporter:
            Mithun Radhakrishnan
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development