Details

    • Hadoop Flags:
      Reviewed

      Description

      Method UtilTest#isCygwin in /hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java appears to be unused. If so, then we need to remove it. If anything is calling it, then we need to update the naming to isWindows, or perhaps just change call sites to use Shell#WINDOWS.

      1. MAPREDUCE-5045.001.patch
        0.9 kB
        Neelesh Srinivas Salian

        Issue Links

          Activity

          Hide
          neelesh77 Neelesh Srinivas Salian added a comment -

          Removed the method isCygwin() from UtilTest since it isn't being used.
          Requesting review.

          Show
          neelesh77 Neelesh Srinivas Salian added a comment - Removed the method isCygwin() from UtilTest since it isn't being used. Requesting review.
          Hide
          qwertymaniac Harsh J added a comment -

          +1 lgtm, checked also for any existing use of it in trunk, and in branch-2, and found none. Can be safely removed.

          Will commit after Jenkins +1.

          Show
          qwertymaniac Harsh J added a comment - +1 lgtm, checked also for any existing use of it in trunk, and in branch-2, and found none. Can be safely removed. Will commit after Jenkins +1.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 6m 10s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 46s There were no new javac warning messages.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 0m 24s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 0m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 tools/hadoop tests 2m 48s Tests failed in hadoop-streaming.
              20m 22s  



          Reason Tests
          Failed unit tests hadoop.streaming.TestDumpTypedBytes
            hadoop.streaming.TestMultipleCachefiles
            hadoop.streaming.TestLoadTypedBytes
            hadoop.streaming.TestStreamingBadRecords
            hadoop.streaming.TestFileArgs
            hadoop.streaming.TestSymLink
            hadoop.streaming.TestMultipleArchiveFiles



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12761320/MAPREDUCE-5045.001.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 3a9c707
          hadoop-streaming test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/artifact/patchprocess/testrun_hadoop-streaming.txt
          Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 46s There were no new javac warning messages. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 0m 24s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 0m 47s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 tools/hadoop tests 2m 48s Tests failed in hadoop-streaming.     20m 22s   Reason Tests Failed unit tests hadoop.streaming.TestDumpTypedBytes   hadoop.streaming.TestMultipleCachefiles   hadoop.streaming.TestLoadTypedBytes   hadoop.streaming.TestStreamingBadRecords   hadoop.streaming.TestFileArgs   hadoop.streaming.TestSymLink   hadoop.streaming.TestMultipleArchiveFiles Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12761320/MAPREDUCE-5045.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 3a9c707 hadoop-streaming test log https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/artifact/patchprocess/testrun_hadoop-streaming.txt Test Results https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/6007/console This message was automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          The tests under streaming appear to have failed due to a missing mockito dependency:

          java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer
          	at java.net.URLClassLoader$1.run(URLClassLoader.java:366)
          	at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
          	at java.security.AccessController.doPrivileged(Native Method)
          	at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:425)
          	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308)
          	at java.lang.ClassLoader.loadClass(ClassLoader.java:358)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.shouldWait(MiniDFSCluster.java:2489)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2385)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2428)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1607)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:840)
          	at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:478)
          	at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:437)
          	at org.apache.hadoop.streaming.TestDumpTypedBytes.testDumping(TestDumpTypedBytes.java:42)
          

          This seems related to the MiniDFSCluster rather than this change. I've double confirmed there is indeed no usage of this method, proceeding with commit.

          Show
          qwertymaniac Harsh J added a comment - The tests under streaming appear to have failed due to a missing mockito dependency: java.lang.NoClassDefFoundError: org/mockito/stubbing/Answer at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang. ClassLoader .loadClass( ClassLoader .java:425) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:308) at java.lang. ClassLoader .loadClass( ClassLoader .java:358) at org.apache.hadoop.hdfs.MiniDFSCluster.shouldWait(MiniDFSCluster.java:2489) at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2385) at org.apache.hadoop.hdfs.MiniDFSCluster.waitActive(MiniDFSCluster.java:2428) at org.apache.hadoop.hdfs.MiniDFSCluster.startDataNodes(MiniDFSCluster.java:1607) at org.apache.hadoop.hdfs.MiniDFSCluster.initMiniDFSCluster(MiniDFSCluster.java:840) at org.apache.hadoop.hdfs.MiniDFSCluster.<init>(MiniDFSCluster.java:478) at org.apache.hadoop.hdfs.MiniDFSCluster$Builder.build(MiniDFSCluster.java:437) at org.apache.hadoop.streaming.TestDumpTypedBytes.testDumping(TestDumpTypedBytes.java:42) This seems related to the MiniDFSCluster rather than this change. I've double confirmed there is indeed no usage of this method, proceeding with commit.
          Hide
          neelesh77 Neelesh Srinivas Salian added a comment -

          Thank you Harsh J

          Show
          neelesh77 Neelesh Srinivas Salian added a comment - Thank you Harsh J
          Hide
          qwertymaniac Harsh J added a comment -

          Committed to branch-2 and trunk. Thank you for the contribution, Neelesh!

          Show
          qwertymaniac Harsh J added a comment - Committed to branch-2 and trunk. Thank you for the contribution, Neelesh!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8500 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8500/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8500 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8500/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #424 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/424/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #424 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/424/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #432 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/432/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #432 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/432/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2370 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2370/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2370 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2370/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1164 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1164/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-mapreduce-project/CHANGES.txt
          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1164 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1164/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-mapreduce-project/CHANGES.txt hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2343 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2343/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2343 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2343/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java hadoop-mapreduce-project/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #405 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/405/)
          MAPREDUCE-5045. UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495)

          • hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java
          • hadoop-mapreduce-project/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #405 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/405/ ) MAPREDUCE-5045 . UtilTest#isCygwin method appears to be unused. Contributed by Neelesh Srinivas Salian. (harsh: rev cc2b4739902df60254dce2ddb23ef8f6ff2a3495) hadoop-tools/hadoop-streaming/src/test/java/org/apache/hadoop/streaming/UtilTest.java hadoop-mapreduce-project/CHANGES.txt

            People

            • Assignee:
              neelesh77 Neelesh Srinivas Salian
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development