Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-502

Allow jobtracker to be configured with zero completed jobs in memory

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      If the number of jobs per user exceeded mapred.jobtracker.completeuserjobs.maximum then the job was flushed out of the jobtracker's memory after the job finishes min-time (hardcoded to 1 min). This caused jobclient's fail with NPE. In this patch the min-time to retain a job is made configurable (mapred.jobtracker.retirejob.interval.min).
      Show
      If the number of jobs per user exceeded mapred.jobtracker.completeuserjobs.maximum then the job was flushed out of the jobtracker's memory after the job finishes min-time (hardcoded to 1 min). This caused jobclient's fail with NPE. In this patch the min-time to retain a job is made configurable (mapred.jobtracker.retirejob.interval.min).

      Description

      There is no way to specify that the jobtracker should not keep any completed job in memory.

      1. MAPREDUCE-502-v1.1-branch-0.20-example.2.patch
        7 kB
        Amar Kamat
      2. MAPREDUCE-502-v1.1.patch
        11 kB
        Amar Kamat
      3. MAPREDUCE-502-v1.0.patch
        11 kB
        Amar Kamat
      4. HADOOP-4973-v2.2.patch
        11 kB
        Amar Kamat
      5. HADOOP-4973-v2.1.patch
        10 kB
        Amar Kamat

        Activity

        Amar Kamat created issue -
        Amar Kamat made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Won't Fix [ 2 ]
        Amar Kamat made changes -
        Resolution Won't Fix [ 2 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Amar Kamat [ amar_kamat ]
        Hide
        Amar Kamat added a comment -

        Attaching a patch that makes min-time-before-retire configurable. Added a test case.
        Result of test-patch :
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Running ant tests now.

        Show
        Amar Kamat added a comment - Attaching a patch that makes min-time-before-retire configurable. Added a test case. Result of test-patch : [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Running ant tests now.
        Amar Kamat made changes -
        Attachment HADOOP-4973-v2.1.patch [ 12411217 ]
        Hide
        Amar Kamat added a comment -

        Attaching a new patch incorporating Devaraj's offline comments. Testing the patch.

        Show
        Amar Kamat added a comment - Attaching a new patch incorporating Devaraj's offline comments. Testing the patch.
        Amar Kamat made changes -
        Attachment HADOOP-4973-v2.2.patch [ 12411223 ]
        Hide
        Amar Kamat added a comment -

        The changes are

        1. check for job after incremental changes to clock is changes to just once check
        2. two test cases
          1. min > max : check if the job survives min amount of time
          2. max > min : check if after max amount of time the job is expired
        3. removed some debug statements from jobtracker
        4. checkpoint renamed to snapshot
        5. Test description corrected and added some more comments.
        Show
        Amar Kamat added a comment - The changes are check for job after incremental changes to clock is changes to just once check two test cases min > max : check if the job survives min amount of time max > min : check if after max amount of time the job is expired removed some debug statements from jobtracker checkpoint renamed to snapshot Test description corrected and added some more comments.
        Owen O'Malley made changes -
        Project Hadoop Common [ 12310240 ] Hadoop Map/Reduce [ 12310941 ]
        Key HADOOP-4973 MAPREDUCE-502
        Affects Version/s 0.21.0 [ 12313563 ]
        Component/s mapred [ 12310690 ]
        Fix Version/s 0.21.0 [ 12313563 ]
        Hide
        Amar Kamat added a comment -

        Attaching a patch for map-reduce. Manually changed the patch. It applies cleanly and the newly added testcase passes.

        Show
        Amar Kamat added a comment - Attaching a patch for map-reduce. Manually changed the patch. It applies cleanly and the newly added testcase passes.
        Amar Kamat made changes -
        Attachment MAPREDUCE-502-v1.0.patch [ 12411376 ]
        Hide
        Amar Kamat added a comment -

        Attaching a new patch incorporating Devaraj's comments. Change :

        1. FakeClock can be used as it is in the testcase.

        TestJobRetrire passed on my box.

        Show
        Amar Kamat added a comment - Attaching a new patch incorporating Devaraj's comments. Change : FakeClock can be used as it is in the testcase. TestJobRetrire passed on my box.
        Amar Kamat made changes -
        Attachment MAPREDUCE-502-v1.1.patch [ 12411529 ]
        Hide
        Amar Kamat added a comment -

        Tests passed on my box.

        Show
        Amar Kamat added a comment - Tests passed on my box.
        Hide
        Amar Kamat added a comment -

        Result of test-patch on my box
        [exec] +1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] +1 tests included. The patch appears to include 6 new or modified tests.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Running ant tests

        Show
        Amar Kamat added a comment - Result of test-patch on my box [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 6 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. Running ant tests
        Hide
        Amar Kamat added a comment -

        Ant tests failed with TestNodeRefresh FAILED (timeout) and TestReduceFetch FAILED both of which are known to fail. test-contrib failed on TestStreamingExitStatus FAILED, TestStreamingStderr FAILED (timeout) and TestQueueCapacities FAILED (timeout) which are also known issues.

        Show
        Amar Kamat added a comment - Ant tests failed with TestNodeRefresh FAILED (timeout) and TestReduceFetch FAILED both of which are known to fail. test-contrib failed on TestStreamingExitStatus FAILED, TestStreamingStderr FAILED (timeout) and TestQueueCapacities FAILED (timeout) which are also known issues.
        Hide
        Sharad Agarwal added a comment -

        I committed this. Thanks Amar!

        Show
        Sharad Agarwal added a comment - I committed this. Thanks Amar!
        Sharad Agarwal made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.21.0 [ 12314045 ]
        Resolution Fixed [ 1 ]
        Hide
        Amar Kamat added a comment -

        Attaching an example patch for branch 0.20 not to be committed.

        Show
        Amar Kamat added a comment - Attaching an example patch for branch 0.20 not to be committed.
        Amar Kamat made changes -
        Amar Kamat made changes -
        Release Note If the number of jobs per user exceeded mapred.jobtracker.completeuserjobs.maximum then the job was flushed out of the jobtracker's memory after the job finishes min-time (hardcoded to 1 min). This caused jobclient's fail with NPE. In this patch the min-time to retain a job is made configurable (mapred.jobtracker.retirejob.interval.min).
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/)

        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #15 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/15/ )
        Tom White made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Amar Kamat
            Reporter:
            Amar Kamat
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development