Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.2
    • Fix Version/s: 1.2.0
    • Component/s: tasktracker, test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestJvmReuse on branch-1 consistently fails on an assertion.

      1. mr-4967.patch
        1 kB
        Karthik Kambatla

        Issue Links

          Activity

          Gavin made changes -
          Assignee Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
          Matt Foley made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Hide
          Matt Foley added a comment -

          Closed upon release of Hadoop 1.2.0.

          Show
          Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
          Hide
          Chris Nauroth added a comment -

          I submitted MAPREDUCE-4979 for follow-up.

          Show
          Chris Nauroth added a comment - I submitted MAPREDUCE-4979 for follow-up.
          Chris Nauroth made changes -
          Link This issue is related to MAPREDUCE-4979 [ MAPREDUCE-4979 ]
          Alejandro Abdelnur made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Hadoop Flags Reviewed [ 10343 ]
          Fix Version/s 1.2.0 [ 12321661 ]
          Resolution Fixed [ 1 ]
          Hide
          Alejandro Abdelnur added a comment -

          Thanks Karthik. Committed to branch-1.

          Show
          Alejandro Abdelnur added a comment - Thanks Karthik. Committed to branch-1.
          Hide
          Alejandro Abdelnur added a comment -

          +1. Lets open another JIRA to evaluate fix/removal of this test.

          Show
          Alejandro Abdelnur added a comment - +1. Lets open another JIRA to evaluate fix/removal of this test.
          Hide
          Chris Nauroth added a comment -

          +1

          I applied the patch, ran TestJvmReuse, and confirmed that the test gets ignored.

          I'm wondering if the class should be deleted at this point instead of leaving behind a test that's always ignored, or if we need to file a separate follow-up jira to figure out why it fails. The only related jira I could find is MAPREDUCE-3480. Does anyone else out there know additional history on this?

          Show
          Chris Nauroth added a comment - +1 I applied the patch, ran TestJvmReuse , and confirmed that the test gets ignored. I'm wondering if the class should be deleted at this point instead of leaving behind a test that's always ignored, or if we need to file a separate follow-up jira to figure out why it fails. The only related jira I could find is MAPREDUCE-3480 . Does anyone else out there know additional history on this?
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12567939/mr-4967.patch
          against trunk revision .

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3300//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12567939/mr-4967.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3300//console This message is automatically generated.
          Hide
          Surenkumar Nihalani added a comment -

          +1

          Show
          Surenkumar Nihalani added a comment - +1
          Karthik Kambatla (Inactive) made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Karthik Kambatla (Inactive) made changes -
          Attachment mr-4967.patch [ 12567939 ]
          Hide
          Karthik Kambatla (Inactive) added a comment -

          Uploading a trivial patch that converts TestJvmReuse to use junit4.

          ant test -Dtestcase=TestJvmReuse doesn't run any tests now.

          Show
          Karthik Kambatla (Inactive) added a comment - Uploading a trivial patch that converts TestJvmReuse to use junit4. ant test -Dtestcase=TestJvmReuse doesn't run any tests now.
          Karthik Kambatla (Inactive) made changes -
          Field Original Value New Value
          Assignee Karthik Kambatla [ kkambatl ]
          Hide
          Chris Nauroth added a comment -

          Here is the test output that I receive:

          Testcase: testTaskLogs took 13.995 sec
          	FAILED
          null
          junit.framework.AssertionFailedError: null
          	at org.apache.hadoop.mapred.TestJvmReuse.validateAttempt(TestJvmReuse.java:106)
          	at org.apache.hadoop.mapred.TestJvmReuse.validateJob(TestJvmReuse.java:134)
          	at org.apache.hadoop.mapred.TestJvmReuse.testTaskLogs(TestJvmReuse.java:158)
          

          The other interesting thing is that the test is marked to be ignored, a change introduced in MAPREDUCE-3480:

          @Ignore
          public class TestJvmReuse extends TestCase {
          

          However, it still runs during ant test. Perhaps the @Ignore isn't working as expected, such as if the JUnit 3 runner was getting invoked instead of JUnit 4.

          Show
          Chris Nauroth added a comment - Here is the test output that I receive: Testcase: testTaskLogs took 13.995 sec FAILED null junit.framework.AssertionFailedError: null at org.apache.hadoop.mapred.TestJvmReuse.validateAttempt(TestJvmReuse.java:106) at org.apache.hadoop.mapred.TestJvmReuse.validateJob(TestJvmReuse.java:134) at org.apache.hadoop.mapred.TestJvmReuse.testTaskLogs(TestJvmReuse.java:158) The other interesting thing is that the test is marked to be ignored, a change introduced in MAPREDUCE-3480 : @Ignore public class TestJvmReuse extends TestCase { However, it still runs during ant test . Perhaps the @Ignore isn't working as expected, such as if the JUnit 3 runner was getting invoked instead of JUnit 4.
          Chris Nauroth created issue -

            People

            • Assignee:
              Karthik Kambatla
              Reporter:
              Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development