Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0, 2.0.3-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: pipes
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

           [exec] /mnt/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc:130:58: warning: format not a string literal and no format arguments [-Wformat-security]
      
      1. mapreduce-4953.txt
        0.7 kB
        Andy Isaacson

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        4m 51s 1 Andy Isaacson 21/Jan/13 21:55
        Patch Available Patch Available Resolved Resolved
        14d 6h 59m 1 Aaron T. Myers 05/Feb/13 04:54
        Resolved Resolved Closed Closed
        10d 8h 15m 1 Arun C Murthy 15/Feb/13 13:10
        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #517 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/517/)
        MAPREDUCE-4953. HadoopPipes misuses fprintf. (Andy Isaacson via tgraves) (Revision 1442609)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442609
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #517 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/517/ ) MAPREDUCE-4953 . HadoopPipes misuses fprintf. (Andy Isaacson via tgraves) (Revision 1442609) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442609 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Thomas Graves made changes -
        Fix Version/s 0.23.7 [ 12323954 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1335 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1335/)
        MAPREDUCE-4953. HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1335 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1335/ ) MAPREDUCE-4953 . HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1307 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1307/)
        MAPREDUCE-4953. HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1307 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1307/ ) MAPREDUCE-4953 . HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #118 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/118/)
        MAPREDUCE-4953. HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471)

        Result = FAILURE
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #118 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/118/ ) MAPREDUCE-4953 . HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471) Result = FAILURE atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3323 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3323/)
        MAPREDUCE-4953. HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471)

        Result = SUCCESS
        atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3323 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3323/ ) MAPREDUCE-4953 . HadoopPipes misuses fprintf. Contributed by Andy Isaacson. (Revision 1442471) Result = SUCCESS atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1442471 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-tools/hadoop-pipes/src/main/native/pipes/impl/HadoopPipes.cc
        Aaron T. Myers made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.3-alpha [ 12323275 ]
        Resolution Fixed [ 1 ]
        Hide
        Aaron T. Myers added a comment -

        I've just committed this to trunk and branch-2.

        Thanks a lot for the contribution, Andy.

        Show
        Aaron T. Myers added a comment - I've just committed this to trunk and branch-2. Thanks a lot for the contribution, Andy.
        Hide
        Aaron T. Myers added a comment -

        +1, the patch looks good to me. I confirmed that this gets rid of the compiler warning.

        I'm going to commit this momentarily.

        Show
        Aaron T. Myers added a comment - +1, the patch looks good to me. I confirmed that this gets rid of the compiler warning. I'm going to commit this momentarily.
        Hide
        Colin Patrick McCabe added a comment -

        looks good to me

        Show
        Colin Patrick McCabe added a comment - looks good to me
        Hide
        Andy Isaacson added a comment -

        Since hitting the bug would probably segfault the Pipes app, and the fix is trivially correct, no tests are included.

        Show
        Andy Isaacson added a comment - Since hitting the bug would probably segfault the Pipes app, and the fix is trivially correct, no tests are included.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12565858/mapreduce-4953.txt
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in .

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3259//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3259//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565858/mapreduce-4953.txt against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in . +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3259//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3259//console This message is automatically generated.
        Andy Isaacson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Andy Isaacson made changes -
        Field Original Value New Value
        Attachment mapreduce-4953.txt [ 12565858 ]
        Hide
        Andy Isaacson added a comment -

        Fix the warning by switching to fputs.

        Show
        Andy Isaacson added a comment - Fix the warning by switching to fputs.
        Andy Isaacson created issue -

          People

          • Assignee:
            Andy Isaacson
            Reporter:
            Andy Isaacson
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development