Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.2-alpha
    • Fix Version/s: 2.0.3-alpha, 0.23.7
    • Component/s: examples
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the hadoop pi example uses a hardcoded temporary directory to store its inputs and outputs. This makes it so that only one pi job can run at a time, and that if it is cancelled, the temporary directory must be manually deleted.

      I propose using a temporary directory based on a timestamp and random number to avoid these conflicts

        Activity

        Arun C Murthy made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/)
        MAPREDUCE-4949. Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1441589)

        Result = SUCCESS
        tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441589
        Files :

        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-0.23-Build #513 (See https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/513/ ) MAPREDUCE-4949 . Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1441589) Result = SUCCESS tgraves : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1441589 Files : /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Thomas Graves made changes -
        Fix Version/s 0.23.7 [ 12323954 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Mapreduce-trunk #1322 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1322/)
        MAPREDUCE-4949. Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1322 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1322/ ) MAPREDUCE-4949 . Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #1294 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1294/)
        MAPREDUCE-4949. Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029)

        Result = FAILURE
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1294 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1294/ ) MAPREDUCE-4949 . Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029) Result = FAILURE tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Yarn-trunk #105 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/105/)
        MAPREDUCE-4949. Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        Hudson added a comment - Integrated in Hadoop-Yarn-trunk #105 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/105/ ) MAPREDUCE-4949 . Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Hide
        Sandy Ryza added a comment -

        Thanks Alejandro!

        Show
        Sandy Ryza added a comment - Thanks Alejandro!
        Hide
        Hudson added a comment -

        Integrated in Hadoop-trunk-Commit #3267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3267/)
        MAPREDUCE-4949. Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029)

        Result = SUCCESS
        tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029
        Files :

        • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
        • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Show
        Hudson added a comment - Integrated in Hadoop-trunk-Commit #3267 (See https://builds.apache.org/job/Hadoop-trunk-Commit/3267/ ) MAPREDUCE-4949 . Enable multiple pi jobs to run in parallel. (sandyr via tucu) (Revision 1437029) Result = SUCCESS tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1437029 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-examples/src/main/java/org/apache/hadoop/examples/QuasiMonteCarlo.java
        Alejandro Abdelnur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 2.0.3-alpha [ 12323275 ]
        Resolution Fixed [ 1 ]
        Hide
        Alejandro Abdelnur added a comment -

        Thanks Sandy. Committed to trunk and branch-2.

        Show
        Alejandro Abdelnur added a comment - Thanks Sandy. Committed to trunk and branch-2.
        Hide
        Alejandro Abdelnur added a comment -

        +3.141592

        Show
        Alejandro Abdelnur added a comment - +3.141592
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12565577/MAPREDUCE-4949.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3251//testReport/
        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3251//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12565577/MAPREDUCE-4949.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-examples. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3251//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3251//console This message is automatically generated.
        Sandy Ryza made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Sandy Ryza made changes -
        Field Original Value New Value
        Attachment MAPREDUCE-4949.patch [ 12565577 ]
        Sandy Ryza created issue -

          People

          • Assignee:
            Sandy Ryza
            Reporter:
            Sandy Ryza
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development