Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.1
    • Fix Version/s: 1.2.0
    • Component/s: mrv1
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In MR1, only mapred.task.timeout works. Both should be made to work.

        Activity

        Sandy Ryza created issue -
        Sandy Ryza made changes -
        Field Original Value New Value
        Assignee Sandy Ryza [ sandyr ]
        Sandy Ryza made changes -
        Attachment MAPREDUCE-4929-branch-1.patch [ 12563998 ]
        Sandy Ryza made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 1.1.1 [ 12321660 ]
        Target Version/s 1.1.2 [ 12323594 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12563998/MAPREDUCE-4929-branch-1.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3218//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12563998/MAPREDUCE-4929-branch-1.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3218//console This message is automatically generated.
        Hide
        Karthik Kambatla added a comment -

        Sandy, just curious, what should the behavior be if a user sets both but to different values? Do we give higher priority to mapred/mapreduce?

        Show
        Karthik Kambatla added a comment - Sandy, just curious, what should the behavior be if a user sets both but to different values? Do we give higher priority to mapred/mapreduce?
        Hide
        Sandy Ryza added a comment -

        As mapred.task.timeout is the one mentioned in the documentation, I made it so that it gets preference. Do you think that's the right behavior?

        Show
        Sandy Ryza added a comment - As mapred.task.timeout is the one mentioned in the documentation, I made it so that it gets preference. Do you think that's the right behavior?
        Hide
        Alejandro Abdelnur added a comment -

        It looks good to me, but before committing it, what is the precedence behavior in trunk? to make sure we have the same behavior.

        Show
        Alejandro Abdelnur added a comment - It looks good to me, but before committing it, what is the precedence behavior in trunk? to make sure we have the same behavior.
        Hide
        Sandy Ryza added a comment -

        It doesn't exactly appear that there is precedence behavior in trunk. When a Configuration#set() is called for a config with deprecations, all the corresponding configs are set. So if we came across mapred.task.timeout first in a config file, both mapred.task.timeout and mapreduce.task.timeout would get set. Then if we came across mapreduce.task.timeout afterwards, both would get overriden.

        Show
        Sandy Ryza added a comment - It doesn't exactly appear that there is precedence behavior in trunk. When a Configuration#set() is called for a config with deprecations, all the corresponding configs are set. So if we came across mapred.task.timeout first in a config file, both mapred.task.timeout and mapreduce.task.timeout would get set. Then if we came across mapreduce.task.timeout afterwards, both would get overriden.
        Hide
        Tom White added a comment -

        +1 the precedence looks right to me.

        Show
        Tom White added a comment - +1 the precedence looks right to me.
        Hide
        Tom White added a comment -

        I just committed this. Thanks, Sandy!

        Show
        Tom White added a comment - I just committed this. Thanks, Sandy!
        Tom White made changes -
        Resolution Fixed [ 1 ]
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Target Version/s 1.1.2 [ 12323594 ]
        Fix Version/s 1.2.0 [ 12321661 ]
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Sandy Ryza
            Reporter:
            Sandy Ryza
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development