Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.0
    • Fix Version/s: 1.2.0
    • Component/s: test
    • Labels:
      None

      Description

      TestMultipleLevelCaching will failed:

      Testcase: testMultiLevelCaching took 30.406 sec
              FAILED
      Number of local maps expected:<0> but was:<1>
      junit.framework.AssertionFailedError: Number of local maps expected:<0> but was:<1>
              at org.apache.hadoop.mapred.TestRackAwareTaskPlacement.launchJobAndTestCounters(TestRackAwareTaskPlacement.java:78)
              at org.apache.hadoop.mapred.TestMultipleLevelCaching.testCachingAtLevel(TestMultipleLevelCaching.java:113)
              at org.apache.hadoop.mapred.TestMultipleLevelCaching.testMultiLevelCaching(TestMultipleLevelCaching.java:69)
      
      
      1. MAPREDUCE-4904-v2.patch
        1 kB
        Junping Du
      2. MAPREDUCE-4904-v2.patch
        1 kB
        Junping Du
      3. MAPREDUCE-4904.patch
        0.6 kB
        Junping Du

        Activity

        Hide
        Junping Du added a comment -

        Attach a quick fix. Meng, Would you verify it works on your env as well?

        Show
        Junping Du added a comment - Attach a quick fix. Meng, Would you verify it works on your env as well?
        Hide
        Luke Lu added a comment -

        Please add a comment about the switch fall-through, as it's not obvious and would raise more questions in later maintenance.

        Show
        Luke Lu added a comment - Please add a comment about the switch fall-through, as it's not obvious and would raise more questions in later maintenance.
        Hide
        Junping Du added a comment -

        Sure. Thanks Luke for comments.
        If localityLevel =2 and in case of without-NodeGroup, the task should be counted into OTHER_LOCAL_MAPS (it should go to "default" below to be handled rather than being break out). This tiny patch fix this issue.

        Show
        Junping Du added a comment - Sure. Thanks Luke for comments. If localityLevel =2 and in case of without-NodeGroup, the task should be counted into OTHER_LOCAL_MAPS (it should go to "default" below to be handled rather than being break out). This tiny patch fix this issue.
        Hide
        Luke Lu added a comment -

        I meant that you should add a comment (e.g. // fall through. see MAPREDUCE-4904) to the patch Otherwise, the switch code would look a little strange to later maintainers and cause some unnecessary head-scratching.

        Show
        Luke Lu added a comment - I meant that you should add a comment (e.g. // fall through. see MAPREDUCE-4904 ) to the patch Otherwise, the switch code would look a little strange to later maintainers and cause some unnecessary head-scratching.
        Hide
        Junping Du added a comment -

        Incorporate Luke's comments with adding comments to fall through in switch case.

        Show
        Junping Du added a comment - Incorporate Luke's comments with adding comments to fall through in switch case.
        Hide
        Junping Du added a comment -

        use --no-prefix to generate patch in new v2 patch.

        Show
        Junping Du added a comment - use --no-prefix to generate patch in new v2 patch.
        Hide
        Luke Lu added a comment -

        +1. Verified that the fix works for me.

        Show
        Luke Lu added a comment - +1. Verified that the fix works for me.
        Hide
        Luke Lu added a comment -

        Committed to branch-1. Thanks Junping for the patch!

        Show
        Luke Lu added a comment - Committed to branch-1. Thanks Junping for the patch!
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.

          People

          • Assignee:
            Junping Du
            Reporter:
            meng gong
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development