[MAPREDUCE-4822] Unnecessary conversions in History Events

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.23.4
• Fix Version/s: 2.0.3-alpha, 0.23.7
• Component/s: jobhistoryserver
• Labels: patch
• Target Version/s: 0.23.4
• Hadoop Flags: Reviewed
• Assignee: Chu Tong
• Reporter: Robert Joseph Evans
• Created: 27/Nov/12 15:46
• Updated: 15/Feb/13 13:10
• Resolved: 06/Feb/13 23:04

Description

There are a number of conversions in the Job History Event classes that are totally unnecessary. It appears that they were originally used to convert from the internal avro format, but now many of them do not pull the values from the avro they store them internally.

For example:

TaskAttemptFinishedEvent.java

  /** Get the task type */
  public TaskType getTaskType() {
    return TaskType.valueOf(taskType.toString());
  }

The code currently is taking an enum, converting it to a string and then asking the same enum to convert it back to an enum. If java work properly this should be a noop and a reference to the original taskType should be returned.

There are several places that a string is having toString called on it, and since strings are immutable it returns a reference to itself.

The various ids are not immutable and probably should not be changed at this point.