Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4806

Cleanup: Some (5) private methods in JobTracker.RecoveryManager are not used anymore after MAPREDUCE-3837

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: 1.2.0
    • Component/s: mrv1
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      MAPREDUCE-3837 re-organized the job recovery code, moving out the code that was using the methods in RecoveryManager.

      Now, the following methods in {{JobTracker.RecoveryManager}}seem to be unused:

      1. updateJob()
      2. updateTip()
      3. createTaskAttempt()
      4. addSuccessfulAttempt()
      5. addUnsuccessfulAttempt()
      1. mr-4806.patch
        9 kB
        Karthik Kambatla

        Activity

        Karthik Kambatla (Inactive) created issue -
        Karthik Kambatla (Inactive) made changes -
        Field Original Value New Value
        Assignee Karthik Kambatla [ kkambatl ]
        Hide
        Karthik Kambatla (Inactive) added a comment -

        The patch deletes this methods from JT.RecoveryManager. No tests because all the removed methods are private and don't affect any tests.

        Ran a sample pi job.

        Show
        Karthik Kambatla (Inactive) added a comment - The patch deletes this methods from JT.RecoveryManager. No tests because all the removed methods are private and don't affect any tests. Ran a sample pi job.
        Karthik Kambatla (Inactive) made changes -
        Attachment mr-4806.patch [ 12561790 ]
        Karthik Kambatla (Inactive) made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12561790/mr-4806.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3141//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12561790/mr-4806.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3141//console This message is automatically generated.
        Hide
        Tom White added a comment -

        +1 I just committed this. Thanks, Karthik!

        Show
        Tom White added a comment - +1 I just committed this. Thanks, Karthik!
        Tom White made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 1.2.0 [ 12321661 ]
        Resolution Fixed [ 1 ]
        Hide
        Karthik Kambatla (Inactive) added a comment -

        Thanks for looking into this, Tom.

        Show
        Karthik Kambatla (Inactive) added a comment - Thanks for looking into this, Tom.
        Hide
        Matt Foley added a comment -

        Closed upon release of Hadoop 1.2.0.

        Show
        Matt Foley added a comment - Closed upon release of Hadoop 1.2.0.
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Gavin made changes -
        Assignee Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
        Gavin made changes -
        Reporter Karthik Kambatla [ kkambatl ] Karthik Kambatla [ kasha ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        32d 22h 20m 1 Karthik Kambatla (Inactive) 19/Dec/12 21:52
        Patch Available Patch Available Resolved Resolved
        18h 2m 1 Tom White 20/Dec/12 15:55
        Resolved Resolved Closed Closed
        145d 13h 21m 1 Matt Foley 15/May/13 06:16

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development