Hadoop Map/Reduce
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4792

Unit Test TestJobTrackerRestartWithLostTracker fails with ant-1.8.4

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.3, 1.0.4
    • Fix Version/s: 1.1.1
    • Component/s: test
    • Labels:
      None
    • Environment:

      fedora 17_64 x86

    • Target Version/s:

      Description

      Problem:
      JUnit tag @Ignore is not recognized since the testcase is JUnit3 and not JUnit4:
      Solution:
      Migrate the testcase to JUnit4, including:

      • Remove extends TestCase"
      • Remove import junit.framework.TestCase;
      • Add import org.junit.*;
      • Use appropriate annotations such as @After, @Before, @Test.

        Activity

        Hide
        Amir Sanjar added a comment -

        testcase is not in the trunk

        Show
        Amir Sanjar added a comment - testcase is not in the trunk
        Hide
        Amir Sanjar added a comment -

        tested with ant 1.7.x and 1.8.4

        Show
        Amir Sanjar added a comment - tested with ant 1.7.x and 1.8.4
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12553344/MAPREDUCE-4792-branch-1.patch
        against trunk revision .

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3025//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12553344/MAPREDUCE-4792-branch-1.patch against trunk revision . -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3025//console This message is automatically generated.
        Hide
        Matt Foley added a comment -

        Amir, the attached patch seems okay (although it would be fine to keep the "import org/junit/*" instead of adding all the specific cases).

        +1. Committed to branch-1 and branch-1.1.

        Show
        Matt Foley added a comment - Amir, the attached patch seems okay (although it would be fine to keep the "import org/junit/*" instead of adding all the specific cases). +1. Committed to branch-1 and branch-1.1.
        Hide
        Matt Foley added a comment -

        Closed upon release of 1.1.1.

        Show
        Matt Foley added a comment - Closed upon release of 1.1.1.

          People

          • Assignee:
            Amir Sanjar
            Reporter:
            Amir Sanjar
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development