Uploaded image for project: 'Hadoop Map/Reduce'
  1. Hadoop Map/Reduce
  2. MAPREDUCE-4686

hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      After importing all of hadoop-common trunk into Eclipse with the m2e plugin, the Avro-generated classes in hadoop-mapreduce-client-core don't show up on Eclipse's classpath. This causes compilation errors for anything that depends on those classes.

      1. HADOOP-8848.patch
        1 kB
        Chris Nauroth

        Issue Links

          Activity

          Hide
          ctrezzo Chris Trezzo added a comment -

          Chris Nauroth I noticed that this patch was removed from trunk by HADOOP-9304. It seems like Eclipse m2e builds still need it. I am currently building with Eclipse Neon.2 Release (4.6.2) on Mac 10.12. With a fresh project import, I still need to add the generated-source directory or the m2e build will not work.

          Is there any way you could add this commit back to trunk? Thanks!

          Show
          ctrezzo Chris Trezzo added a comment - Chris Nauroth I noticed that this patch was removed from trunk by HADOOP-9304 . It seems like Eclipse m2e builds still need it. I am currently building with Eclipse Neon.2 Release (4.6.2) on Mac 10.12. With a fresh project import, I still need to add the generated-source directory or the m2e build will not work. Is there any way you could add this commit back to trunk? Thanks!
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk #1178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1178/)
          MAPREDUCE-4686. hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #1178 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1178/ ) MAPREDUCE-4686 . hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk-Commit #2797 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2797/)
          MAPREDUCE-4686. hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446)

          Result = FAILURE
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk-Commit #2797 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2797/ ) MAPREDUCE-4686 . hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446) Result = FAILURE harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #2838 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2838/)
          MAPREDUCE-4686. hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #2838 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2838/ ) MAPREDUCE-4686 . hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Common-trunk-Commit #2775 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2775/)
          MAPREDUCE-4686. hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Common-trunk-Commit #2775 (See https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2775/ ) MAPREDUCE-4686 . hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Hide
          hudson Hudson added a comment -

          Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/)
          MAPREDUCE-4686. hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446)

          Result = SUCCESS
          harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446
          Files :

          • /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
          • /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Show
          hudson Hudson added a comment - Integrated in Hadoop-Mapreduce-trunk #1208 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1208/ ) MAPREDUCE-4686 . hadoop-mapreduce-client-core fails compilation in Eclipse due to missing Avro-generated classes. Contributed by Chris Nauroth. (harsh) (Revision 1390446) Result = SUCCESS harsh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1390446 Files : /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/pom.xml
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546648/HADOOP-8848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2885//testReport/
          Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2885//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546648/HADOOP-8848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2885//testReport/ Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2885//console This message is automatically generated.
          Hide
          qwertymaniac Harsh J added a comment -

          Thanks Chris! This looked good to me so I went ahead and committed it to trunk.

          Show
          qwertymaniac Harsh J added a comment - Thanks Chris! This looked good to me so I went ahead and committed it to trunk.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12546648/HADOOP-8848.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1525//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1525//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12546648/HADOOP-8848.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . The javadoc tool did not generate any warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1525//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1525//console This message is automatically generated.
          Hide
          cnauroth Chris Nauroth added a comment -

          The attached patch fixes the problem in the module's pom.xml by adding the Avro-generated source folder using build-helper-maven-plugin. Other modules have used a similar strategy. (See hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/pom.xml.) With this patch in place, it's possible to do a fresh import of all of hadoop-common trunk into Eclipse and see it compile successfully immediately.

          Note that this problem did not harm the typical Maven build. It was just a problem for fresh project imports into Eclipse.

          Show
          cnauroth Chris Nauroth added a comment - The attached patch fixes the problem in the module's pom.xml by adding the Avro-generated source folder using build-helper-maven-plugin. Other modules have used a similar strategy. (See hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-common/pom.xml.) With this patch in place, it's possible to do a fresh import of all of hadoop-common trunk into Eclipse and see it compile successfully immediately. Note that this problem did not harm the typical Maven build. It was just a problem for fresh project imports into Eclipse.

            People

            • Assignee:
              cnauroth Chris Nauroth
              Reporter:
              cnauroth Chris Nauroth
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development